Skip to contentSkip to conversation

xfsprogs/db: version command misses RMAPBT feature string

PATCH In review Zorro Lang 3 participants 3 messages Sep 18, 2017

lore
Share & tools
lore

Zorro Lang

author
#0 lore raw

PATCH 1/1 xfsprogs/db: version command misses RMAPBT feature string

When I create a XFS with "rmapbt=1,reflink=1", "xfs_db -c version" didn't show RMAPBT feature. But REFLINK can be found.

  # mkfs/mkfs.xfs -f -m rmapbt=1,reflink=1 /dev/sda3
  # db/xfs_db -c version /dev/sda3
  versionnum [0xb4a5+0x18a] = V5,NLINK,DIRV2,ALIGN,LOGV2,EXTFLG,MOREBITS,ATTR2,LAZYSBCOUNT,PROJID32BIT,CRC,FTYPE,FINOBT,REFLINK
Signed-off-by Zorro Lang <[email protected]>
---
 db/sb.c | 2 ++
 1 file changed, 2 insertions(+)
db/sb.c +2 -0
index 8e7722cd..01d94a66 100644
@@ -694,6 +694,8 @@ version_string(
 		strcat(s, ",SPARSE_INODES");
 	if (xfs_sb_version_hasmetauuid(sbp))
 		strcat(s, ",META_UUID");
+	if (xfs_sb_version_hasrmapbt(sbp))
+		strcat(s, ",RMAPBT");
 	if (xfs_sb_version_hasreflink(sbp))
 		strcat(s, ",REFLINK");
 	return s;
Signature · 1 line
2.13.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Zorro Lang

When I create a XFS with "rmapbt=1,reflink=1", "xfs_db -c version" didn't show RMAPBT feature. But REFLINK can be found.

  # mkfs/mkfs.xfs -f -m rmapbt=1,reflink=1 /dev/sda3
  # db/xfs_db -c version /dev/sda3
  versionnum [0xb4a5+0x18a] = V5,NLINK,DIRV2,ALIGN,LOGV2,EXTFLG,MOREBITS,ATTR2,LAZYSBCOUNT,PROJID32BIT,CRC,FTYPE,FINOBT,REFLINK
Signed-off-by Zorro Lang <[email protected]>

---

Reviewed-by Brian Foster <[email protected]>
Quoted 23 lines
 db/sb.c | 2 ++
 1 file changed, 2 insertions(+)
db/sb.c +2 -0
index 8e7722cd..01d94a66 100644
@@ -694,6 +694,8 @@ version_string(
 		strcat(s, ",SPARSE_INODES");
 	if (xfs_sb_version_hasmetauuid(sbp))
 		strcat(s, ",META_UUID");
+	if (xfs_sb_version_hasrmapbt(sbp))
+		strcat(s, ",RMAPBT");
 	if (xfs_sb_version_hasreflink(sbp))
 		strcat(s, ",REFLINK");
 	return s;
Signature · 6 lines
2.13.5

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Reviewed-by on v1 1/1
#2 lore raw
In reply to Zorro Lang
Quoted 8 lines · Zorro Lang

When I create a XFS with "rmapbt=1,reflink=1", "xfs_db -c version" didn't show RMAPBT feature. But REFLINK can be found.

  # mkfs/mkfs.xfs -f -m rmapbt=1,reflink=1 /dev/sda3
  # db/xfs_db -c version /dev/sda3
  versionnum [0xb4a5+0x18a] = V5,NLINK,DIRV2,ALIGN,LOGV2,EXTFLG,MOREBITS,ATTR2,LAZYSBCOUNT,PROJID32BIT,CRC,FTYPE,FINOBT,REFLINK
Signed-off-by Zorro Lang <[email protected]>
Reviewed-by Darrick J. Wong <[email protected]>
Quoted 24 lines
---
 db/sb.c | 2 ++
 1 file changed, 2 insertions(+)
db/sb.c +2 -0
index 8e7722cd..01d94a66 100644
@@ -694,6 +694,8 @@ version_string(
 		strcat(s, ",SPARSE_INODES");
 	if (xfs_sb_version_hasmetauuid(sbp))
 		strcat(s, ",META_UUID");
+	if (xfs_sb_version_hasrmapbt(sbp))
+		strcat(s, ",RMAPBT");
 	if (xfs_sb_version_hasreflink(sbp))
 		strcat(s, ",REFLINK");
 	return s;
Signature · 6 lines
2.13.5

--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html