Skip to contentSkip to conversation

rtc: jz4740: fix loading of rtc driver

PATCH Applied Mathieu Malaterre 2 participants 2 messages Sep 18, 2017 – Oct 12, 2017

Subsystems (2)
Real time clock (RTC) Ingenic JZ47xx SoCs
lore
Share & tools
lore

Mathieu Malaterre

author
#0 lore raw

PATCH 1/1 rtc: jz4740: fix loading of rtc driver

The current timeout for waiting for WRDY is not always sufficient. Always increase it to 10000 even on JZ4740. This is technically only required on JZ4780, where the current symptoms seen after a hard reboot are:

jz4740-rtc 10003000.rtc: rtc core: registered 10003000.rtc as rtc0 jz4740-rtc 10003000.rtc: Could not write to RTC registers
jz4740-rtc: probe of 10003000.rtc failed with error -5

Suggested-by Alex Smith <[email protected]>
Cc Zubair Lutfullah Kakakhel <[email protected]>
Signed-off-by Mathieu Malaterre <[email protected]>
---
 drivers/rtc/rtc-jz4740.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/rtc/rtc-jz4740.c +2 -2
index c9536fb0ba4a..ff65a7d2b9c9 100644
@@ -82,7 +82,7 @@ static inline uint32_t jz4740_rtc_reg_read(struct jz4740_rtc *rtc, size_t reg)
 static int jz4740_rtc_wait_write_ready(struct jz4740_rtc *rtc)
 {
 	uint32_t ctrl;
-	int timeout = 1000;
+	int timeout = 10000;
 
 	do {
 		ctrl = jz4740_rtc_reg_read(rtc, JZ_REG_RTC_CTRL);

@@ -94,7 +94,7 @@ static int jz4740_rtc_wait_write_ready(struct jz4740_rtc *rtc)
 static inline int jz4780_rtc_enable_write(struct jz4740_rtc *rtc)
 {
 	uint32_t ctrl;
-	int ret, timeout = 1000;
+	int ret, timeout = 10000;
 
 	ret = jz4740_rtc_wait_write_ready(rtc);
 	if (ret != 0)
Signature · 1 line
2.11.0
Applied
#1 lore raw
Quoted 8 lines · Mathieu Malaterre

The current timeout for waiting for WRDY is not always sufficient. Always increase it to 10000 even on JZ4740. This is technically only required on JZ4780, where the current symptoms seen after a hard reboot are:

jz4740-rtc 10003000.rtc: rtc core: registered 10003000.rtc as rtc0 jz4740-rtc 10003000.rtc: Could not write to RTC registers
jz4740-rtc: probe of 10003000.rtc failed with error -5

Quoted 7 lines
Suggested-by Alex Smith <[email protected]>
Cc Zubair Lutfullah Kakakhel <[email protected]>
Signed-off-by Mathieu Malaterre <[email protected]>
---
 drivers/rtc/rtc-jz4740.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

Signature · 3 lines
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com