block/ndb: add WQ_UNBOUND to the knbd-recv workqueue

PATCH Superseded Dan Melnic 2 participants 2 messages Sep 18, 2017

Subsystems (2)

Block layer Network block device (NBD)

lore

Share & tools

lore

Dan Melnic

author

2017-09-18 19:58 UTC #0 lore raw

PATCH v2 1/1 block/ndb: add WQ_UNBOUND to the knbd-recv workqueue

Add WQ_UNBOUND to the knbd-recv workqueue so we're not bound to a single CPU that is selected at device creation time.

Signed-off-by Dan Melnic <[email protected]>

---
 drivers/block/nbd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/block/nbd.c +3 -1

index 2aa87cb..ac3c5ecc 100644
@@ -2080,7 +2080,9 @@ static int __init nbd_init(void)
 	if (nbds_max > 1UL << (MINORBITS - part_shift))
 		return -EINVAL;
 	recv_workqueue = alloc_workqueue("knbd-recv",
-					 WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);
+					 WQ_MEM_RECLAIM | WQ_HIGHPRI |
+					 WQ_UNBOUND,
+					 0);
 	if (!recv_workqueue)
 		return -ENOMEM;

Signature · 1 line

2.9.5

Josef Bacik

maintainer Reviewed-by on v2 1/1

2017-09-18 19:58 UTC #1 lore raw

Quoted 13 lines · Dan Melnic

Add WQ_UNBOUND to the knbd-recv workqueue so we're not bound to a single CPU that is selected at device creation time.
Signed-off-by Dan Melnic <[email protected]>
---
 drivers/block/nbd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/block/nbd.c +0 -0
index 2aa87cb..ac3c5ecc 100644

drivers/block/nbd.c static int __init nbd_init(void) · line 2085

Quoted 7 lines

drivers/block/nbd.c +3 -1

@@ -2080,7 +2080,9 @@ static int __init nbd_init(void)
 	if (nbds_max > 1UL << (MINORBITS - part_shift))
 		return -EINVAL;
 	recv_workqueue = alloc_workqueue("knbd-recv",
-					 WQ_MEM_RECLAIM | WQ_HIGHPRI, 0);
+					 WQ_MEM_RECLAIM | WQ_HIGHPRI |
+					 WQ_UNBOUND,
+					 0);

This can go on the line above. You can add

Reviewed-by Josef Bacik <[email protected]>

once you've made that adjustment. Thanks,

Josef