Skip to contentSkip to conversation

x86/setup: Clarify a comment

PATCH In review Jean Delvare 2 participants 2 messages Sep 19, 2017 – Sep 28, 2017 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/setup: Clarify a comment

It's not obvious to everybody that BP stands for boot processor. At least it was not for me.

---
 arch/x86/kernel/setup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kernel/setup.c +1 -1
@@ -1045,7 +1045,7 @@ void __init setup_arch(char **cmdline_p)
 
 	/*
 	 * VMware detection requires dmi to be available, so this
-	 * needs to be done after dmi_scan_machine, for the BP.
+	 * needs to be done after dmi_scan_machine, for the boot processor.
 	 */
 	init_hypervisor_platform();
 
Signature · 2 lines
Jean Delvare
SUSE L3 Support
#1 lore raw
Quoted 12 lines · Jean Delvare

It's not obvious to everybody that BP stands for boot processor. At least it was not for me.

---
 arch/x86/kernel/setup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/x86/kernel/setup.c void __init setup_arch(char **cmdline_p) · line 1050

Quoted 7 lines
arch/x86/kernel/setup.c +1 -1
@@ -1045,7 +1045,7 @@ void __init setup_arch(char **cmdline_p)
 
 	/*
 	 * VMware detection requires dmi to be available, so this
-	 * needs to be done after dmi_scan_machine, for the BP.
+	 * needs to be done after dmi_scan_machine, for the boot processor.
 	 */
 	init_hypervisor_platform();

Ok, I agree with this change - but there's a couple of other references to 'BP' in the x86 code, if then we should change all of them over to 'boot CPU'.

Also, while at it, please change 'dmi_scan_machine' to 'dmi_scan_machine()', which is the canonical way to refer to function calls.

Thanks,

Ingo