hwmon: (stts751) Fix buffer size passed to snprintf
Quoted 6 lines · Jean Delvare
Function snprintf already cares for the terminating NUL at the end of the string, the caller doesn't need to do it.
Signed-off-by Jean Delvare <[email protected]>Cc Andrea Merello <[email protected]>Cc Guenter Roeck <[email protected]>
Applied.
Thanks,
Guenter
Quoted 96 lines
--- drivers/hwmon/stts751.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)drivers/hwmon/stts751.c +9
-9@@ -396,7 +396,7 @@ static ssize_t show_max_alarm(struct devif (ret <0 )return ret; -return snprintf (buf,PAGE_SIZE -1 ,"%d\n" , priv->max_alert); +return snprintf (buf,PAGE_SIZE ,"%d\n" , priv->max_alert); } static ssize_t show_min_alarm(struct device *dev, struct device_attribute *attr,@@ -413,7 +413,7 @@ static ssize_t show_min_alarm(struct devif (ret <0 )return ret; -return snprintf (buf,PAGE_SIZE -1 ,"%d\n" , priv->min_alert); +return snprintf (buf,PAGE_SIZE ,"%d\n" , priv->min_alert); } static ssize_t show_input(struct device *dev, struct device_attribute *attr,@@ -428,7 +428,7 @@ static ssize_t show_input(struct deviceif (ret <0 )return ret; -return snprintf (buf,PAGE_SIZE -1 ,"%d\n" , priv->temp); +return snprintf (buf,PAGE_SIZE ,"%d\n" , priv->temp); } static ssize_t show_therm(struct device *dev, struct device_attribute *attr,@@ -436,7 +436,7 @@ static ssize_t show_therm(struct device {struct stts751_priv *priv =dev_get_drvdata (dev); -return snprintf (buf,PAGE_SIZE -1 ,"%d\n" , priv->therm); +return snprintf (buf,PAGE_SIZE ,"%d\n" , priv->therm); } static ssize_t set_therm(struct device *dev, struct device_attribute *attr,@@ -478,7 +478,7 @@ static ssize_t show_hyst(struct device * {struct stts751_priv *priv =dev_get_drvdata (dev); -return snprintf (buf,PAGE_SIZE -1 ,"%d\n" , priv->hyst); +return snprintf (buf,PAGE_SIZE ,"%d\n" , priv->hyst); } static ssize_t set_hyst(struct device *dev, struct device_attribute *attr,@@ -518,7 +518,7 @@ static ssize_t show_therm_trip(struct deif (ret <0 )return ret; -return snprintf (buf,PAGE_SIZE -1 ,"%d\n" , priv->therm_trip); +return snprintf (buf,PAGE_SIZE ,"%d\n" , priv->therm_trip); } static ssize_t show_max(struct device *dev, struct device_attribute *attr,@@ -526,7 +526,7 @@ static ssize_t show_max(struct device *d {struct stts751_priv *priv =dev_get_drvdata (dev); -return snprintf (buf,PAGE_SIZE -1 ,"%d\n" , priv->event_max); +return snprintf (buf,PAGE_SIZE ,"%d\n" , priv->event_max); } static ssize_t set_max(struct device *dev, struct device_attribute *attr,@@ -560,7 +560,7 @@ static ssize_t show_min(struct device *d {struct stts751_priv *priv =dev_get_drvdata (dev); -return snprintf (buf,PAGE_SIZE -1 ,"%d\n" , priv->event_min); +return snprintf (buf,PAGE_SIZE ,"%d\n" , priv->event_min); } static ssize_t set_min(struct device *dev, struct device_attribute *attr,@@ -594,7 +594,7 @@ static ssize_t show_interval(struct devi {struct stts751_priv *priv =dev_get_drvdata (dev); -return snprintf (buf,PAGE_SIZE -1 ,"%d\n" , +return snprintf (buf,PAGE_SIZE ,"%d\n" , stts751_intervals[priv->interval]); }Signature · 7 lines
-- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html