qt: Allow enabling of QtWebKit with GCC 6+
PATCH 1/1 qt: Allow enabling of QtWebKit with GCC 6+
Building Qt with QtWebKit on configuration step there is a check which disables QtWebKit build with GCC 6+. Back in the day nobody thought about building Qt with GCC version greater than 5.x. And now with modern GCCs like 6.x and 7.x this assumption gets in the way.
Given in Buildroot today we don't have GCC older than 4.9 it should be safe to remove now meaningless check completely.
--- configure | 14 -------------- 1 file changed, 14 deletions(-)
configure +0 -14
@@ -7731,20 +7731,6 @@ case "$XPLATFORM" in canBuildWebKit="no" canBuildQtXmlPatterns="no" ;; - *-g++*) - # Check gcc's version - case "$(${QMAKE_CONF_COMPILER} -dumpversion)" in - 5*|4*|3.4*) - ;; - 3.3*) - canBuildWebKit="no" - ;; - *) - canBuildWebKit="no" - canBuildQtXmlPatterns="no" - ;; - esac - ;; solaris-cc*) # Check the compiler version case `${QMAKE_CONF_COMPILER} -V 2>&1 | awk '{print $4}'` in
Signature · 1 line
2.11.0
PATCH 1/1 qt: Allow enabling of QtWebKit with GCC 6+
Hello,
Quoted 9 lines · Evgeniy Didin
Building Qt with QtWebKit on configuration step there is a check which disables QtWebKit build with GCC 6+. Back in the day nobody thought about building Qt with GCC version greater than 5.x. And now with modern GCCs like 6.x and 7.x this assumption gets in the way.
Given in Buildroot today we don't have GCC older than 4.9 it should be safe to remove now meaningless check completely.
Quoted 7 lines
Signed-off-by Evgeniy Didin <[email protected]>Cc Alexey Brodkin <[email protected]>Cc Thomas Petazzoni <[email protected]>--- configure | 14 -------------- 1 file changed, 14 deletions(-)
I am not sure what you expect us to do with this patch: indeed it is not a Buildroot patch as Buildroot does not have a configure script.
Perhaps you wanted instead to do a patch that adds a patch in package/qt/ instead ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 qt: Allow enabling of QtWebKit with GCC 6+
In reply to Evgeniy DidinHi Evgeniy,
In addition to Thomas's comment:
Quoted 8 lines · Evgeniy Didin
Building Qt with QtWebKit on configuration step there is a check which disables QtWebKit build with GCC 6+. Back in the day nobody thought about building Qt with GCC version greater than 5.x. And now with modern GCCs like 6.x and 7.x this assumption gets in the way.
Given in Buildroot today we don't have GCC older than 4.9 it should be safe to remove now meaningless check completely.
We actually support GCC down to 4.3 in external toolchains. But the check is
only for 3.3 or older, so still OK.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF