Android: move libraries to /vendor
PATCH 1/1 Android: move libraries to /vendor
As part of Treble project in Android O, all the device specific files have to be located in a separate vendor partition. This is done by setting LOCAL_PROPRIETARY_MODULE (the name is misleading). This change will not break existing platforms without a vendor partition as it will just move files to /system/vendor.
--- Android.mk | 1 + amdgpu/Android.mk | 3 ++- data/Android.mk | 3 ++- etnaviv/Android.mk | 1 + freedreno/Android.mk | 1 + intel/Android.mk | 1 + nouveau/Android.mk | 1 + radeon/Android.mk | 1 + tests/modetest/Android.mk | 1 + tests/proptest/Android.mk | 1 + 10 files changed, 12 insertions(+), 2 deletions(-)
Android.mk +1 -0
@@ -49,6 +49,7 @@ include $(BUILD_STATIC_LIBRARY) # Shared library for the device include $(CLEAR_VARS) LOCAL_MODULE := libdrm +LOCAL_PROPRIETARY_MODULE := true LOCAL_SRC_FILES := $(LIBDRM_FILES) LOCAL_EXPORT_C_INCLUDE_DIRS := \
amdgpu/Android.mk +2 -1
@@ -5,13 +5,14 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_amdgpu +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrm LOCAL_SRC_FILES := $(LIBDRM_AMDGPU_FILES) LOCAL_CFLAGS := \ - -DAMDGPU_ASIC_ID_TABLE=\"/system/etc/hwdata/amdgpu.ids\" \ + -DAMDGPU_ASIC_ID_TABLE=\"/vendor/etc/hwdata/amdgpu.ids\" \ -DAMDGPU_ASIC_ID_TABLE_NUM_ENTRIES=$(shell egrep -ci '^[0-9a-f]{4},.*[0-9a-f]+,' $(LIBDRM_TOP)/data/amdgpu.ids) LOCAL_REQUIRED_MODULES := amdgpu.ids
data/Android.mk +2 -1
@@ -4,6 +4,7 @@ include $(CLEAR_VARS) LOCAL_MODULE := amdgpu.ids LOCAL_MODULE_TAGS := optional LOCAL_MODULE_CLASS := ETC -LOCAL_MODULE_PATH := $(TARGET_OUT_ETC)/hwdata +LOCAL_PROPRIETARY_MODULE := true +LOCAL_MODULE_RELATIVE_PATH := hwdata LOCAL_SRC_FILES := $(LOCAL_MODULE) include $(BUILD_PREBUILT)
etnaviv/Android.mk +1 -0
@@ -5,6 +5,7 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_etnaviv +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrm
freedreno/Android.mk +1 -0
@@ -5,6 +5,7 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_freedreno +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrm
intel/Android.mk +1 -0
@@ -28,6 +28,7 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_intel +LOCAL_PROPRIETARY_MODULE := true LOCAL_SRC_FILES := $(LIBDRM_INTEL_FILES)
nouveau/Android.mk +1 -0
@@ -5,6 +5,7 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_nouveau +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrm
radeon/Android.mk +1 -0
@@ -5,6 +5,7 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_radeon +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrm
tests/modetest/Android.mk +1 -0
@@ -6,6 +6,7 @@ include $(LOCAL_PATH)/Makefile.sources LOCAL_SRC_FILES := $(MODETEST_FILES) LOCAL_MODULE := modetest +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrm LOCAL_STATIC_LIBRARIES := libdrm_util
tests/proptest/Android.mk +1 -0
@@ -6,6 +6,7 @@ include $(LOCAL_PATH)/Makefile.sources LOCAL_SRC_FILES := $(PROPTEST_FILES) LOCAL_MODULE := proptest +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrm LOCAL_STATIC_LIBRARIES := libdrm_util
Signature · 6 lines
2.11.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 7 lines · Rob Herring
As part of Treble project in Android O, all the device specific files have to be located in a separate vendor partition. This is done by setting
LOCAL_PROPRIETARY_MODULE(the name is misleading). This change will not break existing platforms without a vendor partition as it will just move files to /system/vendor.Signed-off-by Rob Herring <[email protected]>
Quoted 149 lines
--- Android.mk | 1 + amdgpu/Android.mk | 3 ++- data/Android.mk | 3 ++- etnaviv/Android.mk | 1 + freedreno/Android.mk | 1 + intel/Android.mk | 1 + nouveau/Android.mk | 1 + radeon/Android.mk | 1 + tests/modetest/Android.mk | 1 + tests/proptest/Android.mk | 1 + 10 files changed, 12 insertions(+), 2 deletions(-)Android.mk +1
-0@@ -49,6 +49,7 @@ include $(BUILD_STATIC_LIBRARY) # Shared library for the device include $(CLEAR_VARS) LOCAL_MODULE := libdrm +LOCAL_PROPRIETARY_MODULE := true LOCAL_SRC_FILES := $(LIBDRM_FILES) LOCAL_EXPORT_C_INCLUDE_DIRS := \amdgpu/Android.mk +2
-1@@ -5,13 +5,14 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_amdgpu +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrm LOCAL_SRC_FILES := $(LIBDRM_AMDGPU_FILES) LOCAL_CFLAGS := \ - -DAMDGPU_ASIC_ID_TABLE=\"/system/etc/hwdata/amdgpu.ids\" \ + -DAMDGPU_ASIC_ID_TABLE=\"/vendor/etc/hwdata/amdgpu.ids\" \ -DAMDGPU_ASIC_ID_TABLE_NUM_ENTRIES=$(shell egrep -ci '^[0-9a-f]{4},.*[0-9a-f]+,' $(LIBDRM_TOP)/data/amdgpu.ids) LOCAL_REQUIRED_MODULES := amdgpu.idsdata/Android.mk +2
-1@@ -4,6 +4,7 @@ include $(CLEAR_VARS) LOCAL_MODULE := amdgpu.ids LOCAL_MODULE_TAGS := optional LOCAL_MODULE_CLASS := ETC -LOCAL_MODULE_PATH := $(TARGET_OUT_ETC)/hwdata +LOCAL_PROPRIETARY_MODULE := true +LOCAL_MODULE_RELATIVE_PATH := hwdata LOCAL_SRC_FILES := $(LOCAL_MODULE) include $(BUILD_PREBUILT)etnaviv/Android.mk +1
-0@@ -5,6 +5,7 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_etnaviv +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrmfreedreno/Android.mk +1
-0@@ -5,6 +5,7 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_freedreno +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrmintel/Android.mk +1
-0@@ -28,6 +28,7 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_intel +LOCAL_PROPRIETARY_MODULE := true LOCAL_SRC_FILES := $(LIBDRM_INTEL_FILES)nouveau/Android.mk +1
-0@@ -5,6 +5,7 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_nouveau +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrmradeon/Android.mk +1
-0@@ -5,6 +5,7 @@ include $(CLEAR_VARS) include $(LOCAL_PATH)/Makefile.sources LOCAL_MODULE := libdrm_radeon +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrmtests/modetest/Android.mk +1
-0@@ -6,6 +6,7 @@ include $(LOCAL_PATH)/Makefile.sources LOCAL_SRC_FILES := $(MODETEST_FILES) LOCAL_MODULE := modetest +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrm LOCAL_STATIC_LIBRARIES := libdrm_utiltests/proptest/Android.mk +1
-0@@ -6,6 +6,7 @@ include $(LOCAL_PATH)/Makefile.sources LOCAL_SRC_FILES := $(PROPTEST_FILES) LOCAL_MODULE := proptest +LOCAL_PROPRIETARY_MODULE := true LOCAL_SHARED_LIBRARIES := libdrm LOCAL_STATIC_LIBRARIES := libdrm_utilSignature · 6 lines
2.11.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 5 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 3 lines · Rob Herring
As part of Treble project in Android O, all the device specific files have to be located in a separate vendor partition. This is done by setting
LOCAL_PROPRIETARY_MODULE(the name is misleading).
Just to double-check; this:
Quoted 3 lines
This change will not
break existing platforms without a vendor partition as it will just move files to /system/vendor.
also applies to this, right?
amdgpu/Android.mk include $(CLEAR_VARS) · line 15
Quoted 2 lines
amdgpu/Android.mk +1
-1- -DAMDGPU_ASIC_ID_TABLE=\"/system/etc/hwdata/amdgpu.ids\" \ + -DAMDGPU_ASIC_ID_TABLE=\"/vendor/etc/hwdata/amdgpu.ids\" \
I guess this means /vendor/ used to be a symlink to /system/vendor/ on older Android versions?
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 11 lines · Eric Engestrom
Quoted 3 lines · Rob Herring
As part of Treble project in Android O, all the device specific files have to be located in a separate vendor partition. This is done by setting
LOCAL_PROPRIETARY_MODULE(the name is misleading).Just to double-check; this:
Quoted 3 lines
This change will not
break existing platforms without a vendor partition as it will just move files to /system/vendor.
Quoted 7 lines
also applies to this, right?
amdgpu/Android.mk include $(CLEAR_VARS) · line 15
Quoted 2 lines
amdgpu/Android.mk +1
-1- -DAMDGPU_ASIC_ID_TABLE=\"/system/etc/hwdata/amdgpu.ids\" \ + -DAMDGPU_ASIC_ID_TABLE=\"/vendor/etc/hwdata/amdgpu.ids\" \I guess this means /vendor/ used to be a symlink to /system/vendor/ on older Android versions?
Correct. It's been that way for quite a while and still is in O if you don't enable a vendor partition.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel