Skip to contentSkip to conversation

arm: npcm: add basic support for Nuvoton BMCs

PATCH Superseded Brendan Higgins 4 participants 8 messages Sep 19, 2017 – Nov 2, 2017

Subsystems (5)

v6 of 11 Superseded Latest is v11 →

lore
Share & tools
lore
#0 lore raw

v6 cover arm: npcm: add basic support for Nuvoton BMCs

Addressed comments from:
- Rob: https://www.spinics.net/lists/arm-kernel/msg606616.html

Changes since previous update:
- Addressed some device tree issues pointed out by Rob.
- No changes to mach-npcm since v5
- No changes to MAINTAINERS since v5

Changes have been tested on the NPCM750 evaluation board.

#1 lore raw

PATCH v6 1/3 arm: npcm: add basic support for Nuvoton BMCs

Adds basic support for the Nuvoton NPCM750 BMC.

---
 arch/arm/Kconfig             |  2 +
 arch/arm/Makefile            |  1 +
 arch/arm/mach-npcm/Kconfig   | 48 ++++++++++++++++++++++++
 arch/arm/mach-npcm/Makefile  |  3 ++
 arch/arm/mach-npcm/headsmp.S | 17 +++++++++
 arch/arm/mach-npcm/npcm7xx.c | 34 +++++++++++++++++
 arch/arm/mach-npcm/platsmp.c | 88 ++++++++++++++++++++++++++++++++++++++++++++
 7 files changed, 193 insertions(+)
 create mode 100644 arch/arm/mach-npcm/Kconfig
 create mode 100644 arch/arm/mach-npcm/Makefile
 create mode 100644 arch/arm/mach-npcm/headsmp.S
 create mode 100644 arch/arm/mach-npcm/npcm7xx.c
 create mode 100644 arch/arm/mach-npcm/platsmp.c
arch/arm/Kconfig +2 -0
index 61a0cb15067e..05543f1cfbde 100644
@@ -782,6 +782,8 @@ source "arch/arm/mach-netx/Kconfig"
 
 source "arch/arm/mach-nomadik/Kconfig"
 
+source "arch/arm/mach-npcm/Kconfig"
+
 source "arch/arm/mach-nspire/Kconfig"
 
 source "arch/arm/plat-omap/Kconfig"
arch/arm/Makefile +1 -0
index 47d3a1ab08d2..60ca50c7d762 100644
@@ -191,6 +191,7 @@ machine-$(CONFIG_ARCH_MEDIATEK)		+= mediatek
 machine-$(CONFIG_ARCH_MXS)		+= mxs
 machine-$(CONFIG_ARCH_NETX)		+= netx
 machine-$(CONFIG_ARCH_NOMADIK)		+= nomadik
+machine-$(CONFIG_ARCH_NPCM)		+= npcm
 machine-$(CONFIG_ARCH_NSPIRE)		+= nspire
 machine-$(CONFIG_ARCH_OXNAS)		+= oxnas
 machine-$(CONFIG_ARCH_OMAP1)		+= omap1
arch/arm/mach-npcm/Kconfig new file +48 -0

48 lines not on this page · raw message

arch/arm/mach-npcm/Makefile new file +3 -0
new file mode 100644
index 000000000000..78416055b854
@@ -0,0 +1,3 @@
+AFLAGS_headsmp.o		+= -march=armv7-a
+
+obj-$(CONFIG_CPU_NPCM750)	+= npcm7xx.o platsmp.o headsmp.o
arch/arm/mach-npcm/headsmp.S new file +17 -0
new file mode 100644
index 000000000000..9fccbbd49ed4
@@ -0,0 +1,17 @@
+/*
+ * Copyright 2017 Google, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/linkage.h>
+#include <linux/init.h>
+#include <asm/assembler.h>
+
+ENTRY(npcm7xx_secondary_startup)
+	safe_svcmode_maskall r0
+
+	b	secondary_startup
+ENDPROC(npcm7xx_secondary_startup)
arch/arm/mach-npcm/npcm7xx.c new file +34 -0
new file mode 100644
index 000000000000..132e9d587857
@@ -0,0 +1,34 @@
+/*
+ * Copyright (c) 2017 Nuvoton Technology corporation.
+ * Copyright 2017 Google, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/kernel.h>
+#include <linux/types.h>
+#include <asm/mach/arch.h>
+#include <asm/mach-types.h>
+#include <asm/mach/map.h>
+#include <asm/hardware/cache-l2x0.h>
+
+#define NPCM7XX_AUX_VAL (L310_AUX_CTRL_INSTR_PREFETCH |			       \
+			 L310_AUX_CTRL_DATA_PREFETCH |			       \
+			 L310_AUX_CTRL_NS_LOCKDOWN |			       \
+			 L310_AUX_CTRL_CACHE_REPLACE_RR |		       \
+			 L2C_AUX_CTRL_SHARED_OVERRIDE |			       \
+			 L310_AUX_CTRL_FULL_LINE_ZERO)
+
+static const char *const npcm7xx_dt_match[] = {
+	"nuvoton,npcm750",
+	NULL
+};
+
+DT_MACHINE_START(NPCM7XX_DT, "NPCMX50 Chip family")
+	.atag_offset	= 0x100,
+	.dt_compat	= npcm7xx_dt_match,
+	.l2c_aux_val	= NPCM7XX_AUX_VAL,
+	.l2c_aux_mask	= ~NPCM7XX_AUX_VAL,
+MACHINE_END
arch/arm/mach-npcm/platsmp.c new file +88 -0

88 lines not on this page · raw message

Signature · 1 line
2.14.1.690.gbb1197296e-goog
#2 lore raw

PATCH v6 2/3 arm: dts: add Nuvoton NPCM750 device tree

In reply to Brendan Higgins

Add a common device tree for all Nuvoton NPCM750 BMCs and a board specific device tree for the NPCM750 (Poleg) evaluation board.

---
 .../arm/cpu-enable-method/nuvoton,npcm7xx-smp      |  42 ++++
 .../devicetree/bindings/arm/npcm/npcm.txt          |   6 +
 arch/arm/boot/dts/nuvoton-npcm750-evb.dts          |  48 +++++
 arch/arm/boot/dts/nuvoton-npcm750.dtsi             | 211 +++++++++++++++++++++
 include/dt-bindings/clock/nuvoton,npcm7xx-clks.h   |  39 ++++
 5 files changed, 346 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/cpu-enable-method/nuvoton,npcm7xx-smp
 create mode 100644 Documentation/devicetree/bindings/arm/npcm/npcm.txt
 create mode 100644 arch/arm/boot/dts/nuvoton-npcm750-evb.dts
 create mode 100644 arch/arm/boot/dts/nuvoton-npcm750.dtsi
 create mode 100644 include/dt-bindings/clock/nuvoton,npcm7xx-clks.h
Documentation/devicetree/bindings/arm/cpu-enable-method/nuvoton,npcm7xx-smp new file +42 -0
new file mode 100644
index 000000000000..e81f85b400cf
@@ -0,0 +1,42 @@
+=========================================================
+Secondary CPU enable-method "nuvoton,npcm7xx-smp" binding
+=========================================================
+
+To apply to all CPUs, a single "nuvoton,npcm7xx-smp" enable method should be
+defined in the "cpus" node.
+
+Enable method name:	"nuvoton,npcm7xx-smp"
+Compatible machines:	"nuvoton,npcm750"
+Compatible CPUs:	"arm,cortex-a9"
+Related properties:	(none)
+
+Note:
+This enable method needs valid nodes compatible with "arm,cortex-a9-scu" and
+"nuvoton,npcm750-gcr".
+
+Example:
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		enable-method = "nuvoton,npcm7xx-smp";
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			clocks = <&clk NPCM7XX_CLK_CPU>;
+			clock-names = "clk_cpu";
+			reg = <0>;
+			next-level-cache = <&L2>;
+		};
+
+		cpu at 1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			clocks = <&clk NPCM7XX_CLK_CPU>;
+			clock-names = "clk_cpu";
+			reg = <1>;
+			next-level-cache = <&L2>;
+		};
+	};
+
Documentation/devicetree/bindings/arm/npcm/npcm.txt new file +6 -0
new file mode 100644
index 000000000000..2d87d9ecea85
@@ -0,0 +1,6 @@
+NPCM Platforms Device Tree Bindings
+-----------------------------------
+NPCM750 SoC
+Required root node properties:
+	- compatible = "nuvoton,npcm750";
+
arch/arm/boot/dts/nuvoton-npcm750-evb.dts new file +48 -0

48 lines not on this page · raw message

arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +211 -0

211 lines not on this page · raw message

include/dt-bindings/clock/nuvoton,npcm7xx-clks.h new file +39 -0
new file mode 100644
index 000000000000..c69d3bbf7e42
@@ -0,0 +1,39 @@
+/*
+ * Copyright (C) 2016 Nuvoton Technologies,  tali.perry at nuvoton.com
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ */
+
+#ifndef _DT_BINDINGS_CLK_NPCM7XX_H
+#define _DT_BINDINGS_CLK_NPCM7XX_H
+
+#define NPCM7XX_CLK_PLL0	0
+#define NPCM7XX_CLK_PLL1	1
+#define NPCM7XX_CLK_PLL2	2
+#define NPCM7XX_CLK_GFX		3
+#define NPCM7XX_CLK_APB1	4
+#define NPCM7XX_CLK_APB2	5
+#define NPCM7XX_CLK_APB3	6
+#define NPCM7XX_CLK_APB4	7
+#define NPCM7XX_CLK_APB5	8
+#define NPCM7XX_CLK_MC		9
+#define NPCM7XX_CLK_CPU		10
+#define NPCM7XX_CLK_SPI0	11
+#define NPCM7XX_CLK_SPI3	12
+#define NPCM7XX_CLK_SPIX	13
+#define NPCM7XX_CLK_UART_CORE	14
+#define NPCM7XX_CLK_TIMER	15
+#define NPCM7XX_CLK_HOST_UART	16
+#define NPCM7XX_CLK_MMC		17
+#define NPCM7XX_CLK_SDHC	18
+#define NPCM7XX_CLK_ADC		19
+#define NPCM7XX_CLK_GFX_MEM	20
+#define NPCM7XX_CLK_USB_BRIDGE	21
+#define NPCM7XX_CLK_AXI		22
+#define NPCM7XX_CLK_AHB		23
+#define NPCM7XX_CLK_EMC		24
+#define NPCM7XX_CLK_GMAC	25
+
+#endif
Signature · 1 line
2.14.1.690.gbb1197296e-goog
maintainer
#3 lore raw

Re: [PATCH v6 2/3] arm: dts: add Nuvoton NPCM750 device tree

Quoted 212 lines · Brendan Higgins

Add a common device tree for all Nuvoton NPCM750 BMCs and a board specific device tree for the NPCM750 (Poleg) evaluation board.

---
 .../arm/cpu-enable-method/nuvoton,npcm7xx-smp      |  42 ++++
 .../devicetree/bindings/arm/npcm/npcm.txt          |   6 +
 arch/arm/boot/dts/nuvoton-npcm750-evb.dts          |  48 +++++
 arch/arm/boot/dts/nuvoton-npcm750.dtsi             | 211 +++++++++++++++++++++
 include/dt-bindings/clock/nuvoton,npcm7xx-clks.h   |  39 ++++
 5 files changed, 346 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/cpu-enable-method/nuvoton,npcm7xx-smp
 create mode 100644 Documentation/devicetree/bindings/arm/npcm/npcm.txt
 create mode 100644 arch/arm/boot/dts/nuvoton-npcm750-evb.dts
 create mode 100644 arch/arm/boot/dts/nuvoton-npcm750.dtsi
 create mode 100644 include/dt-bindings/clock/nuvoton,npcm7xx-clks.h
Documentation/devicetree/bindings/arm/cpu-enable-method/nuvoton,npcm7xx-smp new file +42 -0
new file mode 100644
index 000000000000..e81f85b400cf
@@ -0,0 +1,42 @@
+=========================================================
+Secondary CPU enable-method "nuvoton,npcm7xx-smp" binding
+=========================================================
+
+To apply to all CPUs, a single "nuvoton,npcm7xx-smp" enable method should be
+defined in the "cpus" node.
+
+Enable method name:	"nuvoton,npcm7xx-smp"
+Compatible machines:	"nuvoton,npcm750"
+Compatible CPUs:	"arm,cortex-a9"
+Related properties:	(none)
+
+Note:
+This enable method needs valid nodes compatible with "arm,cortex-a9-scu" and
+"nuvoton,npcm750-gcr".
+
+Example:
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		enable-method = "nuvoton,npcm7xx-smp";
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			clocks = <&clk NPCM7XX_CLK_CPU>;
+			clock-names = "clk_cpu";
+			reg = <0>;
+			next-level-cache = <&L2>;
+		};
+
+		cpu at 1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			clocks = <&clk NPCM7XX_CLK_CPU>;
+			clock-names = "clk_cpu";
+			reg = <1>;
+			next-level-cache = <&L2>;
+		};
+	};
+
Documentation/devicetree/bindings/arm/npcm/npcm.txt new file +6 -0
new file mode 100644
index 000000000000..2d87d9ecea85
@@ -0,0 +1,6 @@
+NPCM Platforms Device Tree Bindings
+-----------------------------------
+NPCM750 SoC
+Required root node properties:
+	- compatible = "nuvoton,npcm750";
+
arch/arm/boot/dts/nuvoton-npcm750-evb.dts new file +48 -0
new file mode 100644
index 000000000000..a0675e584125
@@ -0,0 +1,48 @@
+/*
+ * DTS file for all NPCM750 SoCs
+ *
+ * Copyright 2012 Tomer Maimon <[email protected]>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "nuvoton-npcm750.dtsi"
+
+/ {
+	model = "Nuvoton npcm750 Development Board (Device Tree)";
+	compatible = "nuvoton,npcm750";
+
+	chosen {
+		stdout-path = &serial3;
+	};
+
+	memory {
+		reg = <0 0x40000000>;
+	};
+};
+
+&watchdog1 {
+	status = "okay";
+};
+
+&serial0 {
+	status = "okay";
+};
+
+&serial1 {
+	status = "okay";
+};
+
+&serial2 {
+	status = "okay";
+};
+
+&serial3 {
+	status = "okay";
+};
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +69 -0
new file mode 100644
index 000000000000..5d8a48e44274
@@ -0,0 +1,211 @@
+/*
+ * DTSi file for the NPCM750 SoC
+ *
+ * Copyright 2012 Tomer Maimon <[email protected]>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/clock/nuvoton,npcm7xx-clks.h>
+
+/ {
+	#address-cells = <1>;
+	#size-cells = <1>;
+	interrupt-parent = <&gic>;
+
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+		enable-method = "nuvoton,npcm7xx-smp";
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			clocks = <&clk NPCM7XX_CLK_CPU>;
+			clock-names = "clk_cpu";
+			reg = <0>;
+			next-level-cache = <&l2>;
+		};
+
+		cpu at 1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			clocks = <&clk NPCM7XX_CLK_CPU>;
+			clock-names = "clk_cpu";
+			reg = <1>;
+			next-level-cache = <&l2>;
+		};
+	};
+
 
+	gcr: gcr at f0800000 {
+		compatible = "nuvoton,npcm750-gcr", "syscon",
+			"simple-mfd";
+		reg = <0xf0800000 0x1000>;
+	};
+
+	scu: scu at f03fe000 {
+		compatible = "arm,cortex-a9-scu";
+		reg = <0xf03fe000 0x1000>;
+	};
+
+	l2: cache-controller at f03fc000 {
+		compatible = "arm,pl310-cache";
+		reg = <0xf03fc000 0x1000>;
+		interrupts = <0 21 4>;
+		cache-unified;
+		cache-level = <2>;
+		clocks = <&clk NPCM7XX_CLK_AXI>;
+	};
+
+	gic: interrupt-controller at f03ff000 {
+		compatible = "arm,cortex-a9-gic";
+		interrupt-controller;
+		#interrupt-cells = <3>;

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 79

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +10 -0
+		reg = <0xf03ff000 0x1000>,
+		    <0xf03fe100 0x100>;
+	};
+
+	timer at f03fe600 {
+		compatible = "arm,cortex-a9-twd-timer";
+		reg = <0xf03fe600 0x20>;
+		interrupts = <1 13 0x304>;
+		clocks = <&clk NPCM7XX_CLK_TIMER>;
+	};

All these nodes with a memory mapped address should go under a bus node.

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 91

Quoted 12 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +12 -0
+
+	ahb {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "simple-bus";
+		interrupt-parent = <&gic>;
+		ranges = <0x80000000 0x80000000 0x40000000
+			  0xc0000000 0xc0000000 0x00002000
+			  0xc0008000 0xc0008000 0x00001000
+			  0xe0800000 0xe0800000 0x00001000
+			  0xe1000000 0xe1000000 0x00001000
+			  0xe8000000 0xe8000000 0x08000000

These addresses don't appear to be used. These are coming later? They could be collapsed down into 2 entries.

<0x80000000 0x80000000 0x40010000>
<0xe0800000 0xe0800000 0x0f800000>

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 100

Quoted 9 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +9 -0
+			  /* APB start */
+			  0xf0000000 0xf0000000 0x00005000
+			  0xf0007000 0xf0007000 0x00005000
+			  0xf0010000 0xf0010000 0x00008000
+			  0xf0080000 0xf0080000 0x00010000
+			  0xf009f000 0xf009f000 0x00001000
+			  0xf0100000 0xf0100000 0x00005000
+			  0xf0180000 0xf0180000 0x0000b000
+			  0xf0200000 0xf0200000 0x00002000

Not necessary to be so fine grained and shouldn't just be 1:1. So for these just:

<0 0xf0000000 0x00900000>

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 109

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +9 -0
+			  /* APB end */
+			  0xf0800000 0xf0800000 0x000fc000
+			  0xf8000000 0xf8000000 0x02000000
+			  0xfb000000 0xfb000000 0x00002000>;
 
+
+		clk: clock-controller at f0801000 {
+			compatible = "nuvoton,npcm750-clk";
+			#clock-cells = <1>;
+			reg = <0xf0801000 0x1000>;

Then this becomes: 0x801000 0x1000

Quoted 12 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +12 -0
+			status = "okay";
+		};
+
+		/* external clock signal rg1refck, supplied by the phy */
+		clk-rg1refck {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <125000000>;
+		};
+
+		/* external clock signal rg2refck, supplied by the phy */
+		clk-rg2refck {

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 131

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +10 -0
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <125000000>;
+		};
+
+		clk-xin {
+			compatible = "fixed-clock";
+			#clock-cells = <0>;
+			clock-frequency = <50000000>;
+		};

These clocks are not on the bus, so move them out of the bus node to the top level.

Quoted 4 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +4 -0
+
+		apb {
+			#address-cells = <1>;
+			#size-cells = <1>;

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 145

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +10 -0
+			compatible = "simple-bus";
+			interrupt-parent = <&gic>;
+			ranges = <0xf0000000 0xf0000000 0x00005000
+				  0xf0007000 0xf0007000 0x00005000
+				  0xf0010000 0xf0010000 0x00008000
+				  0xf0080000 0xf0080000 0x00010000
+				  0xf009f000 0xf009f000 0x00001000
+				  0xf0100000 0xf0100000 0x00005000
+				  0xf0180000 0xf0180000 0x0000b000
+				  0xf0200000 0xf0200000 0x00002000>;

With above changes this can be just: <0 0 0x300000>

Quoted 23 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +23 -0
+
+			timer0: timer at f0000000 {
+				compatible = "nuvoton,npcm750-timer";
+				interrupts = <0 32 4>;
+				reg = <0xf0000000 0x1000>;
+				clocks = <&clk NPCM7XX_CLK_TIMER>;
+			};
+
+			watchdog0: watchdog at f0008000 {
+				compatible = "nuvoton,npcm750-wdt";
+				interrupts = <0 47 4>;
+				reg = <0xf0008000 0x1000>;
+				status = "disabled";
+				clocks = <&clk NPCM7XX_CLK_TIMER>;
+			};
+
+			watchdog1: watchdog at f0009000 {
+				compatible = "nuvoton,npcm750-wdt";
+				interrupts = <0 48 4>;
+				reg = <0xf0009000 0x1000>;
+				status = "disabled";
+				clocks = <&clk NPCM7XX_CLK_TIMER>;
+			};

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 178

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +10 -0
+
+			watchdog2: watchdog at f000a000 {
+				compatible = "nuvoton,npcm750-wdt";
+				interrupts = <0 49 4>;
+				reg = <0xf000a000 0x1000>;
+				status = "disabled";
+				clocks = <&clk NPCM7XX_CLK_TIMER>;
+			};
+
+			serial0: serial0 at f0001000 {

Sorry I miss this earlier, but need to drop the 0 in the node names. IOW, should be "serial at f0001000".

Quoted 33 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +33 -0
+				compatible = "nuvoton,npcm750-uart";
+				reg = <0xf0001000 0x1000>;
+				clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+				interrupts = <0 2 4>;
+				status = "disabled";
+			};
+
+			serial1: serial1 at f0002000 {
+				compatible = "nuvoton,npcm750-uart";
+				reg = <0xf0002000 0x1000>;
+				clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+				interrupts = <0 3 4>;
+				status = "disabled";
+			};
+
+			serial2: serial2 at f0003000 {
+				compatible = "nuvoton,npcm750-uart";
+				reg = <0xf0003000 0x1000>;
+				clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+				interrupts = <0 4 4>;
+				status = "disabled";
+			};
+
+			serial3: serial3 at f0004000 {
+				compatible = "nuvoton,npcm750-uart";
+				reg = <0xf0004000 0x1000>;
+				clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+				interrupts = <0 5 4>;
+				status = "disabled";
+			};
+		};
+	};
+};
#4 lore raw

Re: [PATCH v6 2/3] arm: dts: add Nuvoton NPCM750 device tree

Sorry for the delay. A couple questions:

Quoted 239 lines · Rob Herring
Quoted 212 lines · Brendan Higgins

Add a common device tree for all Nuvoton NPCM750 BMCs and a board specific device tree for the NPCM750 (Poleg) evaluation board.

---
 .../arm/cpu-enable-method/nuvoton,npcm7xx-smp      |  42 ++++
 .../devicetree/bindings/arm/npcm/npcm.txt          |   6 +
 arch/arm/boot/dts/nuvoton-npcm750-evb.dts          |  48 +++++
 arch/arm/boot/dts/nuvoton-npcm750.dtsi             | 211 +++++++++++++++++++++
 include/dt-bindings/clock/nuvoton,npcm7xx-clks.h   |  39 ++++
 5 files changed, 346 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/cpu-enable-method/nuvoton,npcm7xx-smp
 create mode 100644 Documentation/devicetree/bindings/arm/npcm/npcm.txt
 create mode 100644 arch/arm/boot/dts/nuvoton-npcm750-evb.dts
 create mode 100644 arch/arm/boot/dts/nuvoton-npcm750.dtsi
 create mode 100644 include/dt-bindings/clock/nuvoton,npcm7xx-clks.h
Documentation/devicetree/bindings/arm/cpu-enable-method/nuvoton,npcm7xx-smp new file +42 -0
new file mode 100644
index 000000000000..e81f85b400cf
@@ -0,0 +1,42 @@
+=========================================================
+Secondary CPU enable-method "nuvoton,npcm7xx-smp" binding
+=========================================================
+
+To apply to all CPUs, a single "nuvoton,npcm7xx-smp" enable method should be
+defined in the "cpus" node.
+
+Enable method name:  "nuvoton,npcm7xx-smp"
+Compatible machines: "nuvoton,npcm750"
+Compatible CPUs:     "arm,cortex-a9"
+Related properties:  (none)
+
+Note:
+This enable method needs valid nodes compatible with "arm,cortex-a9-scu" and
+"nuvoton,npcm750-gcr".
+
+Example:
+
+     cpus {
+             #address-cells = <1>;
+             #size-cells = <0>;
+             enable-method = "nuvoton,npcm7xx-smp";
+
+             cpu at 0 {
+                     device_type = "cpu";
+                     compatible = "arm,cortex-a9";
+                     clocks = <&clk NPCM7XX_CLK_CPU>;
+                     clock-names = "clk_cpu";
+                     reg = <0>;
+                     next-level-cache = <&L2>;
+             };
+
+             cpu at 1 {
+                     device_type = "cpu";
+                     compatible = "arm,cortex-a9";
+                     clocks = <&clk NPCM7XX_CLK_CPU>;
+                     clock-names = "clk_cpu";
+                     reg = <1>;
+                     next-level-cache = <&L2>;
+             };
+     };
+
Documentation/devicetree/bindings/arm/npcm/npcm.txt new file +6 -0
new file mode 100644
index 000000000000..2d87d9ecea85
@@ -0,0 +1,6 @@
+NPCM Platforms Device Tree Bindings
+-----------------------------------
+NPCM750 SoC
+Required root node properties:
+     - compatible = "nuvoton,npcm750";
+
arch/arm/boot/dts/nuvoton-npcm750-evb.dts new file +48 -0
new file mode 100644
index 000000000000..a0675e584125
@@ -0,0 +1,48 @@
+/*
+ * DTS file for all NPCM750 SoCs
+ *
+ * Copyright 2012 Tomer Maimon <[email protected]>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "nuvoton-npcm750.dtsi"
+
+/ {
+     model = "Nuvoton npcm750 Development Board (Device Tree)";
+     compatible = "nuvoton,npcm750";
+
+     chosen {
+             stdout-path = &serial3;
+     };
+
+     memory {
+             reg = <0 0x40000000>;
+     };
+};
+
+&watchdog1 {
+     status = "okay";
+};
+
+&serial0 {
+     status = "okay";
+};
+
+&serial1 {
+     status = "okay";
+};
+
+&serial2 {
+     status = "okay";
+};
+
+&serial3 {
+     status = "okay";
+};
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +69 -0
new file mode 100644
index 000000000000..5d8a48e44274
@@ -0,0 +1,211 @@
+/*
+ * DTSi file for the NPCM750 SoC
+ *
+ * Copyright 2012 Tomer Maimon <[email protected]>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/clock/nuvoton,npcm7xx-clks.h>
+
+/ {
+     #address-cells = <1>;
+     #size-cells = <1>;
+     interrupt-parent = <&gic>;
+
+     cpus {
+             #address-cells = <1>;
+             #size-cells = <0>;
+             enable-method = "nuvoton,npcm7xx-smp";
+
+             cpu at 0 {
+                     device_type = "cpu";
+                     compatible = "arm,cortex-a9";
+                     clocks = <&clk NPCM7XX_CLK_CPU>;
+                     clock-names = "clk_cpu";
+                     reg = <0>;
+                     next-level-cache = <&l2>;
+             };
+
+             cpu at 1 {
+                     device_type = "cpu";
+                     compatible = "arm,cortex-a9";
+                     clocks = <&clk NPCM7XX_CLK_CPU>;
+                     clock-names = "clk_cpu";
+                     reg = <1>;
+                     next-level-cache = <&l2>;
+             };
+     };
+
 
+     gcr: gcr at f0800000 {
+             compatible = "nuvoton,npcm750-gcr", "syscon",
+                     "simple-mfd";
+             reg = <0xf0800000 0x1000>;
+     };
+
+     scu: scu at f03fe000 {
+             compatible = "arm,cortex-a9-scu";
+             reg = <0xf03fe000 0x1000>;
+     };
+
+     l2: cache-controller at f03fc000 {
+             compatible = "arm,pl310-cache";
+             reg = <0xf03fc000 0x1000>;
+             interrupts = <0 21 4>;
+             cache-unified;
+             cache-level = <2>;
+             clocks = <&clk NPCM7XX_CLK_AXI>;
+     };
+
+     gic: interrupt-controller at f03ff000 {
+             compatible = "arm,cortex-a9-gic";
+             interrupt-controller;
+             #interrupt-cells = <3>;

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 79

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +10 -0
+             reg = <0xf03ff000 0x1000>,
+                 <0xf03fe100 0x100>;
+     };
+
+     timer at f03fe600 {
+             compatible = "arm,cortex-a9-twd-timer";
+             reg = <0xf03fe600 0x20>;
+             interrupts = <1 13 0x304>;
+             clocks = <&clk NPCM7XX_CLK_TIMER>;
+     };

All these nodes with a memory mapped address should go under a bus node.

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 91

Quoted 12 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +12 -0
+
+     ahb {
+             #address-cells = <1>;
+             #size-cells = <1>;
+             compatible = "simple-bus";
+             interrupt-parent = <&gic>;
+             ranges = <0x80000000 0x80000000 0x40000000
+                       0xc0000000 0xc0000000 0x00002000
+                       0xc0008000 0xc0008000 0x00001000
+                       0xe0800000 0xe0800000 0x00001000
+                       0xe1000000 0xe1000000 0x00001000
+                       0xe8000000 0xe8000000 0x08000000
Quoted 2 lines

These addresses don't appear to be used. These are coming later? They could be collapsed down into 2 entries.

Yep, the other addresses will be used in later patch sets. This is part of why I did not think that it made sense to do address translation here. I thought that mapping such a large range of addresses would not make it any easier to read, quite the opposite. At least addresses 'mapped' to the original address correspond to the datasheet. So I am guessing that is not what you are asking me to do.

Most of the large mappings (on the orders of MB) correspond to memory locations mapped on either one of the SPI busses or PCIe busses, which when implemented would likely get their own busses under ahb.

Are you asking that I remap just the addresses for controlling SoC devices (0xf0xxxxxx), leave the external busses as is, and then remap those within their busses when we get to that point?

I will try to implement what I think you are asking me to do and get a patch out later today. Hopefully that will make this discussion easier.

Quoted 138 lines

<0x80000000 0x80000000 0x40010000>
<0xe0800000 0xe0800000 0x0f800000>

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 100

Quoted 9 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +9 -0
+                       /* APB start */
+                       0xf0000000 0xf0000000 0x00005000
+                       0xf0007000 0xf0007000 0x00005000
+                       0xf0010000 0xf0010000 0x00008000
+                       0xf0080000 0xf0080000 0x00010000
+                       0xf009f000 0xf009f000 0x00001000
+                       0xf0100000 0xf0100000 0x00005000
+                       0xf0180000 0xf0180000 0x0000b000
+                       0xf0200000 0xf0200000 0x00002000

Not necessary to be so fine grained and shouldn't just be 1:1. So for these just:

<0 0xf0000000 0x00900000>

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 109

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +9 -0
+                       /* APB end */
+                       0xf0800000 0xf0800000 0x000fc000
+                       0xf8000000 0xf8000000 0x02000000
+                       0xfb000000 0xfb000000 0x00002000>;
 
+
+             clk: clock-controller at f0801000 {
+                     compatible = "nuvoton,npcm750-clk";
+                     #clock-cells = <1>;
+                     reg = <0xf0801000 0x1000>;

Then this becomes: 0x801000 0x1000

Quoted 12 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +12 -0
+                     status = "okay";
+             };
+
+             /* external clock signal rg1refck, supplied by the phy */
+             clk-rg1refck {
+                     compatible = "fixed-clock";
+                     #clock-cells = <0>;
+                     clock-frequency = <125000000>;
+             };
+
+             /* external clock signal rg2refck, supplied by the phy */
+             clk-rg2refck {

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 131

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +10 -0
+                     compatible = "fixed-clock";
+                     #clock-cells = <0>;
+                     clock-frequency = <125000000>;
+             };
+
+             clk-xin {
+                     compatible = "fixed-clock";
+                     #clock-cells = <0>;
+                     clock-frequency = <50000000>;
+             };

These clocks are not on the bus, so move them out of the bus node to the top level.

Quoted 4 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +4 -0
+
+             apb {
+                     #address-cells = <1>;
+                     #size-cells = <1>;

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 145

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +10 -0
+                     compatible = "simple-bus";
+                     interrupt-parent = <&gic>;
+                     ranges = <0xf0000000 0xf0000000 0x00005000
+                               0xf0007000 0xf0007000 0x00005000
+                               0xf0010000 0xf0010000 0x00008000
+                               0xf0080000 0xf0080000 0x00010000
+                               0xf009f000 0xf009f000 0x00001000
+                               0xf0100000 0xf0100000 0x00005000
+                               0xf0180000 0xf0180000 0x0000b000
+                               0xf0200000 0xf0200000 0x00002000>;

With above changes this can be just: <0 0 0x300000>

Quoted 23 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +23 -0
+
+                     timer0: timer at f0000000 {
+                             compatible = "nuvoton,npcm750-timer";
+                             interrupts = <0 32 4>;
+                             reg = <0xf0000000 0x1000>;
+                             clocks = <&clk NPCM7XX_CLK_TIMER>;
+                     };
+
+                     watchdog0: watchdog at f0008000 {
+                             compatible = "nuvoton,npcm750-wdt";
+                             interrupts = <0 47 4>;
+                             reg = <0xf0008000 0x1000>;
+                             status = "disabled";
+                             clocks = <&clk NPCM7XX_CLK_TIMER>;
+                     };
+
+                     watchdog1: watchdog at f0009000 {
+                             compatible = "nuvoton,npcm750-wdt";
+                             interrupts = <0 48 4>;
+                             reg = <0xf0009000 0x1000>;
+                             status = "disabled";
+                             clocks = <&clk NPCM7XX_CLK_TIMER>;
+                     };

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 178

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +10 -0
+
+                     watchdog2: watchdog at f000a000 {
+                             compatible = "nuvoton,npcm750-wdt";
+                             interrupts = <0 49 4>;
+                             reg = <0xf000a000 0x1000>;
+                             status = "disabled";
+                             clocks = <&clk NPCM7XX_CLK_TIMER>;
+                     };
+
+                     serial0: serial0 at f0001000 {

Sorry I miss this earlier, but need to drop the 0 in the node names. IOW, should be "serial at f0001000".

Quoted 25 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +25 -0
+                             compatible = "nuvoton,npcm750-uart";
+                             reg = <0xf0001000 0x1000>;
+                             clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+                             interrupts = <0 2 4>;
+                             status = "disabled";
+                     };
+
+                     serial1: serial1 at f0002000 {
+                             compatible = "nuvoton,npcm750-uart";
+                             reg = <0xf0002000 0x1000>;
+                             clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+                             interrupts = <0 3 4>;
+                             status = "disabled";
+                     };
+
+                     serial2: serial2 at f0003000 {
+                             compatible = "nuvoton,npcm750-uart";
+                             reg = <0xf0003000 0x1000>;
+                             clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+                             interrupts = <0 4 4>;
+                             status = "disabled";
+                     };
+
+                     serial3: serial3 at f0004000 {
+                             compatible = "nuvoton,npcm750-uart";
Quoted 8 lines

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 211

Quoted 8 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +8 -0
+                             reg = <0xf0004000 0x1000>;
+                             clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+                             interrupts = <0 5 4>;
+                             status = "disabled";
+                     };
+             };
+     };
+};

Thanks!

maintainer
#5 lore raw

Re: [PATCH v6 2/3] arm: dts: add Nuvoton NPCM750 device tree

In reply to Brendan Higgins
Quoted 284 lines · Brendan Higgins

Add a common device tree for all Nuvoton NPCM750 BMCs and a board specific device tree for the NPCM750 (Poleg) evaluation board.

---
 .../arm/cpu-enable-method/nuvoton,npcm7xx-smp      |  42 ++++
 .../devicetree/bindings/arm/npcm/npcm.txt          |   6 +
 arch/arm/boot/dts/nuvoton-npcm750-evb.dts          |  48 +++++
 arch/arm/boot/dts/nuvoton-npcm750.dtsi             | 211 +++++++++++++++++++++
 include/dt-bindings/clock/nuvoton,npcm7xx-clks.h   |  39 ++++
 5 files changed, 346 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/cpu-enable-method/nuvoton,npcm7xx-smp
 create mode 100644 Documentation/devicetree/bindings/arm/npcm/npcm.txt
 create mode 100644 arch/arm/boot/dts/nuvoton-npcm750-evb.dts
 create mode 100644 arch/arm/boot/dts/nuvoton-npcm750.dtsi
 create mode 100644 include/dt-bindings/clock/nuvoton,npcm7xx-clks.h
Documentation/devicetree/bindings/arm/cpu-enable-method/nuvoton,npcm7xx-smp new file +42 -0
new file mode 100644
index 000000000000..e81f85b400cf
@@ -0,0 +1,42 @@
+=========================================================
+Secondary CPU enable-method "nuvoton,npcm7xx-smp" binding
+=========================================================
+
+To apply to all CPUs, a single "nuvoton,npcm7xx-smp" enable method should be
+defined in the "cpus" node.
+
+Enable method name:    "nuvoton,npcm7xx-smp"
+Compatible machines:   "nuvoton,npcm750"
+Compatible CPUs:       "arm,cortex-a9"
+Related properties:    (none)
+
+Note:
+This enable method needs valid nodes compatible with "arm,cortex-a9-scu" and
+"nuvoton,npcm750-gcr".
+
+Example:
+
+       cpus {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               enable-method = "nuvoton,npcm7xx-smp";
+
+               cpu at 0 {
+                       device_type = "cpu";
+                       compatible = "arm,cortex-a9";
+                       clocks = <&clk NPCM7XX_CLK_CPU>;
+                       clock-names = "clk_cpu";
+                       reg = <0>;
+                       next-level-cache = <&L2>;
+               };
+
+               cpu at 1 {
+                       device_type = "cpu";
+                       compatible = "arm,cortex-a9";
+                       clocks = <&clk NPCM7XX_CLK_CPU>;
+                       clock-names = "clk_cpu";
+                       reg = <1>;
+                       next-level-cache = <&L2>;
+               };
+       };
+
Documentation/devicetree/bindings/arm/npcm/npcm.txt new file +6 -0
new file mode 100644
index 000000000000..2d87d9ecea85
@@ -0,0 +1,6 @@
+NPCM Platforms Device Tree Bindings
+-----------------------------------
+NPCM750 SoC
+Required root node properties:
+       - compatible = "nuvoton,npcm750";
+
arch/arm/boot/dts/nuvoton-npcm750-evb.dts new file +48 -0
new file mode 100644
index 000000000000..a0675e584125
@@ -0,0 +1,48 @@
+/*
+ * DTS file for all NPCM750 SoCs
+ *
+ * Copyright 2012 Tomer Maimon <[email protected]>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+/dts-v1/;
+#include "nuvoton-npcm750.dtsi"
+
+/ {
+       model = "Nuvoton npcm750 Development Board (Device Tree)";
+       compatible = "nuvoton,npcm750";
+
+       chosen {
+               stdout-path = &serial3;
+       };
+
+       memory {
+               reg = <0 0x40000000>;
+       };
+};
+
+&watchdog1 {
+       status = "okay";
+};
+
+&serial0 {
+       status = "okay";
+};
+
+&serial1 {
+       status = "okay";
+};
+
+&serial2 {
+       status = "okay";
+};
+
+&serial3 {
+       status = "okay";
+};
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +142 -0
new file mode 100644
index 000000000000..5d8a48e44274
@@ -0,0 +1,211 @@
+/*
+ * DTSi file for the NPCM750 SoC
+ *
+ * Copyright 2012 Tomer Maimon <[email protected]>
+ *
+ * The code contained herein is licensed under the GNU General Public
+ * License. You may obtain a copy of the GNU General Public License
+ * Version 2 or later at the following locations:
+ *
+ * http://www.opensource.org/licenses/gpl-license.html
+ * http://www.gnu.org/copyleft/gpl.html
+ */
+
+#include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/clock/nuvoton,npcm7xx-clks.h>
+
+/ {
+       #address-cells = <1>;
+       #size-cells = <1>;
+       interrupt-parent = <&gic>;
+
+       cpus {
+               #address-cells = <1>;
+               #size-cells = <0>;
+               enable-method = "nuvoton,npcm7xx-smp";
+
+               cpu at 0 {
+                       device_type = "cpu";
+                       compatible = "arm,cortex-a9";
+                       clocks = <&clk NPCM7XX_CLK_CPU>;
+                       clock-names = "clk_cpu";
+                       reg = <0>;
+                       next-level-cache = <&l2>;
+               };
+
+               cpu at 1 {
+                       device_type = "cpu";
+                       compatible = "arm,cortex-a9";
+                       clocks = <&clk NPCM7XX_CLK_CPU>;
+                       clock-names = "clk_cpu";
+                       reg = <1>;
+                       next-level-cache = <&l2>;
+               };
+       };
+
+       gcr: gcr at f0800000 {
+               compatible = "nuvoton,npcm750-gcr", "syscon",
+                       "simple-mfd";
+               reg = <0xf0800000 0x1000>;
+       };
+
+       scu: scu at f03fe000 {
+               compatible = "arm,cortex-a9-scu";
+               reg = <0xf03fe000 0x1000>;
+       };
+
+       l2: cache-controller at f03fc000 {
+               compatible = "arm,pl310-cache";
+               reg = <0xf03fc000 0x1000>;
+               interrupts = <0 21 4>;
+               cache-unified;
+               cache-level = <2>;
+               clocks = <&clk NPCM7XX_CLK_AXI>;
+       };
+
+       gic: interrupt-controller at f03ff000 {
+               compatible = "arm,cortex-a9-gic";
+               interrupt-controller;
+               #interrupt-cells = <3>;
+               reg = <0xf03ff000 0x1000>,
+                   <0xf03fe100 0x100>;
+       };
+
+       timer at f03fe600 {
+               compatible = "arm,cortex-a9-twd-timer";
+               reg = <0xf03fe600 0x20>;
+               interrupts = <1 13 0x304>;
+               clocks = <&clk NPCM7XX_CLK_TIMER>;
+       };
+
+       ahb {
+               #address-cells = <1>;
+               #size-cells = <1>;
+               compatible = "simple-bus";
+               interrupt-parent = <&gic>;
+               ranges = <0x80000000 0x80000000 0x40000000
+                         0xc0000000 0xc0000000 0x00002000
+                         0xc0008000 0xc0008000 0x00001000
+                         0xe0800000 0xe0800000 0x00001000
+                         0xe1000000 0xe1000000 0x00001000
+                         0xe8000000 0xe8000000 0x08000000
+                         /* APB start */
+                         0xf0000000 0xf0000000 0x00005000
+                         0xf0007000 0xf0007000 0x00005000
+                         0xf0010000 0xf0010000 0x00008000
+                         0xf0080000 0xf0080000 0x00010000
+                         0xf009f000 0xf009f000 0x00001000
+                         0xf0100000 0xf0100000 0x00005000
+                         0xf0180000 0xf0180000 0x0000b000
+                         0xf0200000 0xf0200000 0x00002000
+                         /* APB end */
+                         0xf0800000 0xf0800000 0x000fc000
+                         0xf8000000 0xf8000000 0x02000000
+                         0xfb000000 0xfb000000 0x00002000>;
+
+               clk: clock-controller at f0801000 {
+                       compatible = "nuvoton,npcm750-clk";
+                       #clock-cells = <1>;
+                       reg = <0xf0801000 0x1000>;
+                       status = "okay";
+               };
+
+               /* external clock signal rg1refck, supplied by the phy */
+               clk-rg1refck {
+                       compatible = "fixed-clock";
+                       #clock-cells = <0>;
+                       clock-frequency = <125000000>;
+               };
+
+               /* external clock signal rg2refck, supplied by the phy */
+               clk-rg2refck {
+                       compatible = "fixed-clock";
+                       #clock-cells = <0>;
+                       clock-frequency = <125000000>;
+               };
+
+               clk-xin {
+                       compatible = "fixed-clock";
+                       #clock-cells = <0>;
+                       clock-frequency = <50000000>;
+               };
+
+               apb {
+                       #address-cells = <1>;
+                       #size-cells = <1>;
+                       compatible = "simple-bus";
+                       interrupt-parent = <&gic>;
+                       ranges = <0xf0000000 0xf0000000 0x00005000
+                                 0xf0007000 0xf0007000 0x00005000
+                                 0xf0010000 0xf0010000 0x00008000
+                                 0xf0080000 0xf0080000 0x00010000
+                                 0xf009f000 0xf009f000 0x00001000

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 152

Quoted 10 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +10 -0
+                                 0xf0100000 0xf0100000 0x00005000
+                                 0xf0180000 0xf0180000 0x0000b000
+                                 0xf0200000 0xf0200000 0x00002000>;
+
+                       timer0: timer at f0000000 {
+                               compatible = "nuvoton,npcm750-timer";
+                               interrupts = <0 32 4>;
+                               reg = <0xf0000000 0x1000>;
+                               clocks = <&clk NPCM7XX_CLK_TIMER>;
+                       };

I started the upstream process of NPCM7xx clocksource driver, I got the following comment:
https://www.spinics.net/lists/devicetree/msg197916.html

Is it possible to modify the the timer DT entry to:

timer0: timer at f0008000 {
        compatible = "nuvoton,npcm7xx-timer";
        interrupts = <0 32 4>;
        reg = <0xf0008000 0x1000>;
        clocks = <&clk NPCM7XX_CLK_TIMER>;
};
Quoted 105 lines
arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +59 -0
+
+                       watchdog0: watchdog at f0008000 {
+                               compatible = "nuvoton,npcm750-wdt";
+                               interrupts = <0 47 4>;
+                               reg = <0xf0008000 0x1000>;
+                               status = "disabled";
+                               clocks = <&clk NPCM7XX_CLK_TIMER>;
+                       };
+
+                       watchdog1: watchdog at f0009000 {
+                               compatible = "nuvoton,npcm750-wdt";
+                               interrupts = <0 48 4>;
+                               reg = <0xf0009000 0x1000>;
+                               status = "disabled";
+                               clocks = <&clk NPCM7XX_CLK_TIMER>;
+                       };
+
+                       watchdog2: watchdog at f000a000 {
+                               compatible = "nuvoton,npcm750-wdt";
+                               interrupts = <0 49 4>;
+                               reg = <0xf000a000 0x1000>;
+                               status = "disabled";
+                               clocks = <&clk NPCM7XX_CLK_TIMER>;
+                       };
+
+                       serial0: serial0 at f0001000 {
+                               compatible = "nuvoton,npcm750-uart";
+                               reg = <0xf0001000 0x1000>;
+                               clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+                               interrupts = <0 2 4>;
+                               status = "disabled";
+                       };
+
+                       serial1: serial1 at f0002000 {
+                               compatible = "nuvoton,npcm750-uart";
+                               reg = <0xf0002000 0x1000>;
+                               clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+                               interrupts = <0 3 4>;
+                               status = "disabled";
+                       };
+
+                       serial2: serial2 at f0003000 {
+                               compatible = "nuvoton,npcm750-uart";
+                               reg = <0xf0003000 0x1000>;
+                               clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+                               interrupts = <0 4 4>;
+                               status = "disabled";
+                       };
+
+                       serial3: serial3 at f0004000 {
+                               compatible = "nuvoton,npcm750-uart";
+                               reg = <0xf0004000 0x1000>;
+                               clocks = <&clk NPCM7XX_CLK_UART_CORE>;
+                               interrupts = <0 5 4>;
+                               status = "disabled";
+                       };
+               };
+       };
+};
include/dt-bindings/clock/nuvoton,npcm7xx-clks.h new file +39 -1
new file mode 100644
index 000000000000..c69d3bbf7e42
@@ -0,0 +1,39 @@
+/*
+ * Copyright (C) 2016 Nuvoton Technologies,  tali.perry at nuvoton.com
+ *
+ * This software is licensed under the terms of the GNU General Public
+ * License version 2, as published by the Free Software Foundation, and
+ * may be copied, distributed, and modified under those terms.
+ */
+
+#ifndef _DT_BINDINGS_CLK_NPCM7XX_H
+#define _DT_BINDINGS_CLK_NPCM7XX_H
+
+#define NPCM7XX_CLK_PLL0       0
+#define NPCM7XX_CLK_PLL1       1
+#define NPCM7XX_CLK_PLL2       2
+#define NPCM7XX_CLK_GFX                3
+#define NPCM7XX_CLK_APB1       4
+#define NPCM7XX_CLK_APB2       5
+#define NPCM7XX_CLK_APB3       6
+#define NPCM7XX_CLK_APB4       7
+#define NPCM7XX_CLK_APB5       8
+#define NPCM7XX_CLK_MC         9
+#define NPCM7XX_CLK_CPU                10
+#define NPCM7XX_CLK_SPI0       11
+#define NPCM7XX_CLK_SPI3       12
+#define NPCM7XX_CLK_SPIX       13
+#define NPCM7XX_CLK_UART_CORE  14
+#define NPCM7XX_CLK_TIMER      15
+#define NPCM7XX_CLK_HOST_UART  16
+#define NPCM7XX_CLK_MMC                17
+#define NPCM7XX_CLK_SDHC       18
+#define NPCM7XX_CLK_ADC                19
+#define NPCM7XX_CLK_GFX_MEM    20
+#define NPCM7XX_CLK_USB_BRIDGE 21
+#define NPCM7XX_CLK_AXI                22
+#define NPCM7XX_CLK_AHB                23
+#define NPCM7XX_CLK_EMC                24
+#define NPCM7XX_CLK_GMAC       25
+
+#endif
--
Quoted 2 lines

2.14.1.690.gbb1197296e-goog

Thanks!

#6 lore raw

Re: [PATCH v6 2/3] arm: dts: add Nuvoton NPCM750 device tree

Quoted 13 lines · Tomer Maimon

arch/arm/boot/dts/nuvoton-npcm750.dtsi line 152

Quoted 10 lines · Brendan Higgins

Add a common device tree for all Nuvoton NPCM750 BMCs and a board specific device tree for the NPCM750 (Poleg) evaluation board.

arch/arm/boot/dts/nuvoton-npcm750.dtsi new file +6 -0
+                       timer0: timer at f0000000 {
+                               compatible = "nuvoton,npcm750-timer";
+                               interrupts = <0 32 4>;
+                               reg = <0xf0000000 0x1000>;
+                               clocks = <&clk NPCM7XX_CLK_TIMER>;
+                       };
Quoted 8 lines

I started the upstream process of NPCM7xx clocksource driver, I got the following comment:
https://www.spinics.net/lists/devicetree/msg197916.html

Is it possible to modify the the timer DT entry to:

timer0: timer at f0008000 {
        compatible = "nuvoton,npcm7xx-timer";

Please don't. Using 750 is correct. Using 7xx (i.e. wildcards) is not.

If there's subsequent SoCs with the same block, then you can do:
'"nuvoton,npcm760-timer", "nuvoton,npcm750-timer"'.

Rob

#7 lore raw

PATCH v6 3/3 MAINTAINERS: Add entry for the Nuvoton NPCM architecture

In reply to Brendan Higgins

Add maintainers and reviewers for the Nuvoton NPCM architecture.

---
 MAINTAINERS | 13 +++++++++++++
 1 file changed, 13 insertions(+)
MAINTAINERS +13 -0
index 44cb004c765d..ec0d35384a16 100644
@@ -1598,6 +1598,19 @@ F:	drivers/pinctrl/nomadik/
 F:	drivers/i2c/busses/i2c-nomadik.c
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git
 
+ARM/NUVOTON NPCM ARCHITECTURE
+M:	Avi Fishman <[email protected]>
+M:	Tomer Maimon <[email protected]>
+R:	Brendan Higgins <[email protected]>
+R:	Rick Altherr <[email protected]>
+L:	openbmc at lists.ozlabs.org (moderated for non-subscribers)
+S:	Supported
+F:	arch/arm/mach-npcm/
+F:	arch/arm/boot/dts/nuvoton-npcm*
+F:	include/dt-bindings/clock/nuvoton,npcm7xx-clks.h
+F:	drivers/*/*npcm*
+F:	Documentation/*/*npcm*
+
 ARM/NUVOTON W90X900 ARM ARCHITECTURE
 M:	Wan ZongShun <[email protected]>
 L:	linux-arm-kernel at lists.infradead.org (moderated for non-subscribers)
Signature · 1 line
2.14.1.690.gbb1197296e-goog