Skip to contentSkip to conversation

net: ag71xx: define parent devices

PATCH In review Oleksij Rempel 2 participants 5 messages Sep 20, 2017 – Sep 29, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 net: ag71xx: define parent devices

without it we are not able to set mac address from other driver.

---
 drivers/net/ag71xx.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ag71xx.c +2 -0
index 1cec26360..a422aacdd 100644
@@ -580,6 +580,7 @@ static int ag71xx_probe(struct device_d *dev)
 	miibus = &priv->miibus;
 	dev->priv = edev;
 	edev->priv = priv;
+	edev->parent = dev;
 
 	edev->init = ag71xx_ether_init;
 	edev->open = ag71xx_ether_open;
@@ -597,6 +598,7 @@ static int ag71xx_probe(struct device_d *dev)
 	miibus->read = ag71xx_ether_mii_read;
 	miibus->write = ag71xx_ether_mii_write;
 	miibus->priv = priv;
+	miibus->parent = dev;
 
 	/* enable switch core */
 	rd = ar7240_reg_rd(AR71XX_PLL_BASE + AR933X_ETHSW_CLOCK_CONTROL_REG);
Signature · 7 lines
2.11.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw

PATCH 2/3 MIPS: dts: tl_wdr4300: add Atheros ART partition

and define it as source of MAC address for ag71xx driver

---
 arch/mips/dts/ar9344-tl-wdr4300-v1.7.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/mips/dts/ar9344-tl-wdr4300-v1.7.dts +11 -0
index d16cab005..3733ad5b7 100644
@@ -26,6 +26,12 @@
 			compatible = "barebox,environment";
 			device-path = &spiflash, "partname:barebox-environment";
 		};
+
+		art@0 {
+			compatible = "qca,art", "qca,art-ar9344";
+			device-path = &spiflash, "partname:art";
+			barebox,provide-mac-address = <&mac0>;
+		};
 	};
 };
 
@@ -59,6 +65,11 @@
 			label = "barebox-environment";
 			reg = <0x80000 0x10000>;
 		};
+
+		partition@7f0000 {
+			label = "art";
+			reg = <0x7f0000 0x10000>;
+		};
 	};
 };
 
Signature · 7 lines
2.11.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw

Re: [PATCH v1 2/3] MIPS: dts: tl_wdr4300: add Atheros ART partition

Hi Oleksij,

Quoted 25 lines · Oleksij Rempel

and define it as source of MAC address for ag71xx driver

---
 arch/mips/dts/ar9344-tl-wdr4300-v1.7.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/mips/dts/ar9344-tl-wdr4300-v1.7.dts +6 -0
index d16cab005..3733ad5b7 100644
@@ -26,6 +26,12 @@
 			compatible = "barebox,environment";
 			device-path = &spiflash, "partname:barebox-environment";
 		};
+
+		art@0 {
+			compatible = "qca,art", "qca,art-ar9344";
+			device-path = &spiflash, "partname:art";
+			barebox,provide-mac-address = <&mac0>;
+		};
 	};
 };
 

arch/mips/dts/ar9344-tl-wdr4300-v1.7.dts line 74

Quoted 10 lines
arch/mips/dts/ar9344-tl-wdr4300-v1.7.dts +5 -0
@@ -59,6 +65,11 @@
 			label = "barebox-environment";
 			reg = <0x80000 0x10000>;
 		};
+
+		partition@7f0000 {
+			label = "art";
+			reg = <0x7f0000 0x10000>;
+		};
 	};
 };

There once was a proposal to add nvmem support to mtd
(https://lkml.org/lkml/2017/3/7/131). Apparently this didn't make it mainline, although the comments to this series haven't been very negative. Could you have a look if it's worth to pick this work up or at least adopt it for barebox? I have the feeling that nvmem support for mtd is something that we haven't come across for the last time.

Sascha

Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#3 lore raw

Re: [PATCH v1 2/3] MIPS: dts: tl_wdr4300: add Atheros ART partition

Am 26.09.2017 um 09:09 schrieb Sascha Hauer:

Quoted 37 lines

Hi Oleksij,

Quoted 34 lines · Oleksij Rempel

and define it as source of MAC address for ag71xx driver

---
 arch/mips/dts/ar9344-tl-wdr4300-v1.7.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/mips/dts/ar9344-tl-wdr4300-v1.7.dts +11 -0
index d16cab005..3733ad5b7 100644
@@ -26,6 +26,12 @@
 			compatible = "barebox,environment";
 			device-path = &spiflash, "partname:barebox-environment";
 		};
+
+		art@0 {
+			compatible = "qca,art", "qca,art-ar9344";
+			device-path = &spiflash, "partname:art";
+			barebox,provide-mac-address = <&mac0>;
+		};
 	};
 };
 
@@ -59,6 +65,11 @@
 			label = "barebox-environment";
 			reg = <0x80000 0x10000>;
 		};
+
+		partition@7f0000 {
+			label = "art";
+			reg = <0x7f0000 0x10000>;
+		};
 	};
Quoted 8 lines

arch/mips/dts/ar9344-tl-wdr4300-v1.7.dts line 74

Quoted 1 line
arch/mips/dts/ar9344-tl-wdr4300-v1.7.dts +0 -0
 };

There once was a proposal to add nvmem support to mtd
(https://lkml.org/lkml/2017/3/7/131). Apparently this didn't make it mainline, although the comments to this series haven't been very negative. Could you have a look if it's worth to pick this work up or at least adopt it for barebox? I have the feeling that nvmem support for mtd is something that we haven't come across for the last time.

Ok, i'll take a look on it.
Since this will take some time, i'll resend some patches from this set, separately

Signature · 2 lines
Regards,
Oleksij

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#4 lore raw

PATCH 3/3 MIPS: ath79: provide driver for Atheros ART partition

In reply to Oleksij Rempel

this partition contains calibration data for WiFi and some board specific data, like MAC address.

For now we care only about MAC.

---
 arch/mips/mach-ath79/Makefile |   1 +
 arch/mips/mach-ath79/art.c    | 126 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 127 insertions(+)
 create mode 100644 arch/mips/mach-ath79/art.c
arch/mips/mach-ath79/Makefile +1 -0
index 3772daeba..b827b363c 100644
@@ -1,2 +1,3 @@
 obj-y += reset.o
 obj-y += bbu.o
+obj-y += art.o
arch/mips/mach-ath79/art.c new file +126 -0

126 lines not on this page · raw message

Signature · 7 lines
2.11.0


_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox