Skip to contentSkip to conversation

arm64: Always use REFCOUNT_FULL

PATCH In review Kees Cook 3 participants 4 messages Sep 20, 2017 – Sep 21, 2017 arm64

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 arm64: Always use REFCOUNT_FULL

As discussed at the Linux Security Summit, arm64 prefers to use REFCOUNT_FULL by default. This enables it for the architecture.

Cc Ard Biesheuvel <[email protected]>
Cc hw.likun at huawei.com
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Signed-off-by Kees Cook <[email protected]>
---
 arch/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/Kconfig +1 -0
index 0df64a6a56d4..9fe7a7f4c94c 100644
@@ -119,6 +119,7 @@ config ARM64
 	select PCI_ECAM if ACPI
 	select POWER_RESET
 	select POWER_SUPPLY
+	select REFCOUNT_FULL
 	select SPARSE_IRQ
 	select SYSCTL_EXCEPTION_TRACE
 	select THREAD_INFO_IN_TASK
Signature · 6 lines
2.7.4


-- 
Kees Cook
Pixel Security
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Kees Cook

As discussed at the Linux Security Summit, arm64 prefers to use REFCOUNT_FULL by default. This enables it for the architecture.

Cc Ard Biesheuvel <[email protected]>
Cc hw.likun at huawei.com
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Signed-off-by Kees Cook <[email protected]>
Acked-by Ard Biesheuvel <[email protected]>
Quoted 23 lines
---
 arch/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/Kconfig +1 -1
index 0df64a6a56d4..9fe7a7f4c94c 100644
@@ -119,6 +119,7 @@ config ARM64
        select PCI_ECAM if ACPI
        select POWER_RESET
        select POWER_SUPPLY
+       select REFCOUNT_FULL
        select SPARSE_IRQ
        select SYSCTL_EXCEPTION_TRACE
        select THREAD_INFO_IN_TASK
--

2.7.4

--
Kees Cook
Pixel Security

#2 lore raw
In reply to Kees Cook
Quoted 18 lines · Kees Cook

As discussed at the Linux Security Summit, arm64 prefers to use REFCOUNT_FULL by default. This enables it for the architecture.

Cc Ard Biesheuvel <[email protected]>
Cc hw.likun at huawei.com
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Signed-off-by Kees Cook <[email protected]>
---
 arch/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/Kconfig +0 -0
index 0df64a6a56d4..9fe7a7f4c94c 100644

arch/arm64/Kconfig config ARM64 · line 122

Quoted 4 lines
arch/arm64/Kconfig +1 -0
@@ -119,6 +119,7 @@ config ARM64
 	select PCI_ECAM if ACPI
 	select POWER_RESET
 	select POWER_SUPPLY
+	select REFCOUNT_FULL

Umm... That does a bit more than "on by default", unless I'm misreading it. More like "on, and you can't opt out"...

author
#3 lore raw
Quoted 14 lines · Al Viro
Quoted 13 lines · Kees Cook

As discussed at the Linux Security Summit, arm64 prefers to use REFCOUNT_FULL by default. This enables it for the architecture.

Cc Ard Biesheuvel <[email protected]>
Cc hw.likun at huawei.com
Cc Catalin Marinas <[email protected]>
Cc Will Deacon <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Signed-off-by Kees Cook <[email protected]>
---
 arch/arm64/Kconfig | 1 +
 1 file changed, 1 insertion(+)
Quoted 12 lines

arch/arm64/Kconfig config ARM64 · line 122

Quoted 9 lines
arch/arm64/Kconfig +1 -0
index 0df64a6a56d4..9fe7a7f4c94c 100644
@@ -119,6 +119,7 @@ config ARM64
      select PCI_ECAM if ACPI
      select POWER_RESET
      select POWER_SUPPLY
+     select REFCOUNT_FULL

Umm... That does a bit more than "on by default", unless I'm misreading it. More like "on, and you can't opt out"...

True, I should rephrase it to say "arm64 maintainers perfer to use REFCOUNT_FULL unconditionally".

-Kees

Signature · 2 lines
Kees Cook
Pixel Security