Skip to contentSkip to conversation

intel: Remove unused Kabylake pci ids

PATCH In review Anuj Phogat 2 participants 9 messages Sep 11, 2017 – Sep 21, 2017

lore
Share & tools
lore

Anuj Phogat

author
#0 lore raw

PATCH 1/2 intel: Remove unused Kabylake pci ids

These PCI IDs are not used in any Kabylake SKUs. See Mesa commits: ebc5ccf and b2dae9f

Cc Matt Turner <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Signed-off-by Anuj Phogat <[email protected]>
---
 intel/intel_chipset.h | 26 ++++----------------------
 1 file changed, 4 insertions(+), 22 deletions(-)
intel/intel_chipset.h +4 -22
index 3ff59ad..77a9ca6 100644
@@ -192,24 +192,16 @@
 #define PCI_CHIP_SKYLAKE_WKS_GT4	0x193D
 
 #define PCI_CHIP_KABYLAKE_ULT_GT2	0x5916
-#define PCI_CHIP_KABYLAKE_ULT_GT1_5	0x5913
 #define PCI_CHIP_KABYLAKE_ULT_GT1	0x5906
-#define PCI_CHIP_KABYLAKE_ULT_GT3_0	0x5923
 #define PCI_CHIP_KABYLAKE_ULT_GT3_1	0x5926
 #define PCI_CHIP_KABYLAKE_ULT_GT3_2	0x5927
 #define PCI_CHIP_KABYLAKE_ULT_GT2F	0x5921
-#define PCI_CHIP_KABYLAKE_ULX_GT1_5	0x5915
-#define PCI_CHIP_KABYLAKE_ULX_GT1	0x590E
 #define PCI_CHIP_KABYLAKE_ULX_GT2	0x591E
 #define PCI_CHIP_KABYLAKE_DT_GT2	0x5912
 #define PCI_CHIP_KABYLAKE_DT_GT1_5	0x5917
 #define PCI_CHIP_KABYLAKE_DT_GT1	0x5902
 #define PCI_CHIP_KABYLAKE_HALO_GT2	0x591B
-#define PCI_CHIP_KABYLAKE_HALO_GT4	0x593B
-#define PCI_CHIP_KABYLAKE_HALO_GT1_0	0x5908
 #define PCI_CHIP_KABYLAKE_HALO_GT1_1	0x590B
-#define PCI_CHIP_KABYLAKE_SRV_GT2	0x591A
-#define PCI_CHIP_KABYLAKE_SRV_GT1	0x590A
 #define PCI_CHIP_KABYLAKE_WKS_GT2	0x591D
 
 #define PCI_CHIP_BROXTON_0		0x0A84

@@ -432,34 +424,24 @@
 				 (devid) == PCI_CHIP_SKYLAKE_H_GT4	|| \
 				 (devid) == PCI_CHIP_SKYLAKE_WKS_GT4)
 
-#define IS_KBL_GT1(devid)	((devid) == PCI_CHIP_KABYLAKE_ULT_GT1_5	|| \
-				 (devid) == PCI_CHIP_KABYLAKE_ULX_GT1_5	|| \
-				 (devid) == PCI_CHIP_KABYLAKE_DT_GT1_5	|| \
+#define IS_KBL_GT1(devid)	((devid) == PCI_CHIP_KABYLAKE_DT_GT1_5	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULT_GT1	|| \
-				 (devid) == PCI_CHIP_KABYLAKE_ULX_GT1	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_DT_GT1	|| \
-				 (devid) == PCI_CHIP_KABYLAKE_HALO_GT1_0 || \
-				 (devid) == PCI_CHIP_KABYLAKE_HALO_GT1_1 || \
-				 (devid) == PCI_CHIP_KABYLAKE_SRV_GT1)
+				 (devid) == PCI_CHIP_KABYLAKE_HALO_GT1_1)
 
 #define IS_KBL_GT2(devid)	((devid) == PCI_CHIP_KABYLAKE_ULT_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULX_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_DT_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_HALO_GT2	|| \
-				 (devid) == PCI_CHIP_KABYLAKE_SRV_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_WKS_GT2)
 
-#define IS_KBL_GT3(devid)	((devid) == PCI_CHIP_KABYLAKE_ULT_GT3_0	|| \
-				 (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_1	|| \
+#define IS_KBL_GT3(devid)	((devid) == PCI_CHIP_KABYLAKE_ULT_GT3_1	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_2)
 
-#define IS_KBL_GT4(devid)	((devid) == PCI_CHIP_KABYLAKE_HALO_GT4)
-
 #define IS_KABYLAKE(devid)	(IS_KBL_GT1(devid) || \
 				 IS_KBL_GT2(devid) || \
-				 IS_KBL_GT3(devid) || \
-				 IS_KBL_GT4(devid))
+				 IS_KBL_GT3(devid))
 
 #define IS_SKYLAKE(devid)	(IS_SKL_GT1(devid) || \
 				 IS_SKL_GT2(devid) || \
Signature · 6 lines
2.9.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#1 lore raw

PATCH 2/2 intel: Change a KBL pci id to GT2 from GT1.5

See Mesa commit 9c588ff

Cc Matt Turner <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Signed-off-by Anuj Phogat <[email protected]>
---
 intel/intel_chipset.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
intel/intel_chipset.h +3 -3
index 77a9ca6..6bd8ae2 100644
@@ -198,7 +198,7 @@
 #define PCI_CHIP_KABYLAKE_ULT_GT2F	0x5921
 #define PCI_CHIP_KABYLAKE_ULX_GT2	0x591E
 #define PCI_CHIP_KABYLAKE_DT_GT2	0x5912
-#define PCI_CHIP_KABYLAKE_DT_GT1_5	0x5917
+#define PCI_CHIP_KABYLAKE_M_GT2		0x5917
 #define PCI_CHIP_KABYLAKE_DT_GT1	0x5902
 #define PCI_CHIP_KABYLAKE_HALO_GT2	0x591B
 #define PCI_CHIP_KABYLAKE_HALO_GT1_1	0x590B

@@ -424,8 +424,7 @@
 				 (devid) == PCI_CHIP_SKYLAKE_H_GT4	|| \
 				 (devid) == PCI_CHIP_SKYLAKE_WKS_GT4)
 
-#define IS_KBL_GT1(devid)	((devid) == PCI_CHIP_KABYLAKE_DT_GT1_5	|| \
-				 (devid) == PCI_CHIP_KABYLAKE_ULT_GT1	|| \
+#define IS_KBL_GT1(devid)	((devid) == PCI_CHIP_KABYLAKE_ULT_GT1	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_DT_GT1	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_HALO_GT1_1)
 

@@ -433,6 +432,7 @@
 				 (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULX_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_DT_GT2	|| \
+				 (devid) == PCI_CHIP_KABYLAKE_M_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_HALO_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_WKS_GT2)
Signature · 6 lines
2.9.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author
#2 lore raw

PATCH v2 2/2 intel: Change a KBL pci id to GT2 from GT1.5

See Mesa commit 9c588ff

Cc Matt Turner <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Signed-off-by Anuj Phogat <[email protected]>
---
 intel/intel_chipset.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
intel/intel_chipset.h +2 -2
index 3ff59ada..d81b1646 100644
@@ -202,7 +202,7 @@
 #define PCI_CHIP_KABYLAKE_ULX_GT1	0x590E
 #define PCI_CHIP_KABYLAKE_ULX_GT2	0x591E
 #define PCI_CHIP_KABYLAKE_DT_GT2	0x5912
-#define PCI_CHIP_KABYLAKE_DT_GT1_5	0x5917
+#define PCI_CHIP_KABYLAKE_M_GT2		0x5917
 #define PCI_CHIP_KABYLAKE_DT_GT1	0x5902
 #define PCI_CHIP_KABYLAKE_HALO_GT2	0x591B
 #define PCI_CHIP_KABYLAKE_HALO_GT4	0x593B

@@ -434,7 +434,6 @@
 
 #define IS_KBL_GT1(devid)	((devid) == PCI_CHIP_KABYLAKE_ULT_GT1_5	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULX_GT1_5	|| \
-				 (devid) == PCI_CHIP_KABYLAKE_DT_GT1_5	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULT_GT1	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULX_GT1	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_DT_GT1	|| \

@@ -446,6 +445,7 @@
 				 (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULX_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_DT_GT2	|| \
+				 (devid) == PCI_CHIP_KABYLAKE_M_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_HALO_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_SRV_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_WKS_GT2)
Signature · 6 lines
2.13.5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v2 2/2
#3 lore raw

Re: [PATCH libdrm V2 2/2] intel: Change a KBL pci id to GT2 from GT1.5

Quoted 5 lines · Anuj Phogat

See Mesa commit 9c588ff

Cc Matt Turner <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Signed-off-by Anuj Phogat <[email protected]>
Reviewed-by Rodrigo Vivi <[email protected]>
Quoted 36 lines
---
 intel/intel_chipset.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
intel/intel_chipset.h +2 -2
index 3ff59ada..d81b1646 100644
@@ -202,7 +202,7 @@
 #define PCI_CHIP_KABYLAKE_ULX_GT1	0x590E
 #define PCI_CHIP_KABYLAKE_ULX_GT2	0x591E
 #define PCI_CHIP_KABYLAKE_DT_GT2	0x5912
-#define PCI_CHIP_KABYLAKE_DT_GT1_5	0x5917
+#define PCI_CHIP_KABYLAKE_M_GT2		0x5917
 #define PCI_CHIP_KABYLAKE_DT_GT1	0x5902
 #define PCI_CHIP_KABYLAKE_HALO_GT2	0x591B
 #define PCI_CHIP_KABYLAKE_HALO_GT4	0x593B

@@ -434,7 +434,6 @@
 
 #define IS_KBL_GT1(devid)	((devid) == PCI_CHIP_KABYLAKE_ULT_GT1_5	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULX_GT1_5	|| \
-				 (devid) == PCI_CHIP_KABYLAKE_DT_GT1_5	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULT_GT1	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULX_GT1	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_DT_GT1	|| \

@@ -446,6 +445,7 @@
 				 (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_ULX_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_DT_GT2	|| \
+				 (devid) == PCI_CHIP_KABYLAKE_M_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_HALO_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_SRV_GT2	|| \
 				 (devid) == PCI_CHIP_KABYLAKE_WKS_GT2)
Signature · 1 line
2.13.5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#4 lore raw

Re: [PATCH libdrm V2 2/2] intel: Change a KBL pci id to GT2 from GT1.5

Quoted 9 lines · Rodrigo Vivi
Quoted 5 lines · Anuj Phogat

See Mesa commit 9c588ff

Cc Matt Turner <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Signed-off-by Anuj Phogat <[email protected]>
Reviewed-by Rodrigo Vivi <[email protected]>

Rodrigo, I don't have push permissions. Can you push it for me?

Quoted 28 lines
Quoted 28 lines
---
 intel/intel_chipset.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
intel/intel_chipset.h +1 -2
index 3ff59ada..d81b1646 100644
@@ -202,7 +202,7 @@
 #define PCI_CHIP_KABYLAKE_ULX_GT1    0x590E
 #define PCI_CHIP_KABYLAKE_ULX_GT2    0x591E
 #define PCI_CHIP_KABYLAKE_DT_GT2     0x5912
-#define PCI_CHIP_KABYLAKE_DT_GT1_5   0x5917
+#define PCI_CHIP_KABYLAKE_M_GT2              0x5917
 #define PCI_CHIP_KABYLAKE_DT_GT1     0x5902
 #define PCI_CHIP_KABYLAKE_HALO_GT2   0x591B
 #define PCI_CHIP_KABYLAKE_HALO_GT4   0x593B

@@ -434,7 +434,6 @@
 
 #define IS_KBL_GT1(devid)    ((devid) == PCI_CHIP_KABYLAKE_ULT_GT1_5 || \
                               (devid) == PCI_CHIP_KABYLAKE_ULX_GT1_5 || \
-                              (devid) == PCI_CHIP_KABYLAKE_DT_GT1_5  || \
                               (devid) == PCI_CHIP_KABYLAKE_ULT_GT1   || \
                               (devid) == PCI_CHIP_KABYLAKE_ULX_GT1   || \
                               (devid) == PCI_CHIP_KABYLAKE_DT_GT1    || \

@@ -446,6 +445,7 @@
                               (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F  || \
                               (devid) == PCI_CHIP_KABYLAKE_ULX_GT2   || \
Quoted 8 lines
Quoted 8 lines
intel/intel_chipset.h +1 -1
                               (devid) == PCI_CHIP_KABYLAKE_DT_GT2    || \
+                              (devid) == PCI_CHIP_KABYLAKE_M_GT2     || \
                               (devid) == PCI_CHIP_KABYLAKE_HALO_GT2  || \
                               (devid) == PCI_CHIP_KABYLAKE_SRV_GT2   || \
                               (devid) == PCI_CHIP_KABYLAKE_WKS_GT2)
--

2.13.5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Re: [PATCH libdrm V2 2/2] intel: Change a KBL pci id to GT2 from GT1.5

Quoted 11 lines · Anuj Phogat
Quoted 9 lines · Rodrigo Vivi
Quoted 5 lines · Anuj Phogat

See Mesa commit 9c588ff

Cc Matt Turner <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Signed-off-by Anuj Phogat <[email protected]>
Reviewed-by Rodrigo Vivi <[email protected]>

Rodrigo, I don't have push permissions. Can you push it for me?

pushed. thanks for the patch.

Quoted 28 lines
Quoted 28 lines
Quoted 28 lines
---
 intel/intel_chipset.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
intel/intel_chipset.h +1 -2
index 3ff59ada..d81b1646 100644
@@ -202,7 +202,7 @@
 #define PCI_CHIP_KABYLAKE_ULX_GT1    0x590E
 #define PCI_CHIP_KABYLAKE_ULX_GT2    0x591E
 #define PCI_CHIP_KABYLAKE_DT_GT2     0x5912
-#define PCI_CHIP_KABYLAKE_DT_GT1_5   0x5917
+#define PCI_CHIP_KABYLAKE_M_GT2              0x5917
 #define PCI_CHIP_KABYLAKE_DT_GT1     0x5902
 #define PCI_CHIP_KABYLAKE_HALO_GT2   0x591B
 #define PCI_CHIP_KABYLAKE_HALO_GT4   0x593B

@@ -434,7 +434,6 @@
 
 #define IS_KBL_GT1(devid)    ((devid) == PCI_CHIP_KABYLAKE_ULT_GT1_5 || \
                               (devid) == PCI_CHIP_KABYLAKE_ULX_GT1_5 || \
-                              (devid) == PCI_CHIP_KABYLAKE_DT_GT1_5  || \
                               (devid) == PCI_CHIP_KABYLAKE_ULT_GT1   || \
                               (devid) == PCI_CHIP_KABYLAKE_ULX_GT1   || \
                               (devid) == PCI_CHIP_KABYLAKE_DT_GT1    || \

@@ -446,6 +445,7 @@
                               (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F  || \
                               (devid) == PCI_CHIP_KABYLAKE_ULX_GT2   || \
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
intel/intel_chipset.h +1 -1
                               (devid) == PCI_CHIP_KABYLAKE_DT_GT2    || \
+                              (devid) == PCI_CHIP_KABYLAKE_M_GT2     || \
                               (devid) == PCI_CHIP_KABYLAKE_HALO_GT2  || \
                               (devid) == PCI_CHIP_KABYLAKE_SRV_GT2   || \
                               (devid) == PCI_CHIP_KABYLAKE_WKS_GT2)
--

2.13.5

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#6 lore raw

Re: [PATCH libdrm 2/2] intel: Change a KBL pci id to GT2 from GT1.5

In reply to Anuj Phogat

Any comments on this one. Sent out v2 after dropping [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids

Quoted 41 lines · Anuj Phogat

See Mesa commit 9c588ff

Cc Matt Turner <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Signed-off-by Anuj Phogat <[email protected]>
---
 intel/intel_chipset.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
intel/intel_chipset.h +3 -4
index 77a9ca6..6bd8ae2 100644
@@ -198,7 +198,7 @@
 #define PCI_CHIP_KABYLAKE_ULT_GT2F     0x5921
 #define PCI_CHIP_KABYLAKE_ULX_GT2      0x591E
 #define PCI_CHIP_KABYLAKE_DT_GT2       0x5912
-#define PCI_CHIP_KABYLAKE_DT_GT1_5     0x5917
+#define PCI_CHIP_KABYLAKE_M_GT2                0x5917
 #define PCI_CHIP_KABYLAKE_DT_GT1       0x5902
 #define PCI_CHIP_KABYLAKE_HALO_GT2     0x591B
 #define PCI_CHIP_KABYLAKE_HALO_GT1_1   0x590B

@@ -424,8 +424,7 @@
                                 (devid) == PCI_CHIP_SKYLAKE_H_GT4      || \
                                 (devid) == PCI_CHIP_SKYLAKE_WKS_GT4)
 
-#define IS_KBL_GT1(devid)      ((devid) == PCI_CHIP_KABYLAKE_DT_GT1_5  || \
-                                (devid) == PCI_CHIP_KABYLAKE_ULT_GT1   || \
+#define IS_KBL_GT1(devid)      ((devid) == PCI_CHIP_KABYLAKE_ULT_GT1   || \
                                 (devid) == PCI_CHIP_KABYLAKE_DT_GT1    || \
                                 (devid) == PCI_CHIP_KABYLAKE_HALO_GT1_1)
 

@@ -433,6 +432,7 @@
                                 (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F  || \
                                 (devid) == PCI_CHIP_KABYLAKE_ULX_GT2   || \
                                 (devid) == PCI_CHIP_KABYLAKE_DT_GT2    || \
+                                (devid) == PCI_CHIP_KABYLAKE_M_GT2     || \
                                 (devid) == PCI_CHIP_KABYLAKE_HALO_GT2  || \
                                 (devid) == PCI_CHIP_KABYLAKE_WKS_GT2)
 
--
Quoted 2 lines

2.9.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#7 lore raw

Re: [PATCH libdrm 2/2] intel: Change a KBL pci id to GT2 from GT1.5

Quoted 2 lines · Anuj Phogat

Any comments on this one. Sent out v2 after dropping [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids

Correction. Dropped patch for libdrm is:
[PATCH libdrm 1/2] intel: Remove unused Kabylake pci ids

Quoted 42 lines · Anuj Phogat
Quoted 40 lines

See Mesa commit 9c588ff

Cc Matt Turner <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Signed-off-by Anuj Phogat <[email protected]>
---
 intel/intel_chipset.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
intel/intel_chipset.h +3 -3
index 77a9ca6..6bd8ae2 100644
@@ -198,7 +198,7 @@
 #define PCI_CHIP_KABYLAKE_ULT_GT2F     0x5921
 #define PCI_CHIP_KABYLAKE_ULX_GT2      0x591E
 #define PCI_CHIP_KABYLAKE_DT_GT2       0x5912
-#define PCI_CHIP_KABYLAKE_DT_GT1_5     0x5917
+#define PCI_CHIP_KABYLAKE_M_GT2                0x5917
 #define PCI_CHIP_KABYLAKE_DT_GT1       0x5902
 #define PCI_CHIP_KABYLAKE_HALO_GT2     0x591B
 #define PCI_CHIP_KABYLAKE_HALO_GT1_1   0x590B

@@ -424,8 +424,7 @@
                                 (devid) == PCI_CHIP_SKYLAKE_H_GT4      || \
                                 (devid) == PCI_CHIP_SKYLAKE_WKS_GT4)
 
-#define IS_KBL_GT1(devid)      ((devid) == PCI_CHIP_KABYLAKE_DT_GT1_5  || \
-                                (devid) == PCI_CHIP_KABYLAKE_ULT_GT1   || \
+#define IS_KBL_GT1(devid)      ((devid) == PCI_CHIP_KABYLAKE_ULT_GT1   || \
                                 (devid) == PCI_CHIP_KABYLAKE_DT_GT1    || \
                                 (devid) == PCI_CHIP_KABYLAKE_HALO_GT1_1)
 

@@ -433,6 +432,7 @@
                                 (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F  || \
                                 (devid) == PCI_CHIP_KABYLAKE_ULX_GT2   || \
                                 (devid) == PCI_CHIP_KABYLAKE_DT_GT2    || \
+                                (devid) == PCI_CHIP_KABYLAKE_M_GT2     || \
                                 (devid) == PCI_CHIP_KABYLAKE_HALO_GT2  || \
                                 (devid) == PCI_CHIP_KABYLAKE_WKS_GT2)
Quoted 3 lines
Quoted 3 lines

--
2.9.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#8 lore raw
In reply to Anuj Phogat

Dropping this patch.

Quoted 79 lines · Anuj Phogat

These PCI IDs are not used in any Kabylake SKUs. See Mesa commits: ebc5ccf and b2dae9f

Cc Matt Turner <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Signed-off-by Anuj Phogat <[email protected]>
---
 intel/intel_chipset.h | 26 ++++----------------------
 1 file changed, 4 insertions(+), 22 deletions(-)
intel/intel_chipset.h +4 -23
index 3ff59ad..77a9ca6 100644
@@ -192,24 +192,16 @@
 #define PCI_CHIP_SKYLAKE_WKS_GT4       0x193D
 
 #define PCI_CHIP_KABYLAKE_ULT_GT2      0x5916
-#define PCI_CHIP_KABYLAKE_ULT_GT1_5    0x5913
 #define PCI_CHIP_KABYLAKE_ULT_GT1      0x5906
-#define PCI_CHIP_KABYLAKE_ULT_GT3_0    0x5923
 #define PCI_CHIP_KABYLAKE_ULT_GT3_1    0x5926
 #define PCI_CHIP_KABYLAKE_ULT_GT3_2    0x5927
 #define PCI_CHIP_KABYLAKE_ULT_GT2F     0x5921
-#define PCI_CHIP_KABYLAKE_ULX_GT1_5    0x5915
-#define PCI_CHIP_KABYLAKE_ULX_GT1      0x590E
 #define PCI_CHIP_KABYLAKE_ULX_GT2      0x591E
 #define PCI_CHIP_KABYLAKE_DT_GT2       0x5912
 #define PCI_CHIP_KABYLAKE_DT_GT1_5     0x5917
 #define PCI_CHIP_KABYLAKE_DT_GT1       0x5902
 #define PCI_CHIP_KABYLAKE_HALO_GT2     0x591B
-#define PCI_CHIP_KABYLAKE_HALO_GT4     0x593B
-#define PCI_CHIP_KABYLAKE_HALO_GT1_0   0x5908
 #define PCI_CHIP_KABYLAKE_HALO_GT1_1   0x590B
-#define PCI_CHIP_KABYLAKE_SRV_GT2      0x591A
-#define PCI_CHIP_KABYLAKE_SRV_GT1      0x590A
 #define PCI_CHIP_KABYLAKE_WKS_GT2      0x591D
 
 #define PCI_CHIP_BROXTON_0             0x0A84

@@ -432,34 +424,24 @@
                                 (devid) == PCI_CHIP_SKYLAKE_H_GT4      || \
                                 (devid) == PCI_CHIP_SKYLAKE_WKS_GT4)
 
-#define IS_KBL_GT1(devid)      ((devid) == PCI_CHIP_KABYLAKE_ULT_GT1_5 || \
-                                (devid) == PCI_CHIP_KABYLAKE_ULX_GT1_5 || \
-                                (devid) == PCI_CHIP_KABYLAKE_DT_GT1_5  || \
+#define IS_KBL_GT1(devid)      ((devid) == PCI_CHIP_KABYLAKE_DT_GT1_5  || \
                                 (devid) == PCI_CHIP_KABYLAKE_ULT_GT1   || \
-                                (devid) == PCI_CHIP_KABYLAKE_ULX_GT1   || \
                                 (devid) == PCI_CHIP_KABYLAKE_DT_GT1    || \
-                                (devid) == PCI_CHIP_KABYLAKE_HALO_GT1_0 || \
-                                (devid) == PCI_CHIP_KABYLAKE_HALO_GT1_1 || \
-                                (devid) == PCI_CHIP_KABYLAKE_SRV_GT1)
+                                (devid) == PCI_CHIP_KABYLAKE_HALO_GT1_1)
 
 #define IS_KBL_GT2(devid)      ((devid) == PCI_CHIP_KABYLAKE_ULT_GT2   || \
                                 (devid) == PCI_CHIP_KABYLAKE_ULT_GT2F  || \
                                 (devid) == PCI_CHIP_KABYLAKE_ULX_GT2   || \
                                 (devid) == PCI_CHIP_KABYLAKE_DT_GT2    || \
                                 (devid) == PCI_CHIP_KABYLAKE_HALO_GT2  || \
-                                (devid) == PCI_CHIP_KABYLAKE_SRV_GT2   || \
                                 (devid) == PCI_CHIP_KABYLAKE_WKS_GT2)
 
-#define IS_KBL_GT3(devid)      ((devid) == PCI_CHIP_KABYLAKE_ULT_GT3_0 || \
-                                (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_1 || \
+#define IS_KBL_GT3(devid)      ((devid) == PCI_CHIP_KABYLAKE_ULT_GT3_1 || \
                                 (devid) == PCI_CHIP_KABYLAKE_ULT_GT3_2)
 
-#define IS_KBL_GT4(devid)      ((devid) == PCI_CHIP_KABYLAKE_HALO_GT4)
-
 #define IS_KABYLAKE(devid)     (IS_KBL_GT1(devid) || \
                                 IS_KBL_GT2(devid) || \
-                                IS_KBL_GT3(devid) || \
-                                IS_KBL_GT4(devid))
+                                IS_KBL_GT3(devid))
 
 #define IS_SKYLAKE(devid)      (IS_SKL_GT1(devid) || \
                                 IS_SKL_GT2(devid) || \
--
Quoted 2 lines

2.9.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx