drm/i915: Remove use_mmio_flip modparm
Subsystems (2)
PATCH 1/1 drm/i915: Remove use_mmio_flip modparm
This has been unused since commit afa8ce5b3080
("drm/i915: Nuke legacy flip queueing code").
--- drivers/gpu/drm/i915/i915_params.c | 4 ---- drivers/gpu/drm/i915/i915_params.h | 1 - drivers/gpu/drm/i915/intel_lrc.c | 3 +-- 3 files changed, 1 insertion(+), 7 deletions(-)
drivers/gpu/drm/i915/i915_params.c +0 -4
@@ -58,7 +58,6 @@ struct i915_params i915 __read_mostly = { .invert_brightness = 0, .disable_display = 0, .enable_cmd_parser = true, - .use_mmio_flip = 0, .mmio_debug = 0, .verbose_state_checks = 1, .edp_vswing = 0,
@@ -181,9 +180,6 @@ i915_param_named(disable_display, bool, 0400,i915_param_named_unsafe (enable_cmd_parser, bool,0400 ,"Enable command parsing (true=enabled [default], false=disabled)" ); -i915_param_named_unsafe (use_mmio_flip, int,0600 , -"use MMIO flips (-1=never, 0=driver discretion [default], 1=always)" ); -i915_param_named (mmio_debug, int,0600 ,"Enable the MMIO debug code for the first N failures (default: off). " "This may negatively affect performance." );
drivers/gpu/drm/i915/i915_params.h +0 -1
@@ -49,7 +49,6 @@func (int, guc_log_level); \ func(char *, guc_firmware_path); \ func(char *, huc_firmware_path); \ -func (int, use_mmio_flip); \func (int, mmio_debug); \func (int, edp_vswing); \func (int, reset); \
drivers/gpu/drm/i915/intel_lrc.c +1 -2
@@ -243,8 +243,7 @@ int intel_sanitize_enable_execlists(struct drm_i915_private *dev_priv, int enablreturn 0 ;if (HAS_LOGICAL_RING_CONTEXTS (dev_priv) && -USES_PPGTT (dev_priv) && - i915.use_mmio_flip >=0 ) +USES_PPGTT (dev_priv))return 1 ;return 0 ;
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915: Remove use_mmio_flip modparm
== Series Details ==
== Series Details ==
Series: drm/i915: Remove use_mmio_flip modparm
URL : https://patchwork.freedesktop.org/series/30693/
State : failure
== Summary ==
Series 30693 revision 1 was fully merged or fully failed: no git log
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Maarten Lankhorst (2017-09-21 09:18:55)
Quoted 5 lines
This has been unused since commit
afa8ce5b3080
("drm/i915: Nuke legacy flip queueing code").Cc Chris Wilson <[email protected]>Signed-off-by Maarten Lankhorst <[email protected]>
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Jani Nikula
maintainerQuoted 7 lines · Chris Wilson
Quoting Maarten Lankhorst (2017-09-21 09:18:55)
Quoted 5 lines
This has been unused since commit
afa8ce5b3080
("drm/i915: Nuke legacy flip queueing code").Cc Chris Wilson <[email protected]>Signed-off-by Maarten Lankhorst <[email protected]>Reviewed-by Chris Wilson <[email protected]>
\o/-by: Jani Nikula <[email protected]>
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/1 drm/i915: Remove use_mmio_flip modparm, v2.
This has been unused since commit afa8ce5b3080
("drm/i915: Nuke legacy flip queueing code").
Changes since v1:
- Rebase on top of all the changes to modparams.
\o/-by: Jani Nikula <[email protected]>
--- drivers/gpu/drm/i915/i915_params.c | 3 --- drivers/gpu/drm/i915/i915_params.h | 1 - drivers/gpu/drm/i915/intel_lrc.c | 3 +-- 3 files changed, 1 insertion(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_params.c +0 -3
@@ -146,9 +146,6 @@ i915_param_named(disable_display, bool, 0400,i915_param_named_unsafe (enable_cmd_parser, bool,0400 ,"Enable command parsing (true=enabled [default], false=disabled)" ); -i915_param_named_unsafe (use_mmio_flip, int,0600 , -"use MMIO flips (-1=never, 0=driver discretion [default], 1=always)" ); -i915_param_named (mmio_debug, int,0600 ,"Enable the MMIO debug code for the first N failures (default: off). " "This may negatively affect performance." );
drivers/gpu/drm/i915/i915_params.h +0 -1
@@ -49,7 +49,6 @@ param(int, guc_log_level, -1) \ param(char *, guc_firmware_path, NULL) \ param(char *, huc_firmware_path, NULL) \ - param(int, use_mmio_flip, 0) \ param(int, mmio_debug, 0) \ param(int, edp_vswing, 0) \param (int, reset,2 ) \
drivers/gpu/drm/i915/intel_lrc.c +1 -2
@@ -244,8 +244,7 @@ int intel_sanitize_enable_execlists(struct drm_i915_private *dev_priv, int enablreturn 0 ;if (HAS_LOGICAL_RING_CONTEXTS (dev_priv) && -USES_PPGTT (dev_priv) && - i915_modparams.use_mmio_flip >=0 ) +USES_PPGTT (dev_priv))return 1 ;return 0 ;
Signature · 6 lines
2.14.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] drm/i915: Remove use_mmio_flip modparm, v2.
Quoting Maarten Lankhorst (2017-10-04 10:44:16)
Quoted 9 lines
This has been unused since commit
afa8ce5b3080
("drm/i915: Nuke legacy flip queueing code").Changes since v1:
- Rebase on top of all the changes to modparams.Cc Chris Wilson <[email protected]>Signed-off-by Maarten Lankhorst <[email protected]>Reviewed-by Chris Wilson <[email protected]> #v1
Quoted 50 lines
\o/-by: Jani Nikula <[email protected]>
--- drivers/gpu/drm/i915/i915_params.c | 3 --- drivers/gpu/drm/i915/i915_params.h | 1 - drivers/gpu/drm/i915/intel_lrc.c | 3 +-- 3 files changed, 1 insertion(+), 6 deletions(-)drivers/gpu/drm/i915/i915_params.c +0
-3@@ -146,9 +146,6 @@ i915_param_named(disable_display, bool, 0400,i915_param_named_unsafe (enable_cmd_parser, bool,0400 ,"Enable command parsing (true=enabled [default], false=disabled)" ); -i915_param_named_unsafe (use_mmio_flip, int,0600 , -"use MMIO flips (-1=never, 0=driver discretion [default], 1=always)" ); -i915_param_named (mmio_debug, int,0600 ,"Enable the MMIO debug code for the first N failures (default: off). " "This may negatively affect performance." );drivers/gpu/drm/i915/i915_params.h +0
-1@@ -49,7 +49,6 @@ param(int, guc_log_level, -1) \ param(char *, guc_firmware_path, NULL) \ param(char *, huc_firmware_path, NULL) \ - param(int, use_mmio_flip, 0) \ param(int, mmio_debug, 0) \ param(int, edp_vswing, 0) \param (int, reset,2 ) \drivers/gpu/drm/i915/intel_lrc.c +1
-2@@ -244,8 +244,7 @@ int intel_sanitize_enable_execlists(struct drm_i915_private *dev_priv, int enablreturn 0 ;if (HAS_LOGICAL_RING_CONTEXTS (dev_priv) && -USES_PPGTT (dev_priv) && - i915_modparams.use_mmio_flip >=0 ) +USES_PPGTT (dev_priv))return 1 ;return 0 ;Signature · 1 line
2.14.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH] drm/i915: Remove use_mmio_flip modparm, v2.
Op 04-10-17 om 11:47 schreef Chris Wilson:
Quoted 11 lines
Quoting Maarten Lankhorst (2017-10-04 10:44:16)
Quoted 9 lines
This has been unused since commit
afa8ce5b3080
("drm/i915: Nuke legacy flip queueing code").Changes since v1:
- Rebase on top of all the changes to modparams.Cc Chris Wilson <[email protected]>Signed-off-by Maarten Lankhorst <[email protected]>Reviewed-by Chris Wilson <[email protected]> #v1Reviewed-by Chris Wilson <[email protected]>
Thanks, pushed. :)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Remove use_mmio_flip modparm (rev2)
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/i915: Remove use_mmio_flip modparm (rev2)
URL : https://patchwork.freedesktop.org/series/30693/
State : success
== Summary ==
Series 30693v2 drm/i915: Remove use_mmio_flip modparm
https://patchwork.freedesktop.org/api/1.0/series/30693/revisions/2/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Test kms_busy:
Subgroup basic-flip-b:
dmesg-warn -> PASS (fi-skl-6700hq) fdo#101518
Subgroup basic-flip-c:
dmesg-warn -> PASS (fi-skl-6700k) fdo#103097
Test drv_module_reload:
Subgroup basic-no-display:
dmesg-warn -> PASS (fi-cfl-s) k.org#196765 +1fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#101518 https://bugs.freedesktop.org/show_bug.cgi?id=101518
fdo#103097 https://bugs.freedesktop.org/show_bug.cgi?id=103097
k.org#196765 https://bugzilla.kernel.org/show_bug.cgi?id=196765
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:459s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:472s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:395s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:567s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:289s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:516s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:533s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:556s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:534s fi-cfl-s total:289 pass:256 dwarn:1 dfail:0 fail:0 skip:32 time:553s fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:617s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:436s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:599s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:437s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:421s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:472s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:505s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:478s fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:500s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:581s fi-kbl-7567u total:289 pass:265 dwarn:4 dfail:0 fail:0 skip:20 time:490s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:591s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:652s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:469s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:610s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:536s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:513s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:470s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:582s fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:433s
d8f7188551f39358e833794a9e651422dbe9a1e2 drm-tip: 2017y-10m-04d-08h-46m-00s UTC integration manifest a7ba64bc213f drm/i915: Remove use_mmio_flip modparm, v2.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5894/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for drm/i915: Remove use_mmio_flip modparm (rev2)
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/i915: Remove use_mmio_flip modparm (rev2)
URL : https://patchwork.freedesktop.org/series/30693/
State : warning
== Summary ==
Test kms_vblank:
Subgroup query-forked-busy:
pass -> SKIP (shard-hsw)
Test kms_rotation_crc:
Subgroup sprite-rotation-180:
pass -> SKIP (shard-hsw)
Test kms_busy:
Subgroup extended-modeset-hang-newfb-with-reset-render-C:
pass -> SKIP (shard-hsw) fdo#102249
Test pm_lpsp:
Subgroup non-edp:
pass -> SKIP (shard-hsw)
Test kms_draw_crc:
Subgroup draw-method-xrgb8888-mmap-cpu-untiled:
skip -> PASS (shard-hsw)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-spr-indfb-draw-blt:
skip -> PASS (shard-hsw)
Test kms_cursor_legacy:
Subgroup cursorA-vs-flipA-atomic:
skip -> PASS (shard-hsw)
Subgroup pipe-F-forked-move:
incomplete -> SKIP (shard-hsw) fdo#102332 +1fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
fdo#102332 https://bugs.freedesktop.org/show_bug.cgi?id=102332
shard-hsw total:2429 pass:1328 dwarn:6 dfail:0 fail:8 skip:1087 time:10094s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5894/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx