Skip to contentSkip to conversation

backport: HID: wacom: leds: Don't try to control the EKR's read-only LEDs

PATCH New Jason Gerecke 1 participant 1 message Sep 21, 2017 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 2/10 backport: HID: wacom: leds: Don't try to control the EKR's read-only LEDs

From: Aaron Armstrong Skomra <[email protected]>

Commit a50aac7193f1 introduces 'led.groups' and adds EKR support for these groups. However, unlike the other devices with LEDs, the EKR's LEDs are read-only and we shouldn't attempt to control them in wacom_led_control().

See bug: https://sourceforge.net/p/linuxwacom/bugs/342/

Fixes a50aac7193f1 ("backport: HID: wacom: leds: dynamically allocate LED groups")
Cc stable <[email protected]> # 4.9
[[email protected]: Imported into input-wacom repository (74aebed6dc)]
[[email protected]: Backported from input-wacom repository (7a69536)]
---
 3.17/wacom_sys.c | 3 +++
 1 file changed, 3 insertions(+)
3.17/wacom_sys.c +3 -0
index 2996d0d..8fd0b78 100644
@@ -794,6 +794,9 @@ static int wacom_led_control(struct wacom *wacom)
 	if (!wacom->led.groups)
 		return -ENOTSUPP;
 
+	if (wacom->wacom_wac.features.type == REMOTE)
+		return -ENOTSUPP;
+
 	if (wacom->wacom_wac.pid) { /* wireless connected */
 		report_id = WAC_CMD_WL_LED_CONTROL;
 		buf_size = 13;
Signature · 1 line
2.14.1