MAINTAINERS: Fix subsystem name for "Build and test automation"

PATCH Applied Eduardo Habkost 4 participants 6 messages Sep 21, 2017 – Sep 25, 2017

Share & tools

Eduardo Habkost

author

2017-09-21 17:02 UTC #0 lore raw

PATCH 1/1 MAINTAINERS: Fix subsystem name for "Build and test automation"

The subsystem name for the "Build test automation" section is "-------------------------", because an actual subsystem name line is missing:

  $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
  "Alex Bennée" <[email protected]> (maintainer:-----------------...)
  Fam Zheng <[email protected]> (maintainer:-----------------...)
  "Philippe Mathieu-Daudé" <[email protected]> (reviewer:-----------------...)
  [email protected] (open list:-----------------...)

Fix the issue by inserting a subsystem name line where get_maintainer.pl expects it.

Signed-off-by Eduardo Habkost <[email protected]>

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

MAINTAINERS +1 -0

index e511ba780f..13c1ac65b7 100644
@@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
 
 Build and test automation
 -------------------------
+Build and test automation
 M: Alex Bennée <[email protected]>
 M: Fam Zheng <[email protected]>
 R: Philippe Mathieu-Daudé <[email protected]>

Signature · 1 line

2.13.5

Thomas Huth

2017-09-22 03:14 UTC #2 lore raw

In reply to Eduardo Habkost

Quoted 23 lines · Eduardo Habkost

The subsystem name for the "Build test automation" section is "-------------------------", because an actual subsystem name line is missing:
  $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
  "Alex Bennée" <[email protected]> (maintainer:-----------------...)
  Fam Zheng <[email protected]> (maintainer:-----------------...)
  "Philippe Mathieu-Daudé" <[email protected]> (reviewer:-----------------...)
  [email protected] (open list:-----------------...)
Fix the issue by inserting a subsystem name line where get_maintainer.pl expects it.
Signed-off-by Eduardo Habkost <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index e511ba780f..13c1ac65b7 100644

MAINTAINERS F: docs/block-replication.txt · line 1899

Quoted 4 lines

MAINTAINERS +1 -0

@@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
 
 Build and test automation
 -------------------------
+Build and test automation

Would it make sense to use something more specific here? Like "Travis and Docker" or so? ... in case we add other subsections in the future?

Thomas

Fam Zheng

2017-09-22 03:30 UTC #3 lore raw

Quoted 25 lines · Thomas Huth

Quoted 24 lines · Eduardo Habkost
The subsystem name for the "Build test automation" section is "-------------------------", because an actual subsystem name line is missing:
  $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
  "Alex Bennée" <[email protected]> (maintainer:-----------------...)
  Fam Zheng <[email protected]> (maintainer:-----------------...)
  "Philippe Mathieu-Daudé" <[email protected]> (reviewer:-----------------...)
  [email protected] (open list:-----------------...)
Fix the issue by inserting a subsystem name line where get_maintainer.pl expects it.
Signed-off-by Eduardo Habkost <[email protected]>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index e511ba780f..13c1ac65b7 100644
@@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
 

Quoted 6 lines

MAINTAINERS F: docs/block-replication.txt · line 1899
Quoted 3 lines
MAINTAINERS +1 -0
 Build and test automation
 -------------------------
+Build and test automation
Would it make sense to use something more specific here? Like "Travis and Docker" or so? ... in case we add other subsections in the future?

Unless we are to split off (i.e. more people volunteering maintaining a certain subset), the list will just go on and on in this line. For not it's already going to be "Travis, Shippable, Docker and VM test".. so I think a generic description here is okay, though the duplication is a bit odd (but I don't have a better idea).

Fam

Eric Blake

2017-09-22 21:02 UTC #4 lore raw

Quoted 4 lines · Fam Zheng

Quoted 4 lines
Quoted 3 lines
Build and test automation
-------------------------
+Build and test automation

Quoted 8 lines

Quoted 2 lines
Would it make sense to use something more specific here? Like "Travis and Docker" or so? ... in case we add other subsections in the future?
Unless we are to split off (i.e. more people volunteering maintaining a certain subset), the list will just go on and on in this line. For not it's already going to be "Travis, Shippable, Docker and VM test".. so I think a generic description here is okay, though the duplication is a bit odd (but I don't have a better idea).

Or we could make a generic section of "Build, Tests, and Documentation", and merge in the "Build system architecture" of the immediately-subsequent "Documentation" section, as well as possibly any future sections for someone to maintain top-level build-related files (including MAINTAINERS itself...), so that we have just one larger section with multiple sub-sections, instead of two sections each with one sub-section.

Signature · 3 lines

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Fam Zheng

2017-09-25 02:37 UTC #5 lore raw

Quoted 15 lines · Eric Blake

Quoted 4 lines · Fam Zheng
Quoted 4 lines
Quoted 3 lines
Build and test automation
-------------------------
+Build and test automation
Quoted 8 lines
Quoted 2 lines
Would it make sense to use something more specific here? Like "Travis and Docker" or so? ... in case we add other subsections in the future?
Unless we are to split off (i.e. more people volunteering maintaining a certain subset), the list will just go on and on in this line. For not it's already going to be "Travis, Shippable, Docker and VM test".. so I think a generic description here is okay, though the duplication is a bit odd (but I don't have a better idea).

Quoted 7 lines

Or we could make a generic section of "Build, Tests, and Documentation", and merge in the "Build system architecture" of the immediately-subsequent "Documentation" section, as well as possibly any future sections for someone to maintain top-level build-related files (including MAINTAINERS itself...), so that we have just one larger section with multiple sub-sections, instead of two sections each with one sub-section.

That sounds okay, but actually most of the files under docs/ don't have a maintainer, so in the hope that one day they will, the "Documentation" section may be a good place to host more entries.

Fam