Skip to contentSkip to conversation

ARM: dts: imx6sx: add vining-2000 board support

PATCH Superseded Christoph Fritz 3 participants 7 messages Aug 31, 2017 – Sep 22, 2017

Subsystems (3)
Device tree bindings Arm i.MX and Layerscape Arm and arm64 SoC sub-architectures (common parts)
lore
Share & tools
lore

Christoph Fritz

author
#0 lore raw

PATCH 1/1 ARM: dts: imx6sx: add vining-2000 board support

Add initial imx6sx-softing-vining-2000 board support.

Signed-off-by Christoph Fritz <[email protected]>
---
 arch/arm/boot/dts/Makefile                       |   1 +
 arch/arm/boot/dts/imx6sx-softing-vining-2000.dts | 575 +++++++++++++++++++++++
 2 files changed, 576 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
arch/arm/boot/dts/Makefile +1 -0
index 4b17f35..0d9673d 100644
@@ -461,6 +461,7 @@ dtb-$(CONFIG_SOC_IMX6SX) += \
 	imx6sx-sdb-reva.dtb \
 	imx6sx-sdb-sai.dtb \
 	imx6sx-sdb.dtb \
+	imx6sx-softing-vining-2000.dtb \
 	imx6sx-udoo-neo-basic.dtb \
 	imx6sx-udoo-neo-extended.dtb \
 	imx6sx-udoo-neo-full.dtb
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +575 -0

575 lines not on this page · raw message

Signature · 1 line
2.1.4
reviewer
#1 lore raw

PATCH 1/1 ARM: dts: imx6sx: add vining-2000 board support

Hi Christoph,

arch/arm/boot/dts/imx6sx-softing-vining-2000.dts line 7

Quoted 10 lines · Christoph Fritz
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +7 -0
@@ -0,0 +1,575 @@
+/*
+ * Copyright (C) 2016 Christoph Fritz
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */

Please consider using dual license GPL/X11 license.

arch/arm/boot/dts/imx6sx-softing-vining-2000.dts line 17

Quoted 10 lines
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +10 -0
+
+/dts-v1/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include "imx6sx.dtsi"
+
+/ {
+       model = "Softing VIN|ING 2000";
+       compatible = "softing,imx6sx-vining-2000", "fsl,imx6sx";

I see the following entry in Documentation/devicetree/bindings/vendor-prefixes.txt:

samtec Samtec/Softing company

Could you use "samtec,imx6sx-vining-2000" instead?

arch/arm/boot/dts/imx6sx-softing-vining-2000.dts line 30

Quoted 13 lines
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +13 -0
+
+       chosen {
+               stdout-path = &uart1;
+       };
+
+       memory {
+               reg = <0x80000000 0x40000000>;
+       };
+
+       regulators {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <0>;

No need to have this 'regulators' node.

arch/arm/boot/dts/imx6sx-softing-vining-2000.dts line 32

Quoted 2 lines
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +2 -0
+
+               reg_usb_otg1_vbus: regulator at 0 {

Please use the same regulator pattern as in
arch/arm/boot/dts/imx6q-tbs2910.dts, for example.

Quoted 14 lines
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +14 -0
+&fec2 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_enet2>;
+       phy-supply = <&reg_peri_3v3>;
+       phy-reset-gpios = <&gpio5 21 GPIO_ACTIVE_LOW>;
+       phy-reset-duration = <5>;
+       phy-mode = "rmii";
+       phy-handle = <&ethphy1>;
+       status = "okay";
+
+       mdio {
+               #address-cells = <1>;
+               #size-cells = <0>;
+

arch/arm/boot/dts/imx6sx-softing-vining-2000.dts line 122

Quoted 10 lines
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +10 -0
+               ethphy1: ethernet1-phy at 0 {
+                       reg = <0>;
+                       max-speed = <100>;
+                       interrupts-parent = <&gpio2>;
+                       interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
+               };
+       };
+};
+
+&i2c3 {

Keep the nodes in alphabetical order.

arch/arm/boot/dts/imx6sx-softing-vining-2000.dts line 211

Quoted 12 lines
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +12 -0
+&iomuxc {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_gpios>;
+
+       pinctrl_gpios: gpiosgrp {
+               fsl,pins = <
+                       /* reset external uC */
+                       MX6SX_PAD_QSPI1A_DATA3__GPIO4_IO_19     0x80000000
+                       /* IRQ from external uC */
+                       MX6SX_PAD_KEY_ROW0__GPIO2_IO_15         0x80000000
+                       /* overcurrent detection */
+                       MX6SX_PAD_GPIO1_IO08__GPIO1_IO_8        0x80000000

Do not use 0x80000000. Better use the real IOMUX value instead. Same applies to other IOMUX instances.

Quoted 5 lines
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +5 -0
+&cpu0 {
+       operating-points = <
+               /* kHz    uV */
+               996000  1250000
+               792000  1175000

arch/arm/boot/dts/imx6sx-softing-vining-2000.dts line 441

Quoted 10 lines
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +10 -0
+               396000  1175000
+               198000  1175000
+               >;
+       fsl,soc-operating-points = <
+               /* ARM kHz  SOC uV */
+               996000  1250000
+               792000  1175000
+               396000  1175000
+               198000  1175000
+       >;

It would be nice to add a comment as to why the operating points from imx6sx.dtsi can't be used.

arch/arm/boot/dts/imx6sx-softing-vining-2000.dts line 555

Quoted 4 lines
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +4 -0
+&ecspi4 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_ecspi4>;
+       fsl,spi-num-chipselects = <1>;

This property has been deprecated, so remove it.

arch/arm/boot/dts/imx6sx-softing-vining-2000.dts line 556

Quoted 1 line
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +1 -0
+       cs-gpios = <&gpio7 4 0>;

Is this really active high? Please double check and use proper GPIO flags GPIO_ACTIVE_HIGH/LOW.

author
#2 lore raw

PATCH v2 1/1 ARM: dts: imx6sx: add vining-2000 board support

Add initial imx6sx-softing-vining-2000 board support.

Signed-off-by Christoph Fritz <[email protected]>

---
Changes since v1:
- considered and declined X11 license
- compat string changed to samtec Samtec/Softing company
- purged deprecated 'regulators' node
- unify regulator pattern
- keep nodes in alphabetical order
- change 0x80000000 iomux to real value
- add comment to cpu0 node
- remove deprecated spi-num-chipselects
- use name instead of number for ecspi4 CS

 arch/arm/boot/dts/Makefile                       |   1 +
 arch/arm/boot/dts/imx6sx-softing-vining-2000.dts | 572 +++++++++++++++++++++++
 2 files changed, 573 insertions(+)
 create mode 100644 arch/arm/boot/dts/imx6sx-softing-vining-2000.dts
arch/arm/boot/dts/Makefile +1 -0
index 4b17f35..0d9673d 100644
@@ -461,6 +461,7 @@ dtb-$(CONFIG_SOC_IMX6SX) += \
 	imx6sx-sdb-reva.dtb \
 	imx6sx-sdb-sai.dtb \
 	imx6sx-sdb.dtb \
+	imx6sx-softing-vining-2000.dtb \
 	imx6sx-udoo-neo-basic.dtb \
 	imx6sx-udoo-neo-extended.dtb \
 	imx6sx-udoo-neo-full.dtb
arch/arm/boot/dts/imx6sx-softing-vining-2000.dts new file +572 -0

572 lines not on this page · raw message

Signature · 1 line
2.1.4
author
#3 lore raw

PATCH v2 1/1 ARM: dts: imx6sx: add vining-2000 board support

Quoted 4 lines · Christoph Fritz

Add initial imx6sx-softing-vining-2000 board support.

Signed-off-by Christoph Fritz <[email protected]>

---

Hi Fabio,

can I get your ack on patch v2 or do you have further annotations?

thanks
-- Christoph