Skip to contentSkip to conversation

igt/kms_psr_sink_crc: Fix the bug in psr_drrs subtest

PATCH In review Radhakrishna Sripada 3 participants 4 messages Sep 22, 2017

lore
Share & tools
lore

Radhakrishna Sripada

author
#0 lore raw

PATCH v2 1/1 igt/kms_psr_sink_crc: Fix the bug in psr_drrs subtest

The substring to be matched is "DRRS Supported: Yes" and not "DRRS Support: No". The kernel prints the DRRS status for all active CRTC's. Matching for No support gives a false positive when multiple CRTC's are active.

Fixes 33355210a43e (igt/kms_psr_sink_crc: Add psr_drrs subtest)
Cc C. Ramalingam <[email protected]>
Cc Lohith BS <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
Signed-off-by Radhakrishna Sripada <[email protected]>
---
 tests/kms_psr_sink_crc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_psr_sink_crc.c +1 -1
index 1c25f2c81a34..f023b12c0131 100644
@@ -290,7 +290,7 @@ static bool drrs_disabled(data_t *data)
 
 	igt_debugfs_read(data->drm_fd, "i915_drrs_status", buf);
 
-	return strstr(buf, "DRRS Support: No\n");
+	return !strstr(buf, "DRRS Supported: Yes\n");
 }
 
 static void run_test(data_t *data)
Signature · 6 lines
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v2 1/1
#1 lore raw
Reviewed-by Rodrigo Vivi <[email protected]>

I'll merge this and DK's one you reviewed as soon as I recharge my laptop! :)

Quoted 33 lines · Radhakrishna

The substring to be matched is "DRRS Supported: Yes" and not "DRRS Support: No". The kernel prints the DRRS status for all active CRTC's. Matching for No support gives a false positive when multiple CRTC's are active.

Fixes 33355210a43e (igt/kms_psr_sink_crc: Add psr_drrs subtest)
Cc C. Ramalingam <[email protected]>
Cc Lohith BS <[email protected]>
Cc Rodrigo Vivi <[email protected]>
Cc Dhinakaran Pandiyan <[email protected]>
Signed-off-by Radhakrishna Sripada <[email protected]>

---
tests/kms_psr_sink_crc.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_psr_sink_crc.c +1 -1
index 1c25f2c81a34..f023b12c0131 100644
@@ -290,7 +290,7 @@ static bool drrs_disabled(data_t *data)
 
   igt_debugfs_read(data->drm_fd, "i915_drrs_status", buf);
 
-    return strstr(buf, "DRRS Support: No\n");
+    return !strstr(buf, "DRRS Supported: Yes\n");
 }
 
 static void run_test(data_t *data)
Signature · 1 line
2.9.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#2 lore raw

✓ Fi.CI.BAT: success for igt/kms_psr_sink_crc: Fix the bug in psr_drrs subtest

In reply to Radhakrishna Sripada
== Series Details ==

== Series Details ==

Series: igt/kms_psr_sink_crc: Fix the bug in psr_drrs subtest
URL : https://patchwork.freedesktop.org/series/30727/
State : success

== Summary ==

IGT patchset tested on top of latest successful build 3a01e58858e6068f75356e798fd90c80cccb37d6 tests/gem_flink_basic: Add documentation for subtests

with latest DRM-Tip kernel build CI_DRM_3121
b32248fc0bd8 drm-tip: 2017y-09m-21d-22h-36m-39s UTC integration manifest

Test chamelium:

        Subgroup common-hpd-after-suspend:
                dmesg-warn -> INCOMPLETE (fi-kbl-7500u) fdo#102505
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-legacy:
                pass       -> FAIL       (fi-snb-2600) fdo#100215
Test pm_rpm:
        Subgroup basic-rte:
                pass       -> DMESG-WARN (fi-cfl-s) fdo#102294

fdo#102505 https://bugs.freedesktop.org/show_bug.cgi?id=102505
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#102294 https://bugs.freedesktop.org/show_bug.cgi?id=102294

fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:439s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:475s
fi-blb-e6850     total:289  pass:224  dwarn:1   dfail:0   fail:0   skip:64  time:419s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:522s
fi-bwr-2160      total:289  pass:184  dwarn:0   dfail:0   fail:0   skip:105 time:278s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:507s
fi-byt-j1900     total:289  pass:254  dwarn:1   dfail:0   fail:0   skip:34  time:505s
fi-byt-n2820     total:289  pass:250  dwarn:1   dfail:0   fail:0   skip:38  time:491s
fi-cfl-s         total:289  pass:222  dwarn:35  dfail:0   fail:0   skip:32  time:543s
fi-elk-e7500     total:289  pass:230  dwarn:0   dfail:0   fail:0   skip:59  time:424s
fi-glk-1         total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:572s
fi-hsw-4770      total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:430s
fi-hsw-4770r     total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:406s
fi-ilk-650       total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:437s
fi-ivb-3520m     total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:485s
fi-ivb-3770      total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:468s
fi-kbl-7500u     total:9    pass:3    dwarn:0   dfail:0   fail:0   skip:5  
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:576s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:596s
fi-pnv-d510      total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:539s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:453s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:752s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:491s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:476s
fi-snb-2600      total:289  pass:248  dwarn:0   dfail:0   fail:2   skip:39  time:422s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_240/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

CI
#3 lore raw

✓ Fi.CI.IGT: success for igt/kms_psr_sink_crc: Fix the bug in psr_drrs subtest

In reply to Radhakrishna Sripada
== Series Details ==

== Series Details ==

Series: igt/kms_psr_sink_crc: Fix the bug in psr_drrs subtest
URL : https://patchwork.freedesktop.org/series/30727/
State : success

== Summary ==

Test gem_eio:

        Subgroup in-flight-contexts:
                dmesg-warn -> PASS       (shard-hsw) fdo#102886 +3
Test prime_self_import:
        Subgroup reimport-vs-gem_close-race:
                pass       -> FAIL       (shard-hsw) fdo#102655
Test kms_busy:
        Subgroup extended-modeset-hang-oldfb-with-reset-render-A:
                dmesg-warn -> PASS       (shard-hsw) fdo#102249

fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
fdo#102655 https://bugs.freedesktop.org/show_bug.cgi?id=102655
fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249

shard-hsw total:2429 pass:1328 dwarn:5 dfail:0 fail:13 skip:1083 time:9805s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_240/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx