Skip to contentSkip to conversation

net/tftp: fix build if CMD_BOOTEFI is not set

PATCH New Jörg Krause 3 participants 3 messages Sep 15, 2017 – Sep 22, 2017 Networking

lore
Share & tools
lore

Jörg Krause

author
#0 lore raw

PATCH v2 1/1 net/tftp: fix build if CMD_BOOTEFI is not set

Fixes:
net/tftp.c:811: undefined reference to `efi_set_bootdev'

Signed-off-by Jörg Krause <[email protected]>

---
v2:
* remove ifdef for efi header file (suggested by Bin Weng)

---
 net/tftp.c | 2 ++
 1 file changed, 2 insertions(+)
net/tftp.c +2 -0
index a5ed8c5d0a..6671b1f7ca 100644
@@ -805,7 +805,9 @@ void tftp_start(enum proto_t protocol)
 		printf("Load address: 0x%lx\n", load_addr);
 		puts("Loading: *\b");
 		tftp_state = STATE_SEND_RRQ;
+#ifdef CONFIG_CMD_BOOTEFI
 		efi_set_bootdev("Net", "", tftp_filename);
+#endif
 	}
 
 	time_start = get_timer(0);
Signature · 1 line
2.14.1
#1 lore raw

PATCH v2 1/1 net/tftp: fix build if CMD_BOOTEFI is not set

Quoted 11 lines · Jörg Krause

Fixes:
net/tftp.c:811: undefined reference to `efi_set_bootdev'

Signed-off-by Jörg Krause <[email protected]>

---
v2:
* remove ifdef for efi header file (suggested by Bin Weng)

---
 net/tftp.c | 2 ++
 1 file changed, 2 insertions(+)
Reviewed-by Bin Meng <[email protected]>
#2 lore raw

PATCH v2 1/1 net/tftp: fix build if CMD_BOOTEFI is not set

In reply to Jörg Krause
Quoted 5 lines · Jörg Krause

Fixes:
net/tftp.c:811: undefined reference to `efi_set_bootdev'

Signed-off-by Jörg Krause <[email protected]>
Reviewed-by Bin Meng <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170922/624ff48c/attachment.sig>