ARM: dts: meson: fixing USB support on Meson6, Meson8 and Meson8b

This patch fixes the Meson6, Meson8 and Meson8b USB controllers dts nodes which interrupts are level type instead of edge type.
This avoids errors like "usb 1-1-port1: cannot reset (err = -110)" and similars on Odroid-C1+ board.

Fixes e29b1cf87473 ("ARM: dts: meson: add USB support on Meson8 and Meson8b")

Signed-off-by Emiliano Ingrassia <[email protected]>

---
 arch/arm/boot/dts/meson.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

arch/arm/boot/dts/meson.dtsi +2 -3

index cd6ad072e72c..bf270806a688 100644
@@ -217,7 +217,7 @@
                        #address-cells = <1>;
                        #size-cells = <0>;
                        reg = <0xc9040000 0x40000>;
-                       interrupts = <GIC_SPI 30 IRQ_TYPE_EDGE_RISING>;
+                       interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
                        phys = <&usb0_phy>;
                        phy-names = "usb2-phy";
                        dr_mode = "host";

@@ -229,7 +229,7 @@
                        #address-cells = <1>;
                        #size-cells = <0>;
                        reg = <0xc90c0000 0x40000>;
-                       interrupts = <GIC_SPI 31 IRQ_TYPE_EDGE_RISING>;
+                       interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
                        phys = <&usb1_phy>;
                        phy-names = "usb2-phy";
                        dr_mode = "host";
--

2.14.1

Quoted 3 lines

Fixes e29b1cf87473 ("ARM: dts: meson: add USB support on Meson8 and Meson8b")

Signed-off-by Emiliano Ingrassia <[email protected]>

USB on my Meson8 (Meson8m2 to be exact) board still works fine (just like before - maybe that was a fluke though...), confirmed by reading a USB thumb drive to /dev/null:

Tested-by Martin Blumenstingl <[email protected]>

as well as (me being the one who originally didn't do this right):

Signed-off-by Martin Blumenstingl <[email protected]>

This patch fixes the Meson6, Meson8 and Meson8b USB controllers dts nodes which interrupts are level type instead of edge type.
This avoids errors like "usb 1-1-port1: cannot reset (err = -110)" and similars on Odroid-C1+ board.

Fixes e29b1cf87473 ("ARM: dts: meson: add USB support on Meson8 and Meson8b")

Signed-off-by Emiliano Ingrassia <[email protected]>

Or could it be that it freezes
so silently due to some sort of internal power issues? (I got a little paranoid with power stuff since the confirmed, hardware related power issues on the Odroid U3)

Quoted 8 lines · Emiliano Ingrassia

This patch fixes the Meson6, Meson8 and Meson8b USB controllers dts nodes which interrupts are level type instead of edge type.
This avoids errors like "usb 1-1-port1: cannot reset (err = -110)" and similars on Odroid-C1+ board.

Fixes e29b1cf87473 ("ARM: dts: meson: add USB support on Meson8 and Meson8b")

Signed-off-by Emiliano Ingrassia <[email protected]>

Hi Emiliano,

Yes! I can confirm that these two patches made me able to boot a Debian unstable from a USB stick on an Odroid C1+ for the first time. I tested both a v4.13.2 kernel and a v4.14-rc1 with the SMP patches included.

I'm having one oddity with the stress-ng tool though: Several filesystem related tests make the Odroid hang for me. This works for me:

$ cd /tmp/; time stress-ng -v --class filesystem --sequential 1 --exclude copy-file -t 30s
(with /tmp being a tmpfs)

Those tests make the system hang for me almost immediately, though:

$ cd ~/; time stress-ng -v -t 30s --chdir 1
$ cd ~/; time stress-ng -v -t 30s --dir 1
$ cd ~/; time stress-ng -v -t 30s --dirdeep 1
$ cd ~/; time stress-ng -v -t 30s --fallocate 1
$ cd ~/; time stress-ng -v -t 30s --mknod 1
$ cd ~/; time stress-ng -v -t 30s --sync-file 1
$ cd ~/; time stress-ng -v -t 30s --xattr 1

Unfortunately, there is no error message on my serial console then, it just hangs silently with the heartbeat LED stopping to blink.

I also tried:

* Using a USB connected hdd instead of the USB flash drive, with an actively powered USB hub in between.
* Using a clean v4.13.2 with the patched v4.14-rc1 DTB file instead of v4.14-rc1 kernel (with the SMP patches included).

Both without success. I also experienced a two freezes while apt-get installing a few patches.

Anyone having an idea how I could make those crashes more verbose or what else I could try? Or could it be that it freezes so silently due to some sort of internal power issues? (I got a little paranoid with power stuff since the confirmed, hardware related power issues on the Odroid U3)

Regards, Linus

Could you list all the kernels you have tried (included versions and patches) ?

Hi,

I just noticed this patch from Martin:

8a7f0c5 ARM: dts: meson8: add reserved memory zones

And I simply copied those two reserved memory regions from meson8.dtsi to meson8b.dtsi.

It worked :-) \o/.

It fixed the following issues for me all together:

* stress-ng filesystem stressors as mentioned in previous mail all worked now
* stress-ng memory tests now worked without either not hanging the kernel or at least:
* fixed the OOM killer and reboot-on-panic. Before, on OOM the system would just freeze silently, even with reboot-on-panic configured (vm.panic_on_oom=1, kernel.panic=10 in systctl.conf)
* fixed reboots. Before, a "$ reboot" would result in shutdown just fine, but would hang when trying to load the kernel again, right after u-boot (last line: "Starting kernel ...")

Regards, Linus

This patch fixes the Meson6, Meson8 and Meson8b USB controllers dts nodes which interrupts are level type instead of edge type.
This avoids errors like "usb 1-1-port1: cannot reset (err = -110)" and similars on Odroid-C1+ board.

Fixes e29b1cf87473 ("ARM: dts: meson: add USB support on Meson8 and Meson8b")

Signed-off-by Emiliano Ingrassia <[email protected]>