Skip to contentSkip to conversation

nvme-fabrics: request transport module

PATCH New Sagi Grimberg 5 participants 5 messages Sep 24, 2017 – Oct 4, 2017 NVMe

lore
Share & tools
lore

Sagi Grimberg

author maintainer
#0 lore raw

PATCH v2 1/1 nvme-fabrics: request transport module

Help userspace to not make sure transport module is loaded.

Signed-off-by Sagi Grimberg <sagi at grimberg.me>

---
Changes from v1:
- got rid of redundant module name resolution code and ignore request_module retcode

 drivers/nvme/host/fabrics.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/nvme/host/fabrics.c +3 -0
index 6d68738f01ea..ef38552911d4 100644
@@ -945,6 +945,9 @@ nvmf_create_ctrl(struct device *dev, const char *buf, size_t count)
 	if (ret)
 		goto out_free_opts;
 
+
+	request_module("nvme-%s", opts->transport);
+
 	/*
 	 * Check the generic options first as we need a valid transport for
 	 * the lookup below.  Then clear the generic flags so that transport
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 nvme-fabrics: request transport module

Sagi,

Quoted 4 lines · Sagi Grimberg

Help userspace to not make sure transport module is loaded.

Signed-off-by Sagi Grimberg <sagi at grimberg.me>

Shouldn't this read "Help userspace to make sure transport module is loaded." ?
Extra "not"...

Signature · 2 lines
Damien Le Moal
Western Digital Research
maintainer
#2 lore raw

PATCH v2 1/1 nvme-fabrics: request transport module

Quoted 8 lines · Damien Le Moal
Quoted 4 lines

Help userspace to not make sure transport module is loaded.

Signed-off-by Sagi Grimberg <sagi at grimberg.me>

Shouldn't this read "Help userspace to make sure transport module is loaded." ?
Extra "not"...

It should. Be except for that typo the patch looks good to me:

Reviewed-by Christoph Hellwig <hch at lst.de>
#3 lore raw

PATCH v2 1/1 nvme-fabrics: request transport module

In reply to Sagi Grimberg

Looks good (with the typo fix),
Reviewed-by: Johannes Thumshirn <jthumshirn at suse.de>

Signature · 6 lines
Johannes Thumshirn                                          Storage
jthumshirn at suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850