Skip to contentSkip to conversation

dmr/amd/powerplay: Fix typo in ci_populate_fuzzy_fan()

PATCH In review Tom St Denis 2 participants 3 messages Sep 25, 2017 – Sep 26, 2017 2 messages not in the archive

Subsystems (2)
DRM drivers Radeon and amdgpu DRM drivers
lore
Share & tools
lore

Tom St Denis

author
#0 lore raw

PATCH 1/1 dmr/amd/powerplay: Fix typo in ci_populate_fuzzy_fan()

Signed-off-by Tom St Denis <[email protected]>
---
 drivers/gpu/drm/amd/powerplay/smumgr/ci_smc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/ci_smc.c +2 -1
index 7709f620347a..a72ae7ed03cf 100644
@@ -574,7 +574,8 @@ static int ci_populate_fuzzy_fan(struct pp_hwmgr *hwmgr, uint32_t fuse_table_off
 	if ((hwmgr->thermal_controller.advanceFanControlParameters.usFanOutputSensitivity & (1 << 15))
 		|| 0 == hwmgr->thermal_controller.advanceFanControlParameters.usFanOutputSensitivity)
 		tmp = hwmgr->thermal_controller.advanceFanControlParameters.usFanOutputSensitivity
-		    = hwmgr->thermal_controller.advanceFanControlParameters.usDefaultFanOutputSensitivity;
+	else
+		tmp = hwmgr->thermal_controller.advanceFanControlParameters.usDefaultFanOutputSensitivity;
 
 	smu_data->power_tune_table.FuzzyFan_PwmSetDelta = CONVERT_FROM_HOST_TO_SMC_US(tmp);
Signature · 6 lines
2.12.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw

Ping :-)

Tom

Quoted 11 lines · Tom St Denis
Signed-off-by Tom St Denis <[email protected]>
---
  drivers/gpu/drm/amd/powerplay/smumgr/ci_smc.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/ci_smc.c +0 -0
index 7709f620347a..a72ae7ed03cf 100644

drivers/gpu/drm/amd/powerplay/smumgr/ci_smc.c static int ci_populate_fuzzy_fan(struct pp_hwmgr *hwmgr, uint32_t fuse_table_off · line 581

Quoted 9 lines
drivers/gpu/drm/amd/powerplay/smumgr/ci_smc.c +2 -1
@@ -574,7 +574,8 @@ static int ci_populate_fuzzy_fan(struct pp_hwmgr *hwmgr, uint32_t fuse_table_off
  	if ((hwmgr->thermal_controller.advanceFanControlParameters.usFanOutputSensitivity & (1 << 15))
  		|| 0 == hwmgr->thermal_controller.advanceFanControlParameters.usFanOutputSensitivity)
  		tmp = hwmgr->thermal_controller.advanceFanControlParameters.usFanOutputSensitivity
-		    = hwmgr->thermal_controller.advanceFanControlParameters.usDefaultFanOutputSensitivity;
+	else
+		tmp = hwmgr->thermal_controller.advanceFanControlParameters.usDefaultFanOutputSensitivity;
 
  	smu_data->power_tune_table.FuzzyFan_PwmSetDelta = CONVERT_FROM_HOST_TO_SMC_US(tmp);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 8dea2287-0fe7-1703-dfed-011a4611d800-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#4 lore raw
Quoted 8 lines · Tom St Denis

Ping :-)

Tom

Quoted 2 lines · Tom St Denis
Signed-off-by Tom St Denis <[email protected]>
Reviewed-by Alex Deucher <[email protected]>
Quoted 24 lines
Quoted 24 lines
---
  drivers/gpu/drm/amd/powerplay/smumgr/ci_smc.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/smumgr/ci_smc.c +0 -0
index 7709f620347a..a72ae7ed03cf 100644
@@ -574,7 +574,8 @@ static int ci_populate_fuzzy_fan(struct pp_hwmgr
 *hwmgr, uint32_t fuse_table_off
        if

((hwmgr->thermal_controller.advanceFanControlParameters.usFanOutputSensitivity & (1 << 15))

                || 0 ==

hwmgr->thermal_controller.advanceFanControlParameters.usFanOutputSensitivity)
tmp =
hwmgr->thermal_controller.advanceFanControlParameters.usFanOutputSensitivity
- =
hwmgr->thermal_controller.advanceFanControlParameters.usDefaultFanOutputSensitivity;

drivers/gpu/drm/amd/powerplay/smumgr/ci_smc.c +2 -0
+       else
+               tmp =

hwmgr->thermal_controller.advanceFanControlParameters.usDefaultFanOutputSensitivity;
        smu_data->power_tune_table.FuzzyFan_PwmSetDelta =
Quoted 8 lines
Quoted 2 lines

CONVERT_FROM_HOST_TO_SMC_US(tmp);

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx