tools: firewire: nosy-dump: fix a resource leak in main()
PATCH 1/1 tools: firewire: nosy-dump: fix a resource leak in main()
If option_input and option_output is true two files are opened consecutively. In case the second fopen() fails, let's fclose() the first one before returning early.
Signed-off-by Martin Kepplinger <[email protected]>
--- tools/firewire/nosy-dump.c | 2 ++ 1 file changed, 2 insertions(+)
tools/firewire/nosy-dump.c +2 -0
@@ -960,6 +960,8 @@ int main(int argc, const char *argv[]) output =fopen (option_output,"w" );if (output ==NULL ) {fprintf (stderr,"Could not open %s, %m\n" , option_output); +if (input) +fclose (input);return -1 ; } }
Signature · 1 line
2.11.0
Quoted 14 lines · On Sep 13 Martin Kepplinger wrote:
If
option_inputandoption_outputis true two files are opened consecutively. In case the secondfopen()fails, let'sfclose()the first one before returning early.Signed-off-by Martin Kepplinger <[email protected]>--- tools/firewire/nosy-dump.c | 2 ++ 1 file changed, 2 insertions(+)tools/firewire/nosy-dump.c +0
-0
tools/firewire/nosy-dump.c int main(int argc, const char *argv[]) · line 967
Quoted 8 lines
tools/firewire/nosy-dump.c +2
-0@@ -960,6 +960,8 @@ int main(int argc, const char *argv[]) output =fopen (option_output,"w" );if (output ==NULL ) {fprintf (stderr,"Could not open %s, %m\n" , option_output); +if (input) +fclose (input);return -1 ; } }
When we return from main(), all files are closed implicitly.
Signature · 3 lines
Stefan Richter -======----= =--= ==-=- http://arcgraph.de/sr/