KVM: s390: Disable CONFIG_S390_GUEST_OLD_TRANSPORT by default
Subsystems (3)
PATCH 1/1 KVM: s390: Disable CONFIG_S390_GUEST_OLD_TRANSPORT by default
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
--- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/Kconfig +1 -1
@@ -930,7 +930,7 @@ config S390_GUEST the KVM hypervisor. config S390_GUEST_OLD_TRANSPORT - def_bool y + def_bool n prompt "Guest support for old s390 virtio transport (DEPRECATED)" depends on S390_GUEST help
Signature · 1 line
1.8.3.1
Quoted 4 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>
I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Via whom is this supposed to go in? Looking at the MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.
Regards,
Halil
Quoted 18 lines
--- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/s390/Kconfig +1
-1@@ -930,7 +930,7 @@ config S390_GUEST the KVM hypervisor. config S390_GUEST_OLD_TRANSPORT - def_bool y + def_bool n prompt "Guest support for old s390 virtio transport (DEPRECATED)" depends on S390_GUEST help
Christian Borntraeger
Acked-byQuoted 6 lines · Halil Pasic
Quoted 3 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Quoted 7 lines
Quoted 1 line
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.
FWIW as the original author of that transport
I can pick this up for Martins/Heikos tree if you want.
Quoted 22 lines
Regards,
HalilQuoted 18 lines
--- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/s390/Kconfig +1
-1@@ -930,7 +930,7 @@ config S390_GUEST the KVM hypervisor. config S390_GUEST_OLD_TRANSPORT - def_bool y + def_bool n prompt "Guest support for old s390 virtio transport (DEPRECATED)" depends on S390_GUEST help
Quoted 13 lines · Christian Borntraeger
Quoted 11 lines · Halil Pasic
Quoted 4 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Quoted 7 lines
Quoted 2 lines
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.FWIW as the original author of that transport
I can pick this up for Martins/Heikos tree if you want.
That would be great, yes, thanks!
Thomas
Quoted 13 lines · Christian Borntraeger
Quoted 11 lines · Halil Pasic
Quoted 4 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Quoted 7 lines
Quoted 2 lines
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.FWIW as the original author of that transport
I can pick this up for Martins/Heikos tree if you want.
That would be great, yes, thanks!
Thomas
Quoted 13 lines · Christian Borntraeger
Quoted 11 lines · Halil Pasic
Quoted 4 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Quoted 7 lines
Quoted 2 lines
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.FWIW as the original author of that transport
I can pick this up for Martins/Heikos tree if you want.
When will this code be removed?
When the config option was initially added Conny said it should survive "probably two kernel releases or so, depending on feedback". It was merged for v4.8. Now we are five kernel releases later...
Quoted 20 lines · Heiko Carstens
Quoted 19 lines · Christian Borntraeger
Quoted 6 lines · Halil Pasic
Quoted 3 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Quoted 7 lines
Quoted 1 line
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.FWIW as the original author of that transport
Quoted 7 lines
Quoted 1 line
I can pick this up for Martins/Heikos tree if you want.
When will this code be removed?
When the config option was initially added Conny said it should survive "probably two kernel releases or so, depending on feedback". It was merged for v4.8. Now we are five kernel releases later...
Lets wait for one release and then get rid of it?
Quoted 25 lines · Christian Borntraeger
Quoted 22 lines · Heiko Carstens
Quoted 20 lines · Christian Borntraeger
Quoted 6 lines · Halil Pasic
Quoted 3 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Quoted 7 lines
Quoted 1 line
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.FWIW as the original author of that transport
I can pick this up for Martins/Heikos tree if you want.
Quoted 7 lines
Quoted 5 lines
When will this code be removed?
When the config option was initially added Conny said it should survive "probably two kernel releases or so, depending on feedback". It was merged for v4.8. Now we are five kernel releases later...
Lets wait for one release and then get rid of it?
So it's going to be removed with the next merge window. Where is the patch? ;)
Quoted 28 lines · Heiko Carstens
Quoted 27 lines · Christian Borntraeger
Quoted 24 lines · Heiko Carstens
Quoted 13 lines · Christian Borntraeger
Quoted 11 lines · Halil Pasic
Quoted 4 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Quoted 7 lines
Quoted 2 lines
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.FWIW as the original author of that transport
I can pick this up for Martins/Heikos tree if you want.
When will this code be removed?
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
When the config option was initially added Conny said it should survive "probably two kernel releases or so, depending on feedback". It was merged for v4.8. Now we are five kernel releases later...
Lets wait for one release and then get rid of it?
So it's going to be removed with the next merge window. Where is the patch? ;)
Hmm, so far the code was always enabled by default, so in the unlikely case that somebody is still using it, they might not have noticed that this is marked as deprecated. So maybe it's better to keep the code for two more released, but disable it by default, so that people have time to realize that it is going away? ... just my 0.02 € ... but if you prefer, I can also write a patch that removes it immediately instead.
Thomas
Quoted 10 lines · Thomas Huth
Quoted 2 lines · Heiko Carstens
So it's going to be removed with the next merge window. Where is the patch? ;)
Hmm, so far the code was always enabled by default, so in the unlikely case that somebody is still using it, they might not have noticed that this is marked as deprecated. So maybe it's better to keep the code for two more released, but disable it by default, so that people have time to realize that it is going away? ... just my 0.02 € ... but if you prefer, I can also write a patch that removes it immediately instead.
Switching the default from yes to no won't prevent anybody from selecting it again. So I don't see any value in waiting even longer.
Besides the original commit already printed a message to the console that the transport is deprecated.
See commit 3b2fbb3f06ef ("virtio/s390: deprecate old transport").
Quoted 12 lines · On Tue, 26 Sep 2017 13:04:03 +0200 Heiko Carstens <[email protected]>…
Quoted 10 lines · Thomas Huth
Quoted 2 lines · Heiko Carstens
So it's going to be removed with the next merge window. Where is the patch? ;)
Hmm, so far the code was always enabled by default, so in the unlikely case that somebody is still using it, they might not have noticed that this is marked as deprecated. So maybe it's better to keep the code for two more released, but disable it by default, so that people have time to realize that it is going away? ... just my 0.02 € ... but if you prefer, I can also write a patch that removes it immediately instead.
Quoted 7 lines
Switching the default from yes to no won't prevent anybody from selecting it again. So I don't see any value in waiting even longer.
Besides the original commit already printed a message to the console that the transport is deprecated.
See commit3b2fbb3f06ef("virtio/s390: deprecate old transport").
Would ack a removal as well.
Quoted 12 lines · On Tue, 26 Sep 2017 13:04:03 +0200 Heiko Carstens <[email protected]>…
Quoted 10 lines · Thomas Huth
Quoted 2 lines · Heiko Carstens
So it's going to be removed with the next merge window. Where is the patch? ;)
Hmm, so far the code was always enabled by default, so in the unlikely case that somebody is still using it, they might not have noticed that this is marked as deprecated. So maybe it's better to keep the code for two more released, but disable it by default, so that people have time to realize that it is going away? ... just my 0.02 € ... but if you prefer, I can also write a patch that removes it immediately instead.
Quoted 7 lines
Switching the default from yes to no won't prevent anybody from selecting it again. So I don't see any value in waiting even longer.
Besides the original commit already printed a message to the console that the transport is deprecated.
See commit3b2fbb3f06ef("virtio/s390: deprecate old transport").
Would ack a removal as well.
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 10 lines · Thomas Huth
Quoted 2 lines · Heiko Carstens
So it's going to be removed with the next merge window. Where is the patch? ;)
Hmm, so far the code was always enabled by default, so in the unlikely case that somebody is still using it, they might not have noticed that this is marked as deprecated. So maybe it's better to keep the code for two more released, but disable it by default, so that people have time to realize that it is going away? ... just my 0.02 € ... but if you prefer, I can also write a patch that removes it immediately instead.
Switching the default from yes to no won't prevent anybody from selecting it again. So I don't see any value in waiting even longer.
Besides the original commit already printed a message to the console that the transport is deprecated.
See commit 3b2fbb3f06ef ("virtio/s390: deprecate old transport").
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 28 lines · Heiko Carstens
Quoted 27 lines · Christian Borntraeger
Quoted 24 lines · Heiko Carstens
Quoted 13 lines · Christian Borntraeger
Quoted 11 lines · Halil Pasic
Quoted 4 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Quoted 7 lines
Quoted 2 lines
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.FWIW as the original author of that transport
I can pick this up for Martins/Heikos tree if you want.
When will this code be removed?
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
When the config option was initially added Conny said it should survive "probably two kernel releases or so, depending on feedback". It was merged for v4.8. Now we are five kernel releases later...
Lets wait for one release and then get rid of it?
So it's going to be removed with the next merge window. Where is the patch? ;)
Hmm, so far the code was always enabled by default, so in the unlikely case that somebody is still using it, they might not have noticed that this is marked as deprecated. So maybe it's better to keep the code for two more released, but disable it by default, so that people have time to realize that it is going away? ... just my 0.02 € ... but if you prefer, I can also write a patch that removes it immediately instead.
Thomas
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Quoted 25 lines · Christian Borntraeger
Quoted 22 lines · Heiko Carstens
Quoted 20 lines · Christian Borntraeger
Quoted 6 lines · Halil Pasic
Quoted 3 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Quoted 7 lines
Quoted 1 line
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.FWIW as the original author of that transport
I can pick this up for Martins/Heikos tree if you want.
Quoted 7 lines
Quoted 5 lines
When will this code be removed?
When the config option was initially added Conny said it should survive "probably two kernel releases or so, depending on feedback". It was merged for v4.8. Now we are five kernel releases later...
Lets wait for one release and then get rid of it?
So it's going to be removed with the next merge window. Where is the patch? ;)
Quoted 20 lines · Heiko Carstens
Quoted 19 lines · Christian Borntraeger
Quoted 6 lines · Halil Pasic
Quoted 3 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Quoted 7 lines
Quoted 1 line
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.FWIW as the original author of that transport
Quoted 7 lines
Quoted 1 line
I can pick this up for Martins/Heikos tree if you want.
When will this code be removed?
When the config option was initially added Conny said it should survive "probably two kernel releases or so, depending on feedback". It was merged for v4.8. Now we are five kernel releases later...
Lets wait for one release and then get rid of it?
Christian Borntraeger
Acked-byQuoted 6 lines · Halil Pasic
Quoted 3 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Quoted 7 lines
Quoted 1 line
Signed-off-by Thomas Huth <[email protected]>I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Via whom is this supposed to go in? Looking at the
MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.
FWIW as the original author of that transport
I can pick this up for Martins/Heikos tree if you want.
Quoted 22 lines
Regards,
HalilQuoted 18 lines
--- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/s390/Kconfig +1
-1@@ -930,7 +930,7 @@ config S390_GUEST the KVM hypervisor. config S390_GUEST_OLD_TRANSPORT - def_bool y + def_bool n prompt "Guest support for old s390 virtio transport (DEPRECATED)" depends on S390_GUEST help
Quoted 4 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>
I don't have any objections, but there may be something I'm not aware of. Let's see what Connie says. From my side it's ack.
Via whom is this supposed to go in? Looking at the MAINTAINERS, I would say Martin or Heiko but I don't see them among the recipients.
Regards,
Halil
Quoted 18 lines
--- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/s390/Kconfig +1
-1@@ -930,7 +930,7 @@ config S390_GUEST the KVM hypervisor. config S390_GUEST_OLD_TRANSPORT - def_bool y + def_bool n prompt "Guest support for old s390 virtio transport (DEPRECATED)" depends on S390_GUEST help
Christian Borntraeger
AppliedQuoted 4 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>
thanks applied.
Quoted 18 lines
--- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/s390/Kconfig +1
-1@@ -930,7 +930,7 @@ config S390_GUEST the KVM hypervisor. config S390_GUEST_OLD_TRANSPORT - def_bool y + def_bool n prompt "Guest support for old s390 virtio transport (DEPRECATED)" depends on S390_GUEST help
Christian Borntraeger
AppliedQuoted 4 lines · Thomas Huth
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>
thanks applied.
Quoted 18 lines
--- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/s390/Kconfig +1
-1@@ -930,7 +930,7 @@ config S390_GUEST the KVM hypervisor. config S390_GUEST_OLD_TRANSPORT - def_bool y + def_bool n prompt "Guest support for old s390 virtio transport (DEPRECATED)" depends on S390_GUEST help
Quoted 13 lines · On Mon, 25 Sep 2017 16:45:29 +0200 Thomas Huth <[email protected]> wrote:
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>--- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/s390/Kconfig +0
-0
arch/s390/Kconfig config S390_GUEST · line 936
Quoted 8 lines
arch/s390/Kconfig +1
-1@@ -930,7 +930,7 @@ config S390_GUEST the KVM hypervisor. config S390_GUEST_OLD_TRANSPORT - def_bool y + def_bool n prompt "Guest support for old s390 virtio transport (DEPRECATED)" depends on S390_GUEST help
Quoted 13 lines · On Mon, 25 Sep 2017 16:45:29 +0200 Thomas Huth <[email protected]> wrote:
There is no recent user space application available anymore which still supports this old virtio transport, so let's disable this by default.
Signed-off-by Thomas Huth <[email protected]>--- arch/s390/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/s390/Kconfig +0
-0
arch/s390/Kconfig config S390_GUEST · line 936
Quoted 8 lines
arch/s390/Kconfig +1
-1@@ -930,7 +930,7 @@ config S390_GUEST the KVM hypervisor. config S390_GUEST_OLD_TRANSPORT - def_bool y + def_bool n prompt "Guest support for old s390 virtio transport (DEPRECATED)" depends on S390_GUEST help