Skip to contentSkip to conversation

ethdev: increase length device internal name

PATCH Applied Stephen Hemminger 2 participants 3 messages Sep 27, 2017 – Oct 9, 2017

lore
Share & tools
lore

Stephen Hemminger

author
#0 lore raw

PATCH 1/1 ethdev: increase length device internal name

Allow sufficicent space for UUID in string form (36+1). Needed to use UUID with Hyper-V. This was in deprecation notice for previous release and make it so in 17.11.

Signed-off-by Stephen Hemminger <[email protected]>
---
 doc/guides/rel_notes/deprecation.rst    | 3 +++
 lib/librte_eal/common/include/rte_dev.h | 6 +++++-
 2 files changed, 8 insertions(+), 1 deletion(-)
doc/guides/rel_notes/deprecation.rst +3 -0
index 3362f33501dd..ba5b68e70098 100644
@@ -120,3 +120,6 @@ Deprecation Notices
   The non-"do-sig" versions of the hash tables will be removed
   (including the ``signature_offset`` parameter)
   and the "do-sig" versions renamed accordingly.
+
+* ethdev: in 17.11 the size of internal device name is increased
+  to 64 characters to allow for storing longer bus specific name.
lib/librte_eal/common/include/rte_dev.h +5 -1
index 5386d3a28be5..4c4ac7e5d375 100644
@@ -152,7 +152,11 @@ struct rte_driver {
 	const char *alias;              /**< Driver alias. */
 };
 
-#define RTE_DEV_NAME_MAX_LEN (32)
+/*
+ * Internal identifier length
+ * Sufficiently large to allow for UUID or PCI address
+ */
+#define RTE_DEV_NAME_MAX_LEN 64
 
 /**
  * A structure describing a generic device.
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Stephen Hemminger

Allow sufficicent space for UUID in string form (36+1). Needed to use UUID with Hyper-V. This was in deprecation notice for previous release and make it so in 17.11.

Signed-off-by Stephen Hemminger <[email protected]>

Except from below note,

Reviewed-by Ferruh Yigit <[email protected]>
Quoted 10 lines
---
 doc/guides/rel_notes/deprecation.rst    | 3 +++
 lib/librte_eal/common/include/rte_dev.h | 6 +++++-
 2 files changed, 8 insertions(+), 1 deletion(-)
doc/guides/rel_notes/deprecation.rst +0 -0
index 3362f33501dd..ba5b68e70098 100644

doc/guides/rel_notes/deprecation.rst Deprecation Notices · line 125

Quoted 6 lines
doc/guides/rel_notes/deprecation.rst +3 -0
@@ -120,3 +120,6 @@ Deprecation Notices
   The non-"do-sig" versions of the hash tables will be removed
   (including the ``signature_offset`` parameter)
   and the "do-sig" versions renamed accordingly.
+
+* ethdev: in 17.11 the size of internal device name is increased
+  to 64 characters to allow for storing longer bus specific name.

There is already a deprecation notice added in previous release for this release. Since this patch implements it, notice should be removed, instead of adding new one.

Quoted 18 lines
lib/librte_eal/common/include/rte_dev.h +5 -1
index 5386d3a28be5..4c4ac7e5d375 100644
@@ -152,7 +152,11 @@ struct rte_driver {
 	const char *alias;              /**< Driver alias. */
 };
 
-#define RTE_DEV_NAME_MAX_LEN (32)
+/*
+ * Internal identifier length
+ * Sufficiently large to allow for UUID or PCI address
+ */
+#define RTE_DEV_NAME_MAX_LEN 64
 
 /**
  * A structure describing a generic device.
Applied
#2 lore raw
Quoted 8 lines · Ferruh Yigit
Quoted 5 lines · Stephen Hemminger

Allow sufficicent space for UUID in string form (36+1). Needed to use UUID with Hyper-V. This was in deprecation notice for previous release and make it so in 17.11.

Signed-off-by Stephen Hemminger <[email protected]>
Reviewed-by Ferruh Yigit <[email protected]>

Applied to dpdk-next-net/master, thanks.

(deprecation notice fixed while applying)