Skip to contentSkip to conversation

xen-hvm: use errno in error message

PATCH In review Wei Liu 2 participants 3 messages Sep 27, 2017

lore
Share & tools
lore

Wei Liu

author
#0 lore raw

PATCH 1/1 xen-hvm: use errno in error message

The error code is encoding in errno, not rc.

Signed-off-by Wei Liu <[email protected]>

---
Cc: Stefano Stabellini <[email protected]>
Cc: Anthony PERARD <[email protected]>

---
 hw/i386/xen/xen-hvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/xen/xen-hvm.c +1 -1
index d9ccd5d0d6..f79816a649 100644
@@ -1446,7 +1446,7 @@ void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length)
         if (rc) {
             fprintf(stderr,
                     "%s failed for "RAM_ADDR_FMT" ("RAM_ADDR_FMT"): %i, %s\n",
-                    __func__, start, nb_pages, rc, strerror(-rc));
+                    __func__, start, nb_pages, rc, strerror(errno));
         }
     }
 }
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel
Reviewed-by on v1 1/1
#2 lore raw
In reply to Wei Liu
Quoted 1 line · Wei Liu

The error code is encoding in errno, not rc.

^ encoded
I think.

Otherwise,

Reviewed-by Anthony PERARD <[email protected]>

Thanks,

Quoted 25 lines
Signed-off-by Wei Liu <[email protected]>

---
Cc: Stefano Stabellini <[email protected]>
Cc: Anthony PERARD <[email protected]>

---
 hw/i386/xen/xen-hvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/xen/xen-hvm.c +1 -1
index d9ccd5d0d6..f79816a649 100644
@@ -1446,7 +1446,7 @@ void xen_hvm_modified_memory(ram_addr_t start, ram_addr_t length)
         if (rc) {
             fprintf(stderr,
                     "%s failed for "RAM_ADDR_FMT" ("RAM_ADDR_FMT"): %i, %s\n",
-                    __func__, start, nb_pages, rc, strerror(-rc));
+                    __func__, start, nb_pages, rc, strerror(errno));
         }
     }
 }
Signature · 1 line
2.11.0
Signature · 6 lines
Anthony PERARD

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xen.org/xen-devel