Revert "qtbase: Enable EGLFS support"
PATCH 1/1 Revert "qtbase: Enable EGLFS support"
* this reverts commit 04b37dbdb79638b17a670280058400ffaf1b6ccb.
* this makes qtbase and everything which depends on some qt* recipe to be effectivelly MACHINE_ARCH
--- dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend deleted +0 -3
@@ -1,3 +0,0 @@ -# Copyright (C) 2017 O.S. Systems Software LTDA. - -PACKAGECONFIG_GL_rpi = "gles2 eglfs"
Signature · 1 line
2.7.4
Quoted 18 lines · Martin Jansa
* this reverts commit
04b37dbdb79638b17a670280058400ffaf1b6ccb.
* this makes qtbase and everything which depends on some qt* recipe to be effectivellyMACHINE_ARCHSigned-off-by Martin Jansa <[email protected]>--- dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend deleted +0
-0
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend line 3
Quoted 3 lines
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend deleted +0
-3@@ -1,3 +0,0 @@ -# Copyright (C) 2017 O.S. Systems Software LTDA. - -PACKAGECONFIG_GL_rpi = "gles2 eglfs"
What would be the solution though?
--
Andrei Gherzan
Quoted 14 lines · Andrei Gherzan
Quoted 11 lines · Martin Jansa
* this reverts commit
04b37dbdb79638b17a670280058400ffaf1b6ccb.
* this makes qtbase and everything which depends on some qt* recipe to be effectivellyMACHINE_ARCHSigned-off-by Martin Jansa <[email protected]>--- dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 --- 1 file changed, 3 deletions(-) delete mode 100644dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
Quoted 14 lines
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend line 3
Quoted 10 lines
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend deleted +0
-3@@ -1,3 +0,0 @@ -# Copyright (C) 2017 O.S. Systems Software LTDA. - -PACKAGECONFIG_GL_rpi = "gles2 eglfs"What would be the solution though?
I think check for OpenGL feature to enable it
I think another thing is to also check for X11 in distro features before enabling it
Gl support is quite soc specific so I don't think there is an elegant way unless qt components can be built with soc specific elements as plugins or something which then can have independent recipe
Quoted 9 lines
--
Andrei Gherzan--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto
Quoted 31 lines · Khem Raj
Quoted 15 lines · Andrei Gherzan
Quoted 12 lines · Martin Jansa
* this reverts commit
04b37dbdb79638b17a670280058400ffaf1b6ccb.
* this makes qtbase and everything which depends on some qt* recipe to be effectivellyMACHINE_ARCHSigned-off-by Martin Jansa <[email protected]>--- dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 --- 1 file changed, 3 deletions(-) delete mode 100644dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
Quoted 13 lines
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend line 3
Quoted 10 lines
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend deleted +0
-3@@ -1,3 +0,0 @@ -# Copyright (C) 2017 O.S. Systems Software LTDA. - -PACKAGECONFIG_GL_rpi = "gles2 eglfs"What would be the solution though?
Quoted 7 lines
I think check for OpenGL feature to enable it
I think another thing is to also check for X11 in distro features before enabling itGl support is quite soc specific so I don't think there is an elegant way unless qt components can be built with soc specific elements as plugins or something which then can have independent recipe
https://github.com/Freescale/meta-freescale/blob/master/classes/fsl-dynamic-packagearch.bbclass
Something like this?
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Hi Otavio,
Quoted 46 lines
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Otavio Salvador
Sent: Wednesday, September 27, 2017 10:29 AM
To: Khem Raj <[email protected]>
Cc: [email protected]; Otavio Salvador <[email protected]>
Subject: Re: [yocto] [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"Quoted 36 lines · Khem Raj
Quoted 16 lines · Andrei Gherzan
Quoted 12 lines · Martin Jansa
* this reverts commit
04b37dbdb79638b17a670280058400ffaf1b6ccb.
* this makes qtbase and everything which depends on some qt* recipe to be effectivellyMACHINE_ARCHSigned-off-by Martin Jansa <[email protected]>--- dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 --- 1 file changed, 3 deletions(-) delete mode 100644dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
Quoted 14 lines
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend line 3
Quoted 11 lines
diff --git a/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend b/dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend deleted file mode 100644
index ae3f1d3..0000000dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend deleted +0
-3@@ -1,3 +0,0 @@ -# Copyright (C) 2017 O.S. Systems Software LTDA. - -PACKAGECONFIG_GL_rpi = "gles2 eglfs"What would be the solution though?
I think check for OpenGL feature to enable it I think another thing is to also check for X11 in distro features before enabling it
Quoted 9 lines
Quoted 3 lines
Gl support is quite soc specific so I don't think there is an elegant way unless qt components can be built with soc specific elements as plugins or something which then can have independent recipe
https://github.com/Freescale/meta-freescale/blob/master/classes/fsl-dynamic-
packagearch.bbclassSomething like this?
This is very useful, can this concept be upstreamed to OE-Core?
Thanks,
Manju
On Wed, Sep 27, 2017 at 3:53 PM, Manjukumar Harthikote Matha <[email protected]> wrote:
...
Quoted 7 lines
Quoted 5 lines
https://github.com/Freescale/meta-freescale/blob/master/classes/fsl-dynamic-
packagearch.bbclassSomething like this?
This is very useful, can this concept be upstreamed to OE-Core?
I think so; if people agree with this concept I can work in upstreaming it.
There is also the machine-overrides-extender.bbclass[1] which allows for overrides to be added/removed based on other overrides.
1. https://github.com/Freescale/meta-freescale/blob/master/classes/machine-overrides-extender.bbclass
This was how I could generalize the BSP in a kind of SoC feature set.
You can see the original commit where I enable it:
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Hi Otavio,
Quoted 28 lines
-----Original Message-----
From: Otavio Salvador [mailto:[email protected]]
Sent: Wednesday, September 27, 2017 12:23 PM
To: Manjukumar Harthikote Matha <[email protected]>
Cc: Khem Raj <[email protected]>; [email protected]; Otavio Salvador <[email protected]>
Subject: Re: [yocto] [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"On Wed, Sep 27, 2017 at 3:53 PM, Manjukumar Harthikote Matha <[email protected]> wrote:
...Quoted 7 lines
Quoted 5 lines
https://github.com/Freescale/meta-freescale/blob/master/classes/fsl-dynamic-
packagearch.bbclassSomething like this?
This is very useful, can this concept be upstreamed to OE-Core?
I think so; if people agree with this concept I can work in upstreaming it.
There is also the machine-overrides-extender.bbclass[1] which allows for overrides to be added/removed based on other overrides.
1. https://github.com/Freescale/meta-freescale/blob/master/classes/machine-
overrides-extender.bbclass
Quoted 8 lines
This was how I could generalize the BSP in a kind of SoC feature set.
You can see the original commit where I enable it:
https://github.com/Freescale/meta-
freescale/commit/ad4611ab16bcd09eef11d630159253a12c5ecced#diff-7bac7755a2891a94e863ed0a7af1876a
Thanks for the patch.
We were thinking on similar lines for SOC variants and MACHINE variants (basically boards supporting different features like GPU, VCU etc). These configuration mechanism will help resolve these cases. SOARCH can also help in package-feed mechanism for boards
You should definitely considering up streaming these to OE-core
Thanks,
Manju
Quoted 36 lines · Manjukumar Harthikote Matha
Quoted 28 lines
-----Original Message-----
From: Otavio Salvador [mailto:[email protected]]
Sent: Wednesday, September 27, 2017 12:23 PM
To: Manjukumar Harthikote Matha <[email protected]>
Cc: Khem Raj <[email protected]>; [email protected]; Otavio Salvador <[email protected]>
Subject: Re: [yocto] [meta-raspberrypi][PATCH] Revert "qtbase: Enable EGLFS support"On Wed, Sep 27, 2017 at 3:53 PM, Manjukumar Harthikote Matha <[email protected]> wrote:
...Quoted 7 lines
Quoted 5 lines
https://github.com/Freescale/meta-freescale/blob/master/classes/fsl-dynamic-
packagearch.bbclassSomething like this?
This is very useful, can this concept be upstreamed to OE-Core?
I think so; if people agree with this concept I can work in upstreaming it.
There is also the machine-overrides-extender.bbclass[1] which allows for overrides to be added/removed based on other overrides.
1. https://github.com/Freescale/meta-freescale/blob/master/classes/machine-
overrides-extender.bbclassQuoted 8 lines
This was how I could generalize the BSP in a kind of SoC feature set.
You can see the original commit where I enable it:
https://github.com/Freescale/meta-
freescale/commit/ad4611ab16bcd09eef11d630159253a12c5ecced#diff-7bac7755a2891a94e863ed0a7af1876a
Quoted 6 lines
Thanks for the patch.
We were thinking on similar lines for SOC variants and MACHINE variants (basically boards supporting different features like GPU, VCU etc). These configuration mechanism will help resolve these cases. SOARCH can also help in package-feed mechanism for boards
You should definitely considering up streaming these to OE-core
That was the goal. I will work on this.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Quoted 8 lines · Otavio Salvador
Quoted 1 line
This is very useful, can this concept be upstreamed to OE-Core?
I think so; if people agree with this concept I can work in upstreaming it.
There is also the machine-overrides-extender.bbclass[1] which allows for overrides to be added/removed based on other overrides.
1. https://github.com/Freescale/meta-freescale/blob/master/classes/machine-overrides-extender.bbclass
I've been trying (begging) since the start of August to get the above one added to OE-core
https://bugzilla.yoctoproject.org/show_bug.cgi?id=11881
Hello Andrei,
Quoted 14 lines · Andrei Gherzan
Quoted 12 lines · Martin Jansa
* this reverts commit
04b37dbdb79638b17a670280058400ffaf1b6ccb.
* this makes qtbase and everything which depends on some qt* recipe to be effectivellyMACHINE_ARCHSigned-off-by Martin Jansa <[email protected]>--- dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 --- 1 file changed, 3 deletions(-) delete mode 100644dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
Quoted 13 lines
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend line 3
Quoted 10 lines
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend deleted +0
-3@@ -1,3 +0,0 @@ -# Copyright (C) 2017 O.S. Systems Software LTDA. - -PACKAGECONFIG_GL_rpi = "gles2 eglfs"What would be the solution though?
It would use something similar we use for meta-freescale where we change the package architecture depending on the SoC.
Martin, do you have any idea how other alternative we have?
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Quoted 31 lines · Otavio Salvador
Hello Andrei,
Quoted 14 lines · Andrei Gherzan
Quoted 12 lines · Martin Jansa
* this reverts commit
04b37dbdb79638b17a670280058400ffaf1b6ccb.
* this makes qtbase and everything which depends on some qt* recipe to be effectivellyMACHINE_ARCHSigned-off-by Martin Jansa <[email protected]>--- dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend | 3 --- 1 file changed, 3 deletions(-) delete mode 100644dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend
Quoted 13 lines
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend line 3
Quoted 10 lines
dynamic-layers/qt5-layer/recipes-qt/qt5/qtbase_%.bbappend deleted +0
-3@@ -1,3 +0,0 @@ -# Copyright (C) 2017 O.S. Systems Software LTDA. - -PACKAGECONFIG_GL_rpi = "gles2 eglfs"What would be the solution though?
Quoted 4 lines
It would use something similar we use for meta-freescale where we change the package architecture depending on the SoC.
Martin, do you have any idea how other alternative we have?
In theory you can set QT_PACKAGES_ARCH to MACHINE_ARCH in rpi-base.inc to make it explicit, but that's also really bad (as e.g. rpi2 and rpi3 will each build it's own qtwebengine and all it's deps even when it should be the same for both).
I think the only usable solution is to let DISTRO to decide the policy, as Khem suggested DISTRO_FEATURES is first step, if it isn't enough (in this case it's difficult to distinguish e.g. opengl and gles2 when there is opengl in DISTRO_FEATURES). So I would leave it to DISTRO maintainers to decide if they can enable "gles2 eglfs" globally for all MACHINEs in distro bbappend, or they can enable it only for some DEFAULT_TUNE (or e.g. for all arm MACHINEs and leave desktop gl for x86).
But forcing this policy from BSP is bad.
Regards,
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Hello Martin,
On Wed, Sep 27, 2017 at 2:34 PM, Martin Jansa <[email protected]> wrote:
...
Quoted 6 lines
Quoted 1 line
Martin, do you have any idea how other alternative we have?
In theory you can set
QT_PACKAGES_ARCHtoMACHINE_ARCHin rpi-base.inc to make it explicit, but that's also really bad (as e.g. rpi2 and rpi3 will each build it's own qtwebengine and all it's deps even when it should be the same for both).
Agreed and that was the reason of we create MACHINE_SOCARCH in meta-freescale. It allows for SoC specific packages but compatible across machines.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Andrei Gherzan
AppliedQuoted 11 lines · Otavio Salvador
Hello Martin,
On Wed, Sep 27, 2017 at 2:34 PM, Martin Jansa <[email protected]> wrote:
...Quoted 6 lines
Quoted 1 line
Martin, do you have any idea how other alternative we have?
In theory you can set
QT_PACKAGES_ARCHtoMACHINE_ARCHin rpi-base.inc to make it explicit, but that's also really bad (as e.g. rpi2 and rpi3 will each build it's own qtwebengine and all it's deps even when it should be the same for both).
Quoted 8 lines
Agreed and that was the reason of we create
MACHINE_SOCARCHin meta-freescale. It allows for SoC specific packages but compatible across machines.--
Otavio SalvadorO.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Merged to master in the meanwhile.
--
Andrei Gherzan
gpg: rsa4096/D4D94F67AD0E9640 | t: @agherzan