amdgpu/powerplay: constify large struct
Subsystems (2)
PATCH 1/1 amdgpu/powerplay: constify large struct
From: Dave Airlie <[email protected]>
This moves this from being global data to global rodata, I'm sure it would be easy to move it to being local data.
--- drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c | 4 ++-- drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c +2 -2
@@ -1,7 +1,7 @@#include "pp_overdriver.h" #include <linux/errno.h> -struct phm_fuses_default vega10_fuses_default[] = { +const struct phm_fuses_default vega10_fuses_default[] = { {"0000001000010011111010101001010011011110000011100100100101100100" ,0x00003C96 ,0xFFFFE226 ,0x00000656 ,0x00002203 ,0xFFFFF201 ,0x000003FF ,0x00002203 ,0xFFFFF201 ,0x000003FF }, {"0000001000010011111010101001010011011110000010100001100010000100" ,0x00003CC5 ,0xFFFFE23A ,0x0000064E ,0x00002258 ,0xFFFFF1F7 ,0x000003FC ,0x00002258 ,0xFFFFF1F7 ,0x000003FC }, {"0000001000010011111010101001010011011110000011100011000110100100" ,0x00003CAF ,0xFFFFE36E ,0x00000602 ,0x00001E98 ,0xFFFFF569 ,0x00000357 ,0x00001E98 ,0xFFFFF569 ,0x00000357 },
@@ -1240,7 +1240,7 @@ struct phm_fuses_default vega10_fuses_default[] = { };int pp_override_get_default_fuse_value (uint64_t key, -struct phm_fuses_default list[], +const struct phm_fuses_default list[],struct phm_fuses_default *result) {uint32_t i;
drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h +2 -2
@@ -40,9 +40,9 @@ struct phm_fuses_default { uint32_t VFT0_b; }; -extern struct phm_fuses_default vega10_fuses_default[]; +extern const struct phm_fuses_default vega10_fuses_default[];extern int pp_override_get_default_fuse_value (uint64_t key, -struct phm_fuses_default list[], +const struct phm_fuses_default list[],struct phm_fuses_default *result);#endif
Signature · 6 lines
2.9.4 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20170927204531.17938-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Alex Deucher
Reviewed-byQuoted 6 lines · Dave Airlie
From: Dave Airlie <[email protected]>
This moves this from being global data to global rodata, I'm sure it would be easy to move it to being local data.
Signed-off-by Dave Airlie <[email protected]>
Quoted 47 lines
--- drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c | 4 ++-- drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c +2
-2@@ -1,7 +1,7 @@#include "pp_overdriver.h" #include <linux/errno.h> -struct phm_fuses_default vega10_fuses_default[] = { +const struct phm_fuses_default vega10_fuses_default[] = { {"0000001000010011111010101001010011011110000011100100100101100100" ,0x00003C96 ,0xFFFFE226 ,0x00000656 ,0x00002203 ,0xFFFFF201 ,0x000003FF ,0x00002203 ,0xFFFFF201 ,0x000003FF }, {"0000001000010011111010101001010011011110000010100001100010000100" ,0x00003CC5 ,0xFFFFE23A ,0x0000064E ,0x00002258 ,0xFFFFF1F7 ,0x000003FC ,0x00002258 ,0xFFFFF1F7 ,0x000003FC }, {"0000001000010011111010101001010011011110000011100011000110100100" ,0x00003CAF ,0xFFFFE36E ,0x00000602 ,0x00001E98 ,0xFFFFF569 ,0x00000357 ,0x00001E98 ,0xFFFFF569 ,0x00000357 },@@ -1240,7 +1240,7 @@ struct phm_fuses_default vega10_fuses_default[] = { };int pp_override_get_default_fuse_value (uint64_t key, -struct phm_fuses_default list[], +const struct phm_fuses_default list[],struct phm_fuses_default *result) {uint32_t i;drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h +2
-3@@ -40,9 +40,9 @@ struct phm_fuses_default { uint32_t VFT0_b; }; -extern struct phm_fuses_default vega10_fuses_default[]; +extern const struct phm_fuses_default vega10_fuses_default[];extern int pp_override_get_default_fuse_value (uint64_t key, -struct phm_fuses_default list[], +const struct phm_fuses_default list[],struct phm_fuses_default *result);#endif --2.9.4
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx