Skip to contentSkip to conversation

amdgpu/dc: inline a bunch of float operations.

PATCH New Dave Airlie 1 participant 2 messages Sep 28, 2017 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 amdgpu/dc: inline a bunch of float operations.

From: Dave Airlie <[email protected]>

This reduces code size for the bw calcs code.

---
 .../gpu/drm/amd/display/dc/calcs/dcn_calc_math.c   | 29 -----------------
 .../gpu/drm/amd/display/dc/calcs/dcn_calc_math.h   | 36 ++++++++++++++++++----
 2 files changed, 30 insertions(+), 35 deletions(-)
drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.c +0 -29
index a184744..05cf5f7 100644
@@ -25,25 +25,6 @@
 
 #include "dcn_calc_math.h"
 
-float dcn_bw_mod(const float arg1, const float arg2)
-{
-	return arg1 - arg1 * ((int) (arg1 / arg2));
-}
-
-float dcn_bw_min2(const float arg1, const float arg2)
-{
-	return arg1 < arg2 ? arg1 : arg2;
-}
-
-unsigned int dcn_bw_max(const unsigned int arg1, const unsigned int arg2)
-{
-	return arg1 > arg2 ? arg1 : arg2;
-}
-float dcn_bw_max2(const float arg1, const float arg2)
-{
-	return arg1 > arg2 ? arg1 : arg2;
-}
-
 float dcn_bw_floor2(const float arg, const float significance)
 {
 	if (significance == 0)
@@ -59,16 +40,6 @@ float dcn_bw_ceil2(const float arg, const float significance)
 	return flr + 0.00001 >= arg ? arg : flr + significance;
 }
 
-float dcn_bw_max3(float v1, float v2, float v3)
-{
-	return v3 > dcn_bw_max2(v1, v2) ? v3 : dcn_bw_max2(v1, v2);
-}
-
-float dcn_bw_max5(float v1, float v2, float v3, float v4, float v5)
-{
-	return dcn_bw_max3(v1, v2, v3) > dcn_bw_max2(v4, v5) ? dcn_bw_max3(v1, v2, v3) : dcn_bw_max2(v4, v5);
-}
-
 float dcn_bw_pow(float a, float exp)
 {
 	float temp;
drivers/gpu/drm/amd/display/dc/calcs/dcn_calc_math.h +30 -6
index f46ab0e..6f66d9d 100644
@@ -26,14 +26,38 @@
 #ifndef _DCN_CALC_MATH_H_
 #define _DCN_CALC_MATH_H_
 
-float dcn_bw_mod(const float arg1, const float arg2);
-float dcn_bw_min2(const float arg1, const float arg2);
-unsigned int dcn_bw_max(const unsigned int arg1, const unsigned int arg2);
-float dcn_bw_max2(const float arg1, const float arg2);
+static inline float dcn_bw_mod(const float arg1, const float arg2)
+{
+	return arg1 - arg1 * ((int) (arg1 / arg2));
+}
+
+static inline float dcn_bw_min2(const float arg1, const float arg2)
+{
+	return arg1 < arg2 ? arg1 : arg2;
+}
+
+static inline unsigned int dcn_bw_max(const unsigned int arg1, const unsigned int arg2)
+{
+	return arg1 > arg2 ? arg1 : arg2;
+}
+
+static inline float dcn_bw_max2(const float arg1, const float arg2)
+{
+	return arg1 > arg2 ? arg1 : arg2;
+}
+
+static inline float dcn_bw_max3(float v1, float v2, float v3)
+{
+	return v3 > dcn_bw_max2(v1, v2) ? v3 : dcn_bw_max2(v1, v2);
+}
+
+static inline float dcn_bw_max5(float v1, float v2, float v3, float v4, float v5)
+{
+	return dcn_bw_max3(v1, v2, v3) > dcn_bw_max2(v4, v5) ? dcn_bw_max3(v1, v2, v3) : dcn_bw_max2(v4, v5);
+}
+
 float dcn_bw_floor2(const float arg, const float significance);
 float dcn_bw_ceil2(const float arg, const float significance);
-float dcn_bw_max3(float v1, float v2, float v3);
-float dcn_bw_max5(float v1, float v2, float v3, float v4, float v5);
 float dcn_bw_pow(float a, float exp);
 float dcn_bw_log(float a, float b);
 
Signature · 6 lines
2.9.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20170928004526.6770-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

PATCH 2/2 amdgpu/dc: inline a bunch of the dml wrappers.

From: Dave Airlie <[email protected]>

This reduces code size.

---
 .../drm/amd/display/dc/dml/display_mode_support.c  |  1 +
 .../drm/amd/display/dc/dml/display_rq_dlg_calc.c   |  2 +
 .../gpu/drm/amd/display/dc/dml/display_watermark.c |  1 +
 .../gpu/drm/amd/display/dc/dml/dml_common_defs.c   | 56 +-------------------
 .../gpu/drm/amd/display/dc/dml/dml_common_defs.h   | 11 ----
 .../gpu/drm/amd/display/dc/dml/dml_inline_defs.h   | 61 ++++++++++++++++++++++
 .../gpu/drm/amd/display/dc/dml/soc_bounding_box.c  |  1 +
 7 files changed, 67 insertions(+), 66 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/display/dc/dml/dml_inline_defs.h
drivers/gpu/drm/amd/display/dc/dml/display_mode_support.c +1 -0
index 3b4ee74..ac57356 100644
@@ -26,6 +26,7 @@
 #include "display_mode_support.h"
 #include "display_mode_lib.h"
 
+#include "dml_inline_defs.h"
 int dml_ms_check(
 		struct display_mode_lib *mode_lib,
 		struct _vcs_dpi_display_e2e_pipe_params_st *e2e,
drivers/gpu/drm/amd/display/dc/dml/display_rq_dlg_calc.c +2 -0
index 9fccbbf..7a5fb1c 100644
@@ -25,6 +25,8 @@
 #include "display_rq_dlg_calc.h"
 #include "display_mode_lib.h"
 
+#include "dml_inline_defs.h"
+
 static unsigned int get_bytes_per_element(enum source_format_class source_format, bool is_chroma)
 {
 	unsigned int ret_val = 0;
drivers/gpu/drm/amd/display/dc/dml/display_watermark.c +1 -0
index 390f093..142a328 100644
@@ -24,6 +24,7 @@
  */
 #include "display_watermark.h"
 #include "display_mode_lib.h"
+#include "dml_inline_defs.h"
 
 static void get_bytes_per_pixel(
 		enum source_format_class format,
drivers/gpu/drm/amd/display/dc/dml/dml_common_defs.c +1 -55

77 lines not on this page · raw message

drivers/gpu/drm/amd/display/dc/dml/dml_common_defs.h +0 -11
index c5340d4..c621f83 100644
@@ -32,20 +32,9 @@
 
 #define DTRACE(str, ...) dm_logger_write(mode_lib->logger, LOG_DML, str, ##__VA_ARGS__);
 
-double dml_min(double a, double b);
-double dml_max(double a, double b);
 bool dml_util_is_420(enum source_format_class sorce_format);
-double dml_ceil_ex(double x, double granularity);
-double dml_floor_ex(double x, double granularity);
-double dml_log(double x, double base);
-double dml_ceil(double a);
-double dml_floor(double a);
 double dml_round(double a);
-int dml_log2(double x);
-double dml_pow(double a, int exp);
 unsigned int dml_round_to_multiple(
 			unsigned int num, unsigned int multiple, bool up);
-double dml_fmod(double f, int val);
-double dml_ceil_2(double f);
 
 #endif /* __DC_COMMON_DEFS_H__ */
drivers/gpu/drm/amd/display/dc/dml/dml_inline_defs.h new file +61 -0

61 lines not on this page · raw message

drivers/gpu/drm/amd/display/dc/dml/soc_bounding_box.c +1 -0
index cb143d3..0745366 100644
@@ -25,6 +25,7 @@
 #include "soc_bounding_box.h"
 #include "display_mode_lib.h"
 
+#include "dml_inline_defs.h"
 void dml_socbb_set_latencies(
 		struct display_mode_lib *mode_lib,
 		struct _vcs_dpi_soc_bounding_box_st *from_box)
Signature · 6 lines
2.9.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx