Skip to contentSkip to conversation

drm/amdgpu: use designated initialiser for thermal_irq_src.

PATCH In review Dave Airlie 2 participants 2 messages Sep 28, 2017 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: use designated initialiser for thermal_irq_src.

From: Dave Airlie <[email protected]>

This fixes the 0-day build warning.

---
 drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c +3 -3
index 73969f3..35e80c9 100644
@@ -124,9 +124,9 @@ static int phm_ctf_irq(void *private_data,
 }
 
 static const struct cgs_irq_src_funcs thermal_irq_src[3] = {
-	{NULL, phm_thermal_l2h_irq},
-	{NULL, phm_thermal_h2l_irq},
-	{NULL, phm_ctf_irq}
+	{ .handler = phm_thermal_l2h_irq },
+	{ .handler = phm_thermal_h2l_irq },
+	{ .handler = phm_ctf_irq }
 };
 
 int hwmgr_early_init(struct pp_instance *handle)
Signature · 6 lines
2.9.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20170928061301.29353-1-airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

Reviewed-by
#2 lore raw
Quoted 5 lines · Dave Airlie

From: Dave Airlie <[email protected]>

This fixes the 0-day build warning.

Quoted 24 lines
---
 drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c +3 -4
index 73969f3..35e80c9 100644
@@ -124,9 +124,9 @@ static int phm_ctf_irq(void *private_data,
 }
 
 static const struct cgs_irq_src_funcs thermal_irq_src[3] = {
-       {NULL, phm_thermal_l2h_irq},
-       {NULL, phm_thermal_h2l_irq},
-       {NULL, phm_ctf_irq}
+       { .handler = phm_thermal_l2h_irq },
+       { .handler = phm_thermal_h2l_irq },
+       { .handler = phm_ctf_irq }
 };
 
 int hwmgr_early_init(struct pp_instance *handle)
--

2.9.4

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx