Staging: vc04_services: remove unused variables control and status
Subsystems (3)
PATCH 1/1 Staging: vc04_services: remove unused variables control and status
the volatile variables control, status are not
used. Delete them.
--- drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/vc04_services/bcm2835-audio/bcm2835.h +0 -2
@@ -123,8 +123,6 @@ struct bcm2835_alsa_stream {struct snd_pcm_indirect pcm_indirect;spinlock_t lock; -volatile unsigned int control; -volatile unsigned int status;int open;int running;
Signature · 1 line
2.7.4
Quoted 2 lines · Keerthi Reddy
the volatile variables control, status are not
used. Delete them.
It could be useful to give some information about how you have checked this. Simply compiling the directory might not be good enough, if there are uses under ifdefs. Grep could be a reasonable solution.
Also, I would say that these are fields rather than variables, as they are part of a structure rather than variables in a function.
julia
Quoted 29 lines
Signed-off-by Keerthi Reddy <[email protected]>--- drivers/staging/vc04_services/bcm2835-audio/bcm2835.h | 2 -- 1 file changed, 2 deletions(-)drivers/staging/vc04_services/bcm2835-audio/bcm2835.h +0
-3@@ -123,8 +123,6 @@ struct bcm2835_alsa_stream {struct snd_pcm_indirect pcm_indirect;spinlock_t lock; -volatile unsigned int control; -volatile unsigned int status;int open;int running; --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928084954.GA4170%40manoharreddy.
For more options, visit https://groups.google.com/d/optout.