iio: dummy: evgen: use irq_sim
PATCH v2 1/1 iio: dummy: evgen: use irq_sim
Switch to using the recently added interrupt simulator for dummy irqs.
---
bloat-o-meter output:
add/remove: 0/3 grow/shrink: 1/5 up/down: 12/-540 (-528)
function old new delta iio_dummy_evgen_get_irq 136 148 +12 iio_evgen_release 40 36 -4 iio_dummy_evgen_get_regs 32 28 -4 iio_dummy_work_handler 20 - -20 iio_dummy_event_irqunmask 32 - -32 iio_dummy_event_irqmask 32 - -32 iio_evgen_poke 140 100 -40 init_module 376 172 -204 iio_dummy_evgen_init 376 172 -204
Total: Before=2804, After=2276, chg -18.83%
v1 -> v2:
- added a missing kfree()
drivers/iio/dummy/Kconfig | 2 +- drivers/iio/dummy/iio_dummy_evgen.c | 89 ++++++++----------------------------- 2 files changed, 20 insertions(+), 71 deletions(-)
drivers/iio/dummy/Kconfig +1 -1
@@ -5,7 +5,7 @@ menu "IIO dummy driver" depends on IIO config IIO_DUMMY_EVGEN - select IRQ_WORK + select IRQ_SIM tristate config IIO_SIMPLE_DUMMY
drivers/iio/dummy/iio_dummy_evgen.c +19 -70
147 lines not on this page · raw message
Signature · 1 line
2.13.2
Quoted 3 lines · Bartosz Golaszewski
Switch to using the recently added interrupt simulator for dummy irqs.
Signed-off-by Bartosz Golaszewski <[email protected]>
I've backported irq_sim to v4.9 for testing and got compile errors due to a missing slab.h include. In upstream this include comes implicit through irq.h (coincidentally added by you), I wonder if we should still add it to irq_sim.c since it is explicitly using the allocation API.
2017-09-29 15:15 GMT+02:00 Lars-Peter Clausen <[email protected]>:
Quoted 5 lines · Bartosz Golaszewski
Quoted 3 lines
Switch to using the recently added interrupt simulator for dummy irqs.
Signed-off-by Bartosz Golaszewski <[email protected]>
Quoted 7 lines
Reviewed-by Lars-Peter Clausen <[email protected]>Tested-by Lars-Peter Clausen <[email protected]>I've backported
irq_simto v4.9 for testing and got compile errors due to a missingslab.hinclude. In upstream this include comes implicit throughirq.h(coincidentally added by you), I wonder if we should still add it toirq_sim.csince it is explicitly using the allocation API.
Thanks for the hint, I'll send it together with other updates (e.g. the reverse irq lookup).
Jonathan Cameron
maintainerQuoted 9 lines · On Fri, 29 Sep 2017 16:52:26 +0200 Bartosz Golaszewski <[email protected]> wrote:
2017-09-29 15:15 GMT+02:00 Lars-Peter Clausen <[email protected]>:
Quoted 8 lines · Bartosz Golaszewski
Quoted 3 lines
Switch to using the recently added interrupt simulator for dummy irqs.
Signed-off-by Bartosz Golaszewski <[email protected]>Reviewed-by Lars-Peter Clausen <[email protected]>Tested-by Lars-Peter Clausen <[email protected]>
Quoted 7 lines
Quoted 4 lines
I've backported
irq_simto v4.9 for testing and got compile errors due to a missingslab.hinclude. In upstream this include comes implicit throughirq.h(coincidentally added by you), I wonder if we should still add it toirq_sim.csince it is explicitly using the allocation API.Thanks for the hint, I'll send it together with other updates (e.g. the reverse irq lookup).
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
Quoted 4 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html