staging: vc04_services: Remove typedef struct

PATCH Superseded Mihaela Muraru 2 participants 2 messages Sep 28, 2017

Subsystems (2)

Staging Broadcom BCM2711/BCM2835 Arm architecture

lore

Share & tools

lore

Mihaela Muraru

author

2017-09-28 11:48 UTC #0 lore raw

PATCH v2 1/1 staging: vc04_services: Remove typedef struct

This patch removes typedef from struct and renames it from "typedef struct vchiq_2835_state_struct" to "struct vchiq_2835_state" as per kernel coding standards.

Signed-off-by Mihaela Muraru <[email protected]>

---
Changes in v2:
- rewrite log message to have less than 70 characters per line.

---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
 1 file changed, 1 deletion(-)

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -1

index ee00f51..a96bae0 100644
@@ -84,7 +84,6 @@ static char *g_free_fragments;
 static struct semaphore g_free_fragments_sema;
 static struct device *g_dev;
 
-
 static DEFINE_SEMAPHORE(g_free_fragments_mutex);
 
 static irqreturn_t

Signature · 1 line

2.7.4

Julia Lawall

2017-09-28 12:14 UTC #1 lore raw

Quoted 18 lines · Mihaela Muraru

This patch removes typedef from struct and renames it from "typedef struct vchiq_2835_state_struct" to "struct vchiq_2835_state" as per kernel coding standards.
Signed-off-by Mihaela Muraru <[email protected]>
---
Changes in v2:
- rewrite log message to have less than 70 characters per line.
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -0
index ee00f51..a96bae0 100644

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c static char *g_free_fragments; · line 87

Quoted 4 lines

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -1
@@ -84,7 +84,6 @@ static char *g_free_fragments;
 static struct semaphore g_free_fragments_sema;
 static struct device *g_dev;
 
-

Something went wrong. The patch just removes a blank line. Remember to start from the original version of the code when you send a patch, and not from the result of your previous patch.

julia

Quoted 13 lines

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c +0 -1
 static DEFINE_SEMAPHORE(g_free_fragments_mutex);
 
 static irqreturn_t
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928114830.GA12488%40ubuntu.
For more options, visit https://groups.google.com/d/optout.