Staging: speakup: replace 'S_IRUGO' macro with octal 0444

PATCH Superseded Keerthi Reddy 3 participants 3 messages Sep 28, 2017 – Sep 29, 2017 Staging

lore

Share & tools

lore

Keerthi Reddy

author

2017-09-28 15:38 UTC #0 lore raw

PATCH 1/1 Staging: speakup: replace 'S_IRUGO' macro with octal 0444

Everyone knows what 0444 means. But one has read through docs to understand the meaning of 'S_IRUGO'.

Signed-off-by Keerthi Reddy <[email protected]>

---
 drivers/staging/speakup/speakup_apollo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/speakup/speakup_apollo.c +1 -1

index 2edb56c..dcf0c3b 100644
@@ -200,7 +200,7 @@ static void do_catch_up(struct spk_synth *synth)
 }
 
 module_param_named(ser, synth_apollo.ser, int, 0444);
-module_param_named(dev, synth_apollo.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_apollo.dev_name, charp, 0444);
 module_param_named(start, synth_apollo.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");

Signature · 1 line

2.7.4

Samuel Thibault

2017-09-28 23:19 UTC #1 lore raw

Hello,

Quoted 2 lines · Keerthi Reddy, on jeu. 28 sept. 2017 21:08:26 +0530, wrote:

Everyone knows what 0444 means. But one has read through docs to understand the meaning of 'S_IRUGO'.

Yes. Could you do the same on all files of the
drivers/staging/speakup/ directory altogether?

Thanks,
Samuel

Greg KH

2017-09-29 13:29 UTC #2 lore raw

In reply to Keerthi Reddy

Quoted 7 lines · Keerthi Reddy

Everyone knows what 0444 means. But one has read through docs to understand the meaning of 'S_IRUGO'.
Signed-off-by Keerthi Reddy <[email protected]>
---
 drivers/staging/speakup/speakup_apollo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

This change is already in my tree, please make sure you work against the correct kenel tree/branch.

thanks,

greg k-h