lib: Fix igt_sysfs_set_u32 return value
PATCH 1/1 lib: Fix igt_sysfs_set_u32 return value
From: Tvrtko Ursulin <[email protected]>
Printf family functions return a number of bytes, not tokens, printed so the existing check (== 1) was wrong.
--- lib/igt_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/igt_sysfs.c +1 -1
@@ -463,7 +463,7 @@ uint32_t igt_sysfs_get_u32(int dir, const char *attr)*/ bool igt_sysfs_set_u32 (int dir,const char *attr,uint32_t value) { -return igt_sysfs_printf (dir, attr,"%u" , value) ==1 ; +return igt_sysfs_printf (dir, attr,"%u" , value) >0 ; }/**
Signature · 6 lines
2.9.5 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2017-09-29 12:29:49)
Quoted 4 lines
From: Tvrtko Ursulin <[email protected]>
Printf family functions return a number of bytes, not tokens, printed so the existing check (== 1) was wrong.
Oops, copied from scanf without thinking.
Quoted 1 line
Signed-off-by Tvrtko Ursulin <[email protected]>
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for lib: Fix igt_sysfs_set_u32 return value
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: lib: Fix igt_sysfs_set_u32 return value
URL : https://patchwork.freedesktop.org/series/31166/
State : success
== Summary ==
IGT patchset tested on top of latest successful build cf3e683a3650c18c89a3322c4171e1db94b5b9f8 igt/gem_exec_nop: Measure high-priority throughput over a bg load
with latest DRM-Tip kernel build CI_DRM_3156496f1cf87464 drm-tip: 2017y-09m-29d-10h-50m-53s UTC integration manifest
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> PASS (fi-kbl-7560u)fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:444s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:478s fi-blb-e6850 total:289 pass:224 dwarn:1 dfail:0 fail:0 skip:64 time:419s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:529s fi-bwr-2160 total:289 pass:184 dwarn:0 dfail:0 fail:0 skip:105 time:281s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:500s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:519s fi-byt-j1900 total:289 pass:254 dwarn:1 dfail:0 fail:0 skip:34 time:503s fi-byt-n2820 total:289 pass:250 dwarn:1 dfail:0 fail:0 skip:38 time:492s fi-cfl-s total:289 pass:256 dwarn:1 dfail:0 fail:0 skip:32 time:572s fi-cnl-y total:289 pass:261 dwarn:1 dfail:0 fail:0 skip:27 time:667s fi-elk-e7500 total:289 pass:230 dwarn:0 dfail:0 fail:0 skip:59 time:413s fi-glk-1 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:570s fi-hsw-4770 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:426s fi-hsw-4770r total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:405s fi-ilk-650 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:433s fi-ivb-3520m total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:491s fi-ivb-3770 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:467s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:477s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:582s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:592s fi-pnv-d510 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:544s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:454s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:495s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:478s fi-snb-2520m total:289 pass:251 dwarn:0 dfail:0 fail:0 skip:38 time:576s fi-snb-2600 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:429s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_276/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.IGT: warning for lib: Fix igt_sysfs_set_u32 return value
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: lib: Fix igt_sysfs_set_u32 return value
URL : https://patchwork.freedesktop.org/series/31166/
State : warning
== Summary ==
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test perf:
Subgroup blocking:
pass -> FAIL (shard-hsw) fdo#102252 +1
Test gem_eio:
Subgroup in-flight-external:
dmesg-warn -> PASS (shard-hsw) fdo#102886
Test prime_mmap:
Subgroup test_userptr:
pass -> DMESG-WARN (shard-hsw) fdo#102939
Test kms_universal_plane:
Subgroup disable-primary-vs-flip-pipe-A:
pass -> SKIP (shard-hsw)
Test kms_busy:
Subgroup extended-modeset-hang-oldfb-with-reset-render-B:
pass -> SKIP (shard-hsw) fdo#102249
Test kms_flip:
Subgroup flip-vs-absolute-wf_vblank-interruptible:
fail -> PASS (shard-hsw)fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886
fdo#102939 https://bugs.freedesktop.org/show_bug.cgi?id=102939
fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
shard-hsw total:2429 pass:1331 dwarn:3 dfail:0 fail:10 skip:1085 time:9982s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_276/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx