utimensat_tests.sh: returns EPERM above 4.4.27 and below 4.5.0

From: Naresh Kamboju <[email protected]>

Test utimensat failed on 4.4 is due to expected error is EACCES but got EPERM.

With the reference to backported patch changing the test code to set error code EPERM when kernel version is above 4.4.27 and below 4.5.0

The patch backported on 4.4 details
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
branch: v4.4.27
commit id: b3b4283
vfs: move permission checking into notify_change() for utimes(NULL)

Bug reported on this case,
LKFT: linux-stable-4.4: LTP utimensat01 failed-EXPECTED: EACCES but got EPERM
https://bugs.linaro.org/show_bug.cgi?id=3142

Signed-off-by Naresh Kamboju <[email protected]>

---
 testcases/kernel/syscalls/utimensat/utimensat_tests.sh | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

testcases/kernel/syscalls/utimensat/utimensat_tests.sh +5 -2

index 48154d6..46a0cc6 100755
@@ -32,7 +32,11 @@ fi
 
 # Starting with 4.8.0 operations on immutable files return EPERM instead of
 # EACCES.
-if tst_kvcmp -lt "4.8.0"; then
+# This patch has also been merged to stable 4.4 with
+# b3b4283 ("vfs: move permission checking into notify_change() for utimes(NULL)")
+if tst_kvcmp -ge "4.4.27" -a -lt "4.5.0"; then
+       imaccess=EPERM
+elif tst_kvcmp -lt "4.4.27"; then
        imaccess=EACCES
 else
        imaccess=EPERM
--

2.7.4

Hi!
Jan: Since you suggested to go this way should I commit this with your
Suggested-by: or Signed-off-by: ? Or will you do that yourself?

Hi!
Great thanks for pushing it.

Now the only patch to consider is the v2 for controllers/cpuset I've send yesterday. I'm kind of undecided, it fixes the main issue, but oncovers a bunch of smaller ones for me. The cpuset_sched_domain, cpuset_load_balance, cpuset_memory and cpuset_memory_pressure fail for me.

Have you tried that patch? Does it work for you?

Quoted 7 lines

Now the only patch to consider is the v2 for controllers/cpuset I've send yesterday. I'm kind of undecided, it fixes the main issue, but oncovers a bunch of smaller ones for me. The cpuset_sched_domain, cpuset_load_balance, cpuset_memory and cpuset_memory_pressure fail for me.

Have you tried that patch? Does it work for you?

I think I tried v1 (very long time ago) on 3.10 kernel (RHEL7), and I recall 1 or 2 failures, but that was unrelated to patch.