lbase64: fix build
PATCH 1/1 lbase64: fix build
see http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/
--- package/lbase64/lbase64.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/lbase64/lbase64.mk +2 -1
@@ -12,7 +12,8 @@ LBASE64_LICENSE_FILES = README LBASE64_DEPENDENCIES = luainterpreter define LBASE64_BUILD_CMDS - $(MAKE1) $(TARGET_CONFIGURE_OPTS) -C $(@D) so + $(MAKE1) $(TARGET_CONFIGURE_OPTS) \ + CFLAGS="$(TARGET_CFLAGS) -fPIC" -C $(@D) so endef define LBASE64_INSTALL_TARGET_CMDS
Signature · 1 line
2.11.0
PATCH 1/1 lbase64: fix build
Hello,
Quoted 3 lines · Francois Perrad
see http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/
Signed-off-by Francois Perrad <[email protected]>
Come on, "fix build" is really, really too short of a commit log. Please extend this commit log with a decent explanation.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 lbase64: fix build
2017-09-29 21:52 GMT+02:00 Thomas Petazzoni <
[email protected]>:
Quoted 12 lines
Hello,
Quoted 1 line · Francois Perrad
b567096cbfdb89b1895924051265c56204ffb512/
Quoted 2 lines
Signed-off-by Francois Perrad <[email protected]>Come on, "fix build" is really, really too short of a commit log. Please extend this commit log with a decent explanation.
There are 3 useful words in
http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/build-end.log
:
"recompile with -fPIC"
Fran?ois
Quoted 12 lines
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170930/c262e0b0/attachment.html>
PATCH 1/1 lbase64: fix build
Hello,
Quoted 4 lines · Fran?ois Perrad
There are 3 useful words in
http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/build-end.log
:
"recompile with -fPIC"
Still, please write better commit logs.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 lbase64: fix build
In reply to Francois PerradQuoted 3 lines · Francois Perrad
see http://autobuild.buildroot.net/results/b56/b567096cbfdb89b1895924051265c56204ffb512/
Signed-off-by Francois Perrad <[email protected]>
I added a commit message and applied to master, thanks.
However, wouldn't an upstreamable patch have been better?
Regards,
Arnout
Quoted 19 lines
--- package/lbase64/lbase64.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/lbase64/lbase64.mk +2
-1@@ -12,7 +12,8 @@ LBASE64_LICENSE_FILES = README LBASE64_DEPENDENCIES = luainterpreter define LBASE64_BUILD_CMDS - $(MAKE1) $(TARGET_CONFIGURE_OPTS) -C $(@D) so + $(MAKE1) $(TARGET_CONFIGURE_OPTS) \ + CFLAGS="$(TARGET_CFLAGS) -fPIC" -C $(@D) so endef define LBASE64_INSTALL_TARGET_CMDS
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF