Skip to contentSkip to conversation

i40iw: delete some stray tabs

PATCH Applied Dan Carpenter 4 participants 8 messages Sep 29, 2017 – Sep 30, 2017 1 message not in the archive

Subsystems (2)
Kernel janitors InfiniBand
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 i40iw: delete some stray tabs

These lines were indented too far by mistake.

Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/i40iw/i40iw_cm.c +2 -2
index 5230dd3c938c..9017c1cc51d4 100644
@@ -1524,8 +1524,8 @@ static bool i40iw_port_in_use(struct i40iw_cm_core *cm_core, u16 port, bool acti
 				break;
 			}
 		}
-			if (!ret)
-				clear_bit(port, cm_core->active_side_ports);
+		if (!ret)
+			clear_bit(port, cm_core->active_side_ports);
 		spin_unlock_irqrestore(&cm_core->ht_lock, flags);
 	} else {
 		spin_lock_irqsave(&cm_core->listen_list_lock, flags);
Reviewed-by on v1 1/1
#1 lore raw

drivers/infiniband/hw/i40iw/i40iw_cm.c

Quoted 5 lines · Dan Carpenter

These lines were indented too far by mistake.

Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/i40iw/i40iw_cm.c +0 -0

Dan,,

I saw in your patches and don't know if it important. There is no diffstat after your Signed-off-by and there is no "---" trailing line too.

Thanks,

Reviewed-by Leon Romanovsky <[email protected]>
author
#2 lore raw
Quoted 5 lines · Leon Romanovsky
Quoted 4 lines · Dan Carpenter

These lines were indented too far by mistake.

Signed-off-by Dan Carpenter <[email protected]>
Quoted 7 lines

drivers/infiniband/hw/i40iw/i40iw_cm.c

Quoted 1 line
drivers/infiniband/hw/i40iw/i40iw_cm.c +0 -0

Dan,,

I saw in your patches and don't know if it important. There is no diffstat after your Signed-off-by and there is no "---" trailing line too.

Yeah. I leave those out. I normally write two line patches like this one so the diffstat is normally -2+2 and I figure people will see that they're tiny just from glancing at the email. When I create patches that touch multiple files, what I do is just merge the diffs together in my email client. If I tried to create diffstats for those, I'd just end up messing up a lot.

regards,
dan carpenter

#3 lore raw
Quoted 14 lines · Dan Carpenter
Quoted 5 lines · Leon Romanovsky
Quoted 4 lines · Dan Carpenter

These lines were indented too far by mistake.

Signed-off-by Dan Carpenter <[email protected]>
Quoted 7 lines

drivers/infiniband/hw/i40iw/i40iw_cm.c

Quoted 1 line
drivers/infiniband/hw/i40iw/i40iw_cm.c +0 -0

Dan,,

I saw in your patches and don't know if it important. There is no diffstat after your Signed-off-by and there is no "---" trailing line too.

Quoted 6 lines

Yeah. I leave those out. I normally write two line patches like this one so the diffstat is normally -2+2 and I figure people will see that they're tiny just from glancing at the email. When I create patches that touch multiple files, what I do is just merge the diffs together in my email client. If I tried to create diffstats for those, I'd just end up messing up a lot.

What are the benefits avoiding them?

I personally want to see them without and conditions, for two reasons:
1. It helps me to see the scope of the change.
2. It allows me to simply copy/paste the name to the editor without need to remove "a/" or "b/" from the "diff --git" line.

Thanks

Quoted 4 lines

regards,
dan carpenter

A message that is not in the archive (sent off-list or not yet received): 20170929144554.GB2965-U/[email protected]

author
#5 lore raw
Quoted 15 lines · Leon Romanovsky
Quoted 14 lines · Dan Carpenter
Quoted 12 lines · Leon Romanovsky

drivers/infiniband/hw/i40iw/i40iw_cm.c

Quoted 5 lines · Dan Carpenter

These lines were indented too far by mistake.

Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/i40iw/i40iw_cm.c +0 -0

Dan,,

I saw in your patches and don't know if it important. There is no diffstat after your Signed-off-by and there is no "---" trailing line too.

Quoted 9 lines
Quoted 6 lines

Yeah. I leave those out. I normally write two line patches like this one so the diffstat is normally -2+2 and I figure people will see that they're tiny just from glancing at the email. When I create patches that touch multiple files, what I do is just merge the diffs together in my email client. If I tried to create diffstats for those, I'd just end up messing up a lot.

What are the benefits avoiding them?

The way I develop the kernel is way different from how other people do and different from how I develop Smatch. I've spent 9 years tweaking my scripts to make it work for me. Please don't force me to use git commit... :(

regards,
dan carpenter

#6 lore raw
Quoted 23 lines · Dan Carpenter
Quoted 22 lines · Leon Romanovsky
Quoted 20 lines · Dan Carpenter
Quoted 5 lines · Leon Romanovsky
Quoted 4 lines · Dan Carpenter

These lines were indented too far by mistake.

Signed-off-by Dan Carpenter <[email protected]>
Quoted 7 lines

drivers/infiniband/hw/i40iw/i40iw_cm.c

Quoted 1 line
drivers/infiniband/hw/i40iw/i40iw_cm.c +0 -0

Dan,,

I saw in your patches and don't know if it important. There is no diffstat after your Signed-off-by and there is no "---" trailing line too.

Yeah. I leave those out. I normally write two line patches like this one so the diffstat is normally -2+2 and I figure people will see that they're tiny just from glancing at the email. When I create patches that touch multiple files, what I do is just merge the diffs together in my email client. If I tried to create diffstats for those, I'd just end up messing up a lot.

Quoted 7 lines
Quoted 2 lines

What are the benefits avoiding them?

The way I develop the kernel is way different from how other people do and different from how I develop Smatch. I've spent 9 years tweaking my scripts to make it work for me. Please don't force me to use git commit... :(

I had no intentions to do so.

Quoted 5 lines

regards,
dan carpenter

Acked-by on v1 1/1
#7 lore raw
In reply to Dan Carpenter
Quoted 10 lines · Dan Carpenter

These lines were indented too far by mistake.

Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/i40iw/i40iw_cm.c +0 -0
index 5230dd3c938c..9017c1cc51d4 100644
@@ -1524,8 +1524,8 @@ static bool i40iw_port_in_use(struct i40iw_cm_core *cm_core, u16 port, bool acti
 				break;

drivers/infiniband/hw/i40iw/i40iw_cm.c static bool i40iw_port_in_use(struct i40iw_cm_core *cm_core, u16 port, bool acti

Quoted 10 lines
drivers/infiniband/hw/i40iw/i40iw_cm.c +2 -3
 			}
 		}
-			if (!ret)
-				clear_bit(port, cm_core->active_side_ports);
+		if (!ret)
+			clear_bit(port, cm_core->active_side_ports);
 		spin_unlock_irqrestore(&cm_core->ht_lock, flags);
 	} else {
 		spin_lock_irqsave(&cm_core->listen_list_lock, flags);
--

Thanks Dan!

Acked-by Shiraz Saleem <[email protected]>