Skip to contentSkip to conversation

report: fix summary statistics in xUnit header

PATCH New Theodore Ts'o 1 participant 1 message Oct 2, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 report: fix summary statistics in xUnit header

The xUnit XML DTD distinguishes between test failures and test errors, where a test failure indicate that the test has explicitly indicated that the code under test has behaved in an unexpected fashion, whereas a test error indicates the test code itself has thrown an error or there has been some other test implementation error.

Xfstest failures are correctly marked as xUnit failures, but in the attributes of the testsuite XML element, the number of test failures was incorrectly reported as the number of errors.

Cc Dmitry Monakhov <[email protected]>
---
 common/report | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/report +1 -1
index bb689836..058c0bba 100644
@@ -59,7 +59,7 @@ _xunit_make_section_report()
 	# Header
 	echo "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" > $REPORT_DIR/result.xml
 	local dtime=`echo $date_time| tr  " " 'T'`
-	local stats="errors=\"$n_bad\" skipped=\"$n_notrun\" tests=\"$n_total\" time=\"$sect_time\""
+	local stats="failures=\"$n_bad\" skipped=\"$n_notrun\" tests=\"$n_total\" time=\"$sect_time\""
 	local hw_info="hostname=\"$HOST\" timestamp=\"$dtime\" "
 	echo "<testsuite name=\"xfstests\" $stats  $hw_info >" >> $REPORT_DIR/result.xml
 
Signature · 1 line
2.11.0.rc0.7.gbe5a750