Skip to contentSkip to conversation

staging: rts5208: use usleep_range instead of udelay

PATCH In review Keerthi Reddy 2 participants 2 messages Oct 2, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rts5208: use usleep_range instead of udelay

Since a its a slow device, allow a small range of 100

---
 drivers/staging/rts5208/rtsx_card.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rts5208/rtsx_card.c +2 -2
index a6b7bff..418e29d 100644
@@ -825,7 +825,7 @@ int switch_normal_clock(struct rtsx_chip *chip, int clk)
 	}
 
 	if (sd_vpclk_phase_reset) {
-		udelay(200);
+		usleep_range(200, 300);
 		retval = rtsx_write_register(chip, SD_VPCLK0_CTL,
 					     PHASE_NOT_RESET, PHASE_NOT_RESET);
 		if (retval) {
@@ -838,7 +838,7 @@ int switch_normal_clock(struct rtsx_chip *chip, int clk)
 			rtsx_trace(chip);
 			return retval;
 		}
-		udelay(200);
+		usleep_range(200, 300);
 	}
 	retval = rtsx_write_register(chip, CLK_CTL, 0xFF, 0);
 	if (retval) {
Signature · 1 line
2.7.4
#1 lore raw
Quoted 1 line · Keerthi Reddy

Since a its a slow device, allow a small range of 100

How do you know that it is a slow device?

Try to make the commit log message more self contained, not a continuation of the subject line, and use the imperative.

julia

Quoted 38 lines
---
 drivers/staging/rts5208/rtsx_card.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rts5208/rtsx_card.c +2 -3
index a6b7bff..418e29d 100644
@@ -825,7 +825,7 @@ int switch_normal_clock(struct rtsx_chip *chip, int clk)
 	}
 
 	if (sd_vpclk_phase_reset) {
-		udelay(200);
+		usleep_range(200, 300);
 		retval = rtsx_write_register(chip, SD_VPCLK0_CTL,
 					     PHASE_NOT_RESET, PHASE_NOT_RESET);
 		if (retval) {
@@ -838,7 +838,7 @@ int switch_normal_clock(struct rtsx_chip *chip, int clk)
 			rtsx_trace(chip);
 			return retval;
 		}
-		udelay(200);
+		usleep_range(200, 300);
 	}
 	retval = rtsx_write_register(chip, CLK_CTL, 0xFF, 0);
 	if (retval) {
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20171002114322.GA8908%40manoharreddy.
For more options, visit https://groups.google.com/d/optout.