staging: lustre: use BIT macro

PATCH Superseded Keerthi Reddy 2 participants 4 messages Oct 2, 2017 Staging

lore

Share & tools

lore

Keerthi Reddy

author

2017-10-02 13:10 UTC #0 lore raw

PATCH 1/1 staging: lustre: use BIT macro

This commit changes changes left shift operator to use BIT macro

Signed-off-by Keerthi Reddy <[email protected]>

---
 .../staging/lustre/include/linux/lnet/lib-types.h  | 26 +++++++++++-----------
 1 file changed, 13 insertions(+), 13 deletions(-)

drivers/staging/lustre/include/linux/lnet/lib-types.h +13 ~~-13~~

index eea3b8e..15837a3 100644
@@ -160,9 +160,9 @@ struct lnet_libmd {
 	} md_iov;
 };
 
-#define LNET_MD_FLAG_ZOMBIE		(1 << 0)
-#define LNET_MD_FLAG_AUTO_UNLINK	(1 << 1)
-#define LNET_MD_FLAG_ABORTED		(1 << 2)
+#define LNET_MD_FLAG_ZOMBIE		BIT(0)
+#define LNET_MD_FLAG_AUTO_UNLINK	BIT(1)
+#define LNET_MD_FLAG_ABORTED		BIT(2)
 
 struct lnet_test_peer {
 	/* info about peers we are trying to fail */

@@ -287,9 +287,9 @@ struct lnet_ni {
  * of old LNet, so there shouldn't be any compatibility issue
  */
 #define LNET_PING_FEAT_INVAL		(0)		/* no feature */
-#define LNET_PING_FEAT_BASE		(1 << 0)	/* just a ping */
-#define LNET_PING_FEAT_NI_STATUS	(1 << 1)	/* return NI status */
-#define LNET_PING_FEAT_RTE_DISABLED	(1 << 2)	/* Routing enabled */
+#define LNET_PING_FEAT_BASE		BIT(0)	/* just a ping */
+#define LNET_PING_FEAT_NI_STATUS	BIT(1)	/* return NI status */
+#define LNET_PING_FEAT_RTE_DISABLED	BIT(2)	/* Routing enabled */
 
 #define LNET_PING_FEAT_MASK		(LNET_PING_FEAT_BASE | \
 					 LNET_PING_FEAT_NI_STATUS)

@@ -440,21 +440,21 @@ struct lnet_rtrbuf {
 
 enum lnet_match_flags {
 	/* Didn't match anything */
-	LNET_MATCHMD_NONE	= (1 << 0),
+	LNET_MATCHMD_NONE	= BIT(0),
 	/* Matched OK */
-	LNET_MATCHMD_OK		= (1 << 1),
+	LNET_MATCHMD_OK		= BIT(1),
 	/* Must be discarded */
-	LNET_MATCHMD_DROP	= (1 << 2),
+	LNET_MATCHMD_DROP	= BIT(2),
 	/* match and buffer is exhausted */
-	LNET_MATCHMD_EXHAUSTED	= (1 << 3),
+	LNET_MATCHMD_EXHAUSTED	= BIT(3),
 	/* match or drop */
 	LNET_MATCHMD_FINISH	= (LNET_MATCHMD_OK | LNET_MATCHMD_DROP),
 };
 
 /* Options for lnet_portal::ptl_options */
-#define LNET_PTL_LAZY		(1 << 0)
-#define LNET_PTL_MATCH_UNIQUE	(1 << 1)	/* unique match, for RDMA */
-#define LNET_PTL_MATCH_WILDCARD	(1 << 2)	/* wildcard match,
+#define LNET_PTL_LAZY		BIT(0)
+#define LNET_PTL_MATCH_UNIQUE	BIT(1)	/* unique match, for RDMA */
+#define LNET_PTL_MATCH_WILDCARD	BIT(2)	/* wildcard match,
 						 * request portal
 						 */

Signature · 1 line

2.7.4

Julia Lawall

2017-10-02 13:15 UTC #1 lore raw

Quoted 55 lines · Keerthi Reddy

This commit changes changes left shift operator to use BIT macro

Signed-off-by Keerthi Reddy <[email protected]>

---
 .../staging/lustre/include/linux/lnet/lib-types.h  | 26 +++++++++++-----------
 1 file changed, 13 insertions(+), 13 deletions(-)

drivers/staging/lustre/include/linux/lnet/lib-types.h +10 ~~-10~~

index eea3b8e..15837a3 100644
@@ -160,9 +160,9 @@ struct lnet_libmd {
 	} md_iov;
 };
 
-#define LNET_MD_FLAG_ZOMBIE		(1 << 0)
-#define LNET_MD_FLAG_AUTO_UNLINK	(1 << 1)
-#define LNET_MD_FLAG_ABORTED		(1 << 2)
+#define LNET_MD_FLAG_ZOMBIE		BIT(0)
+#define LNET_MD_FLAG_AUTO_UNLINK	BIT(1)
+#define LNET_MD_FLAG_ABORTED		BIT(2)
 
 struct lnet_test_peer {
 	/* info about peers we are trying to fail */

@@ -287,9 +287,9 @@ struct lnet_ni {
  * of old LNet, so there shouldn't be any compatibility issue
  */
 #define LNET_PING_FEAT_INVAL		(0)		/* no feature */
-#define LNET_PING_FEAT_BASE		(1 << 0)	/* just a ping */
-#define LNET_PING_FEAT_NI_STATUS	(1 << 1)	/* return NI status */
-#define LNET_PING_FEAT_RTE_DISABLED	(1 << 2)	/* Routing enabled */
+#define LNET_PING_FEAT_BASE		BIT(0)	/* just a ping */
+#define LNET_PING_FEAT_NI_STATUS	BIT(1)	/* return NI status */
+#define LNET_PING_FEAT_RTE_DISABLED	BIT(2)	/* Routing enabled */
 
 #define LNET_PING_FEAT_MASK		(LNET_PING_FEAT_BASE | \
 					 LNET_PING_FEAT_NI_STATUS)

@@ -440,21 +440,21 @@ struct lnet_rtrbuf {
 
 enum lnet_match_flags {
 	/* Didn't match anything */
-	LNET_MATCHMD_NONE	= (1 << 0),
+	LNET_MATCHMD_NONE	= BIT(0),
 	/* Matched OK */
-	LNET_MATCHMD_OK		= (1 << 1),
+	LNET_MATCHMD_OK		= BIT(1),
 	/* Must be discarded */
-	LNET_MATCHMD_DROP	= (1 << 2),
+	LNET_MATCHMD_DROP	= BIT(2),
 	/* match and buffer is exhausted */
-	LNET_MATCHMD_EXHAUSTED	= (1 << 3),
+	LNET_MATCHMD_EXHAUSTED	= BIT(3),
 	/* match or drop */
 	LNET_MATCHMD_FINISH	= (LNET_MATCHMD_OK | LNET_MATCHMD_DROP),
 };

drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_rtrbuf { · line 459

Quoted 10 lines

drivers/staging/lustre/include/linux/lnet/lib-types.h +3 -3

 
 /* Options for lnet_portal::ptl_options */
-#define LNET_PTL_LAZY		(1 << 0)
-#define LNET_PTL_MATCH_UNIQUE	(1 << 1)	/* unique match, for RDMA */
-#define LNET_PTL_MATCH_WILDCARD	(1 << 2)	/* wildcard match,
+#define LNET_PTL_LAZY		BIT(0)
+#define LNET_PTL_MATCH_UNIQUE	BIT(1)	/* unique match, for RDMA */
+#define LNET_PTL_MATCH_WILDCARD	BIT(2)	/* wildcard match,
 						 * request portal
 						 */

It looks like the final comment could be on only one line?

julia

Quoted 11 lines

drivers/staging/lustre/include/linux/lnet/lib-types.h +0 -1
--
2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20171002131042.GA12477%40manoharreddy.
For more options, visit https://groups.google.com/d/optout.

Keerthi Reddy

author

2017-10-02 13:36 UTC #2 lore raw

Quoted 77 lines · Julia Lawall

Quoted 5 lines · Keerthi Reddy
This commit changes changes left shift operator to use BIT macro
Signed-off-by Keerthi Reddy <[email protected] <javascript:>>
---
 .../staging/lustre/include/linux/lnet/lib-types.h  | 26 
+++++++++++-----------
Review
Quoted 3 lines
 1 file changed, 13 insertions(+), 13 deletions(-) 
(quoted diff) +0 -0
b/drivers/staging/lustre/include/linux/lnet/lib-types.h
Quoted 17 lines
index eea3b8e..15837a3 100644
drivers/staging/lustre/include/linux/lnet/lib-types.h +3 -3
@@ -160,9 +160,9 @@ struct lnet_libmd { 
         } md_iov; 
 }; 
 
-#define LNET_MD_FLAG_ZOMBIE                (1 << 0) 
-#define LNET_MD_FLAG_AUTO_UNLINK        (1 << 1) 
-#define LNET_MD_FLAG_ABORTED                (1 << 2) 
+#define LNET_MD_FLAG_ZOMBIE                BIT(0) 
+#define LNET_MD_FLAG_AUTO_UNLINK        BIT(1) 
+#define LNET_MD_FLAG_ABORTED                BIT(2) 
 
 struct lnet_test_peer { 
         /* info about peers we are trying to fail */ 
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_ni { · line 289
Quoted 3 lines
drivers/staging/lustre/include/linux/lnet/lib-types.h +0 -0
@@ -287,9 +287,9 @@ struct lnet_ni { 
  * of old LNet, so there shouldn't be any compatibility issue 
  */ 
 #define LNET_PING_FEAT_INVAL                (0)                /* no 
feature */
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_ni { · line 290
Quoted 1 line
drivers/staging/lustre/include/linux/lnet/lib-types.h +0 -1
-#define LNET_PING_FEAT_BASE                (1 << 0)        /* just a 
ping */
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_ni { · line 291
Quoted 1 line
drivers/staging/lustre/include/linux/lnet/lib-types.h +0 -1
-#define LNET_PING_FEAT_NI_STATUS        (1 << 1)        /* return NI 
status */
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_ni { · line 292
Quoted 1 line
drivers/staging/lustre/include/linux/lnet/lib-types.h +0 -1
-#define LNET_PING_FEAT_RTE_DISABLED        (1 << 2)        /* Routing 
enabled */
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_ni { · line 290
Quoted 1 line
drivers/staging/lustre/include/linux/lnet/lib-types.h +1 -0
+#define LNET_PING_FEAT_BASE                BIT(0)        /* just a ping 
*/
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_ni { · line 291
Quoted 1 line
drivers/staging/lustre/include/linux/lnet/lib-types.h +1 -0
+#define LNET_PING_FEAT_NI_STATUS        BIT(1)        /* return NI 
status */
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_ni { · line 292
Quoted 1 line
drivers/staging/lustre/include/linux/lnet/lib-types.h +1 -0
+#define LNET_PING_FEAT_RTE_DISABLED        BIT(2)        /* Routing 
enabled */
Quoted 10 lines
drivers/staging/lustre/include/linux/lnet/lib-types.h +1 -1
 #define LNET_PING_FEAT_MASK                (LNET_PING_FEAT_BASE | \ 
                                          LNET_PING_FEAT_NI_STATUS) 
@@ -440,21 +440,21 @@ struct lnet_rtrbuf { 
 
 enum lnet_match_flags { 
         /* Didn't match anything */ 
-        LNET_MATCHMD_NONE        = (1 << 0), 
+        LNET_MATCHMD_NONE        = BIT(0), 
         /* Matched OK */ 
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_rtrbuf { · line 451
Quoted 10 lines
drivers/staging/lustre/include/linux/lnet/lib-types.h +3 -3
-        LNET_MATCHMD_OK                = (1 << 1), 
+        LNET_MATCHMD_OK                = BIT(1), 
         /* Must be discarded */ 
-        LNET_MATCHMD_DROP        = (1 << 2), 
+        LNET_MATCHMD_DROP        = BIT(2), 
         /* match and buffer is exhausted */ 
-        LNET_MATCHMD_EXHAUSTED        = (1 << 3), 
+        LNET_MATCHMD_EXHAUSTED        = BIT(3), 
         /* match or drop */ 
         LNET_MATCHMD_FINISH        = (LNET_MATCHMD_OK | 
LNET_MATCHMD_DROP),
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_rtrbuf {
Quoted 5 lines
drivers/staging/lustre/include/linux/lnet/lib-types.h +0 -2
 }; 
 
 /* Options for lnet_portal::ptl_options */ 
-#define LNET_PTL_LAZY                (1 << 0) 
-#define LNET_PTL_MATCH_UNIQUE        (1 << 1)        /* unique match, 
for RDMA */
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_rtrbuf { · line 457
Quoted 1 line
drivers/staging/lustre/include/linux/lnet/lib-types.h +0 -1
-#define LNET_PTL_MATCH_WILDCARD        (1 << 2)        /* wildcard 
match,

Quoted 9 lines

drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_rtrbuf { · line 456
Quoted 2 lines
drivers/staging/lustre/include/linux/lnet/lib-types.h +2 -0
+#define LNET_PTL_LAZY                BIT(0) 
+#define LNET_PTL_MATCH_UNIQUE        BIT(1)        /* unique match, for 
RDMA */
drivers/staging/lustre/include/linux/lnet/lib-types.h struct lnet_rtrbuf { · line 459
Quoted 3 lines
drivers/staging/lustre/include/linux/lnet/lib-types.h +1 -0
+#define LNET_PTL_MATCH_WILDCARD        BIT(2)        /* wildcard match, 
                                                  * request portal 
                                                  */ 
It looks like the final comment could be on only one line?

It's a multi line comment style that author has used throughout the file. Similarly we
can see the same style in lines 420, 412 too.

-Keerthi.

Quoted 19 lines

julia
Quoted 6 lines
drivers/staging/lustre/include/linux/lnet/lib-types.h +0 -1
-- 
2.7.4
Signature · 1 line
You received this message because you are subscribed to the Google 
Groups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <javascript:>.
Quoted 1 line
To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20171002131042.GA12477%40manoharreddy.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.

Julia Lawall

2017-10-02 13:42 UTC #3 lore raw

Quoted 93 lines · Keerthi Reddy

On Monday, October 2, 2017 at 6:45:43 PM UTC+5:30, Julia Lawall wrote:
On Mon, 2 Oct 2017, Keerthi Reddy wrote:
> This commit changes changes left shift operator to use BIT
macro
>
> Signed-off-by: Keerthi Reddy <[email protected]>
> ---
> ï¿œ.../staging/lustre/include/linux/lnet/lib-types.h ï¿œ| 26
+++++++++++-----------
> ï¿œ1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git
a/drivers/staging/lustre/include/linux/lnet/lib-types.h
b/drivers/staging/lustre/include/linux/lnet/lib-types.h
> index eea3b8e..15837a3 100644
> --- a/drivers/staging/lustre/include/linux/lnet/lib-types.h
> +++ b/drivers/staging/lustre/include/linux/lnet/lib-types.h
> @@ -160,9 +160,9 @@ struct lnet_libmd {
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ} md_iov;
> ï¿œ};
>
> -#define LNET_MD_FLAG_ZOMBIEï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(1 << 0)
> -#define LNET_MD_FLAG_AUTO_UNLINKï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(1 << 1)
> -#define LNET_MD_FLAG_ABORTEDï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(1 << 2)
> +#define LNET_MD_FLAG_ZOMBIEï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œBIT(0)
> +#define LNET_MD_FLAG_AUTO_UNLINKï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œBIT(1)
> +#define LNET_MD_FLAG_ABORTEDï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œBIT(2)
>
> ï¿œstruct lnet_test_peer {
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/* info about peers we are trying to fail */
> @@ -287,9 +287,9 @@ struct lnet_ni {
> ï¿œ * of old LNet, so there shouldn't be any compatibility issue
> ï¿œ */
> ï¿œ#define LNET_PING_FEAT_INVALï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(0)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/* no
feature */
> -#define LNET_PING_FEAT_BASEï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(1 << 0)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/*
just a ping */
> -#define LNET_PING_FEAT_NI_STATUSï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(1 << 1)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/*
return NI status */
> -#define LNET_PING_FEAT_RTE_DISABLEDï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(1 << 2)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/*
Routing enabled */
> +#define LNET_PING_FEAT_BASEï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œBIT(0)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/*
just a ping */
> +#define LNET_PING_FEAT_NI_STATUSï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œBIT(1)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/*
return NI status */
> +#define LNET_PING_FEAT_RTE_DISABLEDï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œBIT(2)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/*
Routing enabled */
>
> ï¿œ#define
LNET_PING_FEAT_MASKï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(LNET_PING_FEAT_BASE | \
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ LNET_PING_FEAT_NI_STATUS)
> @@ -440,21 +440,21 @@ struct lnet_rtrbuf {
>
> ï¿œenum lnet_match_flags {
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/* Didn't match anything */
> -ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œLNET_MATCHMD_NONEï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ= (1 << 0),
> +ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œLNET_MATCHMD_NONEï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ= BIT(0),
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/* Matched OK */
> -ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œLNET_MATCHMD_OKï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ= (1 << 1),
> +ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œLNET_MATCHMD_OKï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ= BIT(1),
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/* Must be discarded */
> -ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œLNET_MATCHMD_DROPï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ= (1 << 2),
> +ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œLNET_MATCHMD_DROPï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ= BIT(2),
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/* match and buffer is exhausted */
> -ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œLNET_MATCHMD_EXHAUSTEDï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ= (1 << 3),
> +ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œLNET_MATCHMD_EXHAUSTEDï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ= BIT(3),
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/* match or drop */
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œLNET_MATCHMD_FINISHï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ= (LNET_MATCHMD_OK |
LNET_MATCHMD_DROP),
> ï¿œ};
>
> ï¿œ/* Options for lnet_portal::ptl_options */
> -#define LNET_PTL_LAZYï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(1 << 0)
> -#define LNET_PTL_MATCH_UNIQUEï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(1 << 1)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/*
unique match, for RDMA */
> -#define LNET_PTL_MATCH_WILDCARDï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ(1 << 2)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/*
wildcard match,
> +#define LNET_PTL_LAZYï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œBIT(0)
> +#define LNET_PTL_MATCH_UNIQUEï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œBIT(1)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/* unique
match, for RDMA */
> +#define LNET_PTL_MATCH_WILDCARDï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œBIT(2)ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ/*
wildcard match,
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ * request portal
> ï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œï¿œ */

Quoted 6 lines

It looks like the final comment could be on only one line?
ï¿œ
It's a multi line comment style that author has used throughout the file. Similarly weï¿œ
can see the same style in lines 420, 412 too.ï¿œ

If the comment can be on a single line without exceeding 80 characters that would be more readable. Your BIT code is shorter than the original code, so it could now be possible. If needed, the comment could be one space closer to the BIT calls and/or the BIT calls could be closer to the macro names. One line is always easier to read than multiple lines, if it fits in 80 characters.

julia