Skip to contentSkip to conversation

Staging: speakup: replace 'S_IRUGO' macro with octal 0444

PATCH In review Keerthi Reddy 2 participants 2 messages Sep 30, 2017 – Oct 3, 2017 Staging

lore
Share & tools
lore

Keerthi Reddy

author
#0 lore raw

PATCH v2 1/1 Staging: speakup: replace 'S_IRUGO' macro with octal 0444

Everyone knows what 0444 means. But one has read through docs to understand the meaning of 'S_IRUGO'.

Signed-off-by Keerthi Reddy <[email protected]>

---
v2: make the same change in remaining files too.

 drivers/staging/speakup/speakup_apollo.c | 2 +-
 drivers/staging/speakup/speakup_audptr.c | 2 +-
 drivers/staging/speakup/speakup_bns.c    | 2 +-
 drivers/staging/speakup/speakup_decext.c | 2 +-
 drivers/staging/speakup/speakup_dectlk.c | 2 +-
 drivers/staging/speakup/speakup_dummy.c  | 2 +-
 drivers/staging/speakup/speakup_ltlk.c   | 2 +-
 drivers/staging/speakup/speakup_spkout.c | 2 +-
 drivers/staging/speakup/speakup_txprt.c  | 2 +-
 9 files changed, 9 insertions(+), 9 deletions(-)
drivers/staging/speakup/speakup_apollo.c +1 -1
index 2edb56c..dcf0c3b 100644
@@ -200,7 +200,7 @@ static void do_catch_up(struct spk_synth *synth)
 }
 
 module_param_named(ser, synth_apollo.ser, int, 0444);
-module_param_named(dev, synth_apollo.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_apollo.dev_name, charp, 0444);
 module_param_named(start, synth_apollo.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
drivers/staging/speakup/speakup_audptr.c +1 -1
index 8ae826e..45b5721 100644
@@ -163,7 +163,7 @@ static int synth_probe(struct spk_synth *synth)
 }
 
 module_param_named(ser, synth_audptr.ser, int, 0444);
-module_param_named(dev, synth_audptr.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_audptr.dev_name, charp, 0444);
 module_param_named(start, synth_audptr.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
drivers/staging/speakup/speakup_bns.c +1 -1
index 60bcf0d..402b0fb 100644
@@ -120,7 +120,7 @@ static struct spk_synth synth_bns = {
 };
 
 module_param_named(ser, synth_bns.ser, int, 0444);
-module_param_named(dev, synth_bns.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_bns.dev_name, charp, 0444);
 module_param_named(start, synth_bns.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
drivers/staging/speakup/speakup_decext.c +1 -1
index 95f4b21..4310c2c 100644
@@ -227,7 +227,7 @@ static void synth_flush(struct spk_synth *synth)
 }
 
 module_param_named(ser, synth_decext.ser, int, 0444);
-module_param_named(dev, synth_decext.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_decext.dev_name, charp, 0444);
 module_param_named(start, synth_decext.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
drivers/staging/speakup/speakup_dectlk.c +1 -1
index f069954..5d6a861 100644
@@ -299,7 +299,7 @@ static void synth_flush(struct spk_synth *synth)
 }
 
 module_param_named(ser, synth_dectlk.ser, int, 0444);
-module_param_named(dev, synth_dectlk.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_dectlk.dev_name, charp, 0444);
 module_param_named(start, synth_dectlk.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
drivers/staging/speakup/speakup_dummy.c +1 -1
index 851953d..ea3b291 100644
@@ -122,7 +122,7 @@ static struct spk_synth synth_dummy = {
 };
 
 module_param_named(ser, synth_dummy.ser, int, 0444);
-module_param_named(dev, synth_dummy.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_dummy.dev_name, charp, 0444);
 module_param_named(start, synth_dummy.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
drivers/staging/speakup/speakup_ltlk.c +1 -1
index 423795f..95efaab 100644
@@ -167,7 +167,7 @@ static int synth_probe(struct spk_synth *synth)
 }
 
 module_param_named(ser, synth_ltlk.ser, int, 0444);
-module_param_named(dev, synth_ltlk.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_ltlk.dev_name, charp, 0444);
 module_param_named(start, synth_ltlk.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
drivers/staging/speakup/speakup_spkout.c +1 -1
index 9ca21ed..1037aa0 100644
@@ -131,7 +131,7 @@ static void synth_flush(struct spk_synth *synth)
 }
 
 module_param_named(ser, synth_spkout.ser, int, 0444);
-module_param_named(dev, synth_spkout.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_spkout.dev_name, charp, 0444);
 module_param_named(start, synth_spkout.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
drivers/staging/speakup/speakup_txprt.c +1 -1
index 831ee40..e160034 100644
@@ -119,7 +119,7 @@ static struct spk_synth synth_txprt = {
 };
 
 module_param_named(ser, synth_txprt.ser, int, 0444);
-module_param_named(dev, synth_txprt.dev_name, charp, S_IRUGO);
+module_param_named(dev, synth_txprt.dev_name, charp, 0444);
 module_param_named(start, synth_txprt.startup, short, 0444);
 
 MODULE_PARM_DESC(ser, "Set the serial port for the synthesizer (0-based).");
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 6 lines · Keerthi Reddy

Everyone knows what 0444 means. But one has read through docs to understand the meaning of 'S_IRUGO'.

Signed-off-by Keerthi Reddy <[email protected]>

---
v2: make the same change in remaining files too.

Doesn't apply to my tree at all :(