Skip to contentSkip to conversation

git version 2.4.12 color.ui = always breaks git add -p

bug Christian Rebischke 3 participants 3 messages Oct 3, 2017

lore
Share & tools
lore
#0 lore raw

Hello everybody,
I played around with my gitconfig and I think I found a bug while doing so. I set the following lines in my gitconfig:

[color]
ui = always

When I try to use git add -p <filename> I don't see the 'Stage this hunk'-dialog anymore. First I thought it's some other configuration but now I can definitly say that this configuration breaks git add -p interactive mode.

best regards

chris

#1 lore raw

Hi Christian,

Quoted 10 lines · Christian Rebischke

I played around with my gitconfig and I think I found a bug while doing so. I set the following lines in my gitconfig:

[color]
ui = always

When I try to use git add -p <filename> I don't see the 'Stage this hunk'-dialog anymore. First I thought it's some other configuration but now I can definitly say that this configuration breaks git add -p interactive mode.

Do the patches at
https://public-inbox.org/git/[email protected]/
help?

Thanks and hope that helps,
Jonathan

#2 lore raw
Quoted 10 lines · Jonathan Nieder

Hi Christian,

Quoted 6 lines · Christian Rebischke

I played around with my gitconfig and I think I found a bug while doing so. I set the following lines in my gitconfig:

[color]
ui = always

Quoted 8 lines
Quoted 4 lines

When I try to use git add -p <filename> I don't see the 'Stage this hunk'-dialog anymore. First I thought it's some other configuration but now I can definitly say that this configuration breaks git add -p interactive mode.

Do the patches at
https://public-inbox.org/git/[email protected]/
help?

If it makes it any easier to test, they are also available as a fetch from:

https://github.com/peff/git jk/color-no-always

-Peff