qt: Allow enabling of QtWebKit with GCC 6+
PATCH 1/1 qt: Allow enabling of QtWebKit with GCC 6+
Building Qt with QtWebKit on configuration step there is a check which disables QtWebKit build with GCC 6+. Back in the day nobody thought about building Qt with GCC version greater than 5.x. And now with modern GCCs like 6.x and 7.x this assumption gets in the way.
Given in Buildroot today we don't have GCC older than 4.9 it should be safe to remove now meaningless check completely by adding patch to qt.
--- .../qt/0014-Enable-QtWebKit-with-newer-GCC.patch | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 package/qt/0014-Enable-QtWebKit-with-newer-GCC.patch
package/qt/0014-Enable-QtWebKit-with-newer-GCC.patch new file +50 -0
@@ -0,0 +1,50 @@ +From f566411fb314b7e4ab01f28e25e942cfaf8c59b7 Mon Sep 17 00:00:00 2001 +From: Evgeniy Didin <[email protected]> +Date: Fri, 15 Sep 2017 19:43:48 +0300 +Subject: [PATCH] qt: Allow enabling of QtWebKit with GCC 6+ + +Building Qt with QtWebKit on configuration step there is +a check which disables QtWebKit build with GCC 6+. +Back in the day nobody thought about building Qt with GCC +version greater than 5.x. And now with modern GCCs like +6.x and 7.x this assumption gets in the way. + +Given in Buildroot today we don't have GCC older than 4.9 +it should be safe to remove now meaningless check completely. + +Signed-off-by: Evgeniy Didin <[email protected]> +Cc: Alexey Brodkin <[email protected]> +Cc: Thomas Petazzoni <[email protected]> + +--- + configure | 14 -------------- + 1 file changed, 14 deletions(-) + +diff --git a/configure b/configure +index 10ad7ca0b0..8771144a65 100755 +--- a/configure ++++ b/configure +@@ -7731,20 +7731,6 @@ case "$XPLATFORM" in + canBuildWebKit="no" + canBuildQtXmlPatterns="no" + ;; +- *-g++*) +- # Check gcc's version +- case "$(${QMAKE_CONF_COMPILER} -dumpversion)" in +- 5*|4*|3.4*) +- ;; +- 3.3*) +- canBuildWebKit="no" +- ;; +- *) +- canBuildWebKit="no" +- canBuildQtXmlPatterns="no" +- ;; +- esac +- ;; + solaris-cc*) + # Check the compiler version + case `${QMAKE_CONF_COMPILER} -V 2>&1 | awk '{print $4}'` in +-- +2.11.0 +
Signature · 1 line
2.11.0
Thomas Petazzoni
AppliedPATCH 1/1 qt: Allow enabling of QtWebKit with GCC 6+
Hello,
Quoted 10 lines · Evgeniy Didin
Building Qt with QtWebKit on configuration step there is a check which disables QtWebKit build with GCC 6+. Back in the day nobody thought about building Qt with GCC version greater than 5.x. And now with modern GCCs like 6.x and 7.x this assumption gets in the way.
Given in Buildroot today we don't have GCC older than 4.9 it should be safe to remove now meaningless check completely by adding patch to qt.
Quoted 7 lines
Signed-off-by Evgeniy Didin <[email protected]>Cc Alexey Brodkin <[email protected]>Cc Thomas Petazzoni <[email protected]>--- .../qt/0014-Enable-QtWebKit-with-newer-GCC.patch | 50 ++++++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 package/qt/0014-Enable-QtWebKit-with-newer-GCC.patch
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 qt: Allow enabling of QtWebKit with GCC 6+
In reply to Evgeniy DidinQuoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Evgeniy" == Evgeniy Didin <[email protected]> writes:
Building Qt with QtWebKit on configuration step there is a check which disables QtWebKit build with GCC 6+. Back in the day nobody thought about building Qt with GCC version greater than 5.x. And now with modern GCCs like 6.x and 7.x this assumption gets in the way.
Quoted 7 lines
Given in Buildroot today we don't have GCC older than 4.9 it should be safe to remove now meaningless check completely by adding patch to qt.
Signed-off-by Evgeniy Didin <[email protected]>Cc Alexey Brodkin <[email protected]>Cc Thomas Petazzoni <[email protected]>
Committed to 2017.02.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 qt: Allow enabling of QtWebKit with GCC 6+
In reply to Evgeniy DidinQuoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Evgeniy" == Evgeniy Didin <[email protected]> writes:
Building Qt with QtWebKit on configuration step there is a check which disables QtWebKit build with GCC 6+. Back in the day nobody thought about building Qt with GCC version greater than 5.x. And now with modern GCCs like 6.x and 7.x this assumption gets in the way.
Quoted 7 lines
Given in Buildroot today we don't have GCC older than 4.9 it should be safe to remove now meaningless check completely by adding patch to qt.
Signed-off-by Evgeniy Didin <[email protected]>Cc Alexey Brodkin <[email protected]>Cc Thomas Petazzoni <[email protected]>
Committed to 2017.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 qt: Allow enabling of QtWebKit with GCC 6+
Hi Peter, Thomas,
Quoted 20 lines
-----Original Message-----
From: Peter Korsgaard [mailto:jacmet at gmail.com] On Behalf Of Peter Korsgaard
Sent: Tuesday, October 17, 2017 12:02 PM
To: Evgeniy Didin <[email protected]>
Cc: buildroot at busybox.net; Thomas Petazzoni <[email protected]>; Alexey Brodkin <[email protected]>
Subject: Re: [PATCH] qt: Allow enabling of QtWebKit with GCC 6+Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Evgeniy" == Evgeniy Didin <[email protected]> writes:
Building Qt with QtWebKit on configuration step there is a check which disables QtWebKit build with GCC 6+. Back in the day nobody thought about building Qt with GCC version greater than 5.x. And now with modern GCCs like 6.x and 7.x this assumption gets in the way.
Given in Buildroot today we don't have GCC older than 4.9 it should be safe to remove now meaningless check completely by adding patch to qt.
Quoted 5 lines
Quoted 3 lines
Signed-off-by Evgeniy Didin <[email protected]>Cc Alexey Brodkin <[email protected]>Cc Thomas Petazzoni <[email protected]>Committed to 2017.08.x, thanks.
I see that commit was applied on 2 "LTS" branches already which is definitely good.
But my question is are there any formal rules and guidelines for patches to be
cherry-picked onto LTS branches? Something like https://github.com/torvalds/linux/blob/master/Documentation/process/stable-kernel-rules.rst?
Probably I just missed that as usual :)
-Alexey
PATCH 1/1 qt: Allow enabling of QtWebKit with GCC 6+
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Alexey" == Alexey Brodkin <[email protected]> writes:
Hi,
Quoted 6 lines
Quoted 1 line
Committed to 2017.08.x, thanks.
I see that commit was applied on 2 "LTS" branches already which is definitely good. But my question is are there any formal rules and guidelines for patches to be cherry-picked onto LTS branches? Something like
https://github.com/torvalds/linux/blob/master/Documentation/process/stable-kernel-rules.rst?
As discussed during the dev days, we don't really have any format rules. If you think specific patches should be backported, please let me know.
Signature · 1 line
Bye, Peter Korsgaard