i40e: Build for 64-bit targets only
Subsystems (2)
RFC PATCH 1/1 i40e: Build for 64-bit targets only
i40e now uses cmpxchg64(), which only works on a 64-bit (or non-SMP) system. (It is currently defined for many 32-bit SMP configurations, but not correctly!) It seems reasonable to expect that 40G hardware is not used on 32-bit systems.
---
I specifically found a build failure on 32-bit parisc:
Ben.
drivers/net/ethernet/intel/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/intel/Kconfig +1 -0
@@ -215,6 +215,7 @@ config I40E tristate "Intel(R) Ethernet Controller XL710 Family support" imply PTP_1588_CLOCK depends on PCI + depends on 64BIT ---help--- This driver supports Intel(R) Ethernet Controller XL710 Family of devices. For more information on how to identify your adapter, go
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: Digital signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171004/a7d4ff8b/attachment-0001.asc>
RFC PATCH 1/1 i40e: Build for 64-bit targets only
Quoted 4 lines · Ben Hutchings
i40e now uses
cmpxchg64(), which only works on a 64-bit (or non-SMP) system. (It is currently defined for many 32-bit SMP configurations, but not correctly!) It seems reasonable to expect that 40G hardware is not used on 32-bit systems.
Actually only mips seems to define it wrongly. arm and x86 define cmpcxhg64() in some 32-bit configurations (depending on required CPU type). There's not an obvious config symbol that could be used to check for this specifically.
Ben.
Quoted 24 lines
Fixes 841c950d67c6 ("i40e/i40evf: use cmpxchg64 when updating private ...")Signed-off-by Ben Hutchings <[email protected]>---
I specifically found a build failure on 32-bit parisc:Ben.
drivers/net/ethernet/intel/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/intel/Kconfig +1
-0@@ -215,6 +215,7 @@ config I40E tristate "Intel(R) Ethernet Controller XL710 Family support" imply PTP_1588_CLOCK depends on PCI + depends on 64BIT ---help--- This driver supports Intel(R) Ethernet Controller XL710 Family of devices. For more information on how to identify your adapter, go
Signature · 9 lines
Ben Hutchings One of the nice things about standards is that there are so many of them. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 811 bytes Desc: Digital signature URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20171004/90c9211b/attachment-0001.asc>