iptables: change large file support handling

PATCH In review Juergen Borleis 2 participants 6 messages Sep 28, 2017 – Oct 4, 2017 netfilter

Share & tools

Juergen Borleis

author

2017-09-28 08:59 UTC #0 lore raw

PATCH 1/1 iptables: change large file support handling

The configure script handles the "--*-largefile" parameter badly. It defaults to large file support if not given and always disables largefile support if given (and it doesn't matter if 'enable' or 'disable' was used)

Signed-off-by Juergen Borleis <[email protected]>

---
 configure.ac | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

configure.ac +3 -2

index eda7871405b3..30445d7deda8 100644
@@ -42,8 +42,9 @@ AC_ARG_ENABLE([ipv6],
 AC_ARG_ENABLE([largefile],
 	AS_HELP_STRING([--disable-largefile], [Do not build largefile support]),
 	[enable_largefile="$enableval"],
-	[enable_largefile="yes";
-	largefile_cppflags='-D_LARGEFILE_SOURCE=1 -D_LARGE_FILES -D_FILE_OFFSET_BITS=64'])
+	[enable_largefile="yes"])
+AS_IF([test "$enable_largefile" = "yes"], [largefile_cppflags='-D_LARGEFILE_SOURCE=1 -D_LARGE_FILES -D_FILE_OFFSET_BITS=64'])
+
 AC_ARG_ENABLE([devel],
 	AS_HELP_STRING([--enable-devel],
 	[Install Xtables development headers]),

Pablo Neira Ayuso

maintainer

2017-10-04 14:15 UTC #1 lore raw

Hi Juergen,

Quoted 3 lines · Juergen Borleis

The configure script handles the "--*-largefile" parameter badly. It defaults to large file support if not given and always disables largefile support if given (and it doesn't matter if 'enable' or 'disable' was used)

It seems the default behaviour for a while has been to enable largefile by default.

Then, someone came in to add this --disable-largefile configure time option, see:

commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43

Author: Karl Hiramoto <[email protected]>
Date:   Mon May 10 17:50:41 2010 +0200

iptables: optionally disable largefile support

So I would just fix --enable-* --disable-*.

Would you follow up on this? Let me know, thanks.

Juergen Borleis

author

2017-10-04 14:39 UTC #2 lore raw

Hi Pablo,

Quoted 12 lines · On Wednesday 04 October 2017 16:14:58 Pablo Neira Ayuso wrote:

Quoted 4 lines
The configure script handles the "--*-largefile" parameter badly. It defaults to large file support if not given and always disables largefile support if given (and it doesn't matter if 'enable' or 'disable' was used)
It seems the default behaviour for a while has been to enable largefile by default.
Then, someone came in to add this --disable-largefile configure time option, see:
commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43

Quoted 8 lines

Author: Karl Hiramoto <[email protected]>
Date:   Mon May 10 17:50:41 2010 +0200
iptables: optionally disable largefile support
So I would just fix --enable-* --disable-*.
Would you follow up on this? Let me know, thanks.

With my change the default is still "enabled" and you can disable it on demand. To have still support for "disable on demand" makes sense for some small 32 bit embedded systems.

Juergen

Signature · 2 lines

Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                   | http://www.pengutronix.de/  |

Pablo Neira Ayuso

maintainer

2017-10-04 14:46 UTC #3 lore raw

Quoted 18 lines · Juergen Borleis

Hi Pablo,
Quoted 15 lines · On Wednesday 04 October 2017 16:14:58 Pablo Neira Ayuso wrote:
Quoted 4 lines
The configure script handles the "--*-largefile" parameter badly. It defaults to large file support if not given and always disables largefile support if given (and it doesn't matter if 'enable' or 'disable' was used)
It seems the default behaviour for a while has been to enable largefile by default.
Then, someone came in to add this --disable-largefile configure time option, see:
commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
Author: Karl Hiramoto <[email protected]>
Date:   Mon May 10 17:50:41 2010 +0200

Quoted 8 lines

Quoted 5 lines
iptables: optionally disable largefile support
So I would just fix --enable-* --disable-*.
Would you follow up on this? Let me know, thanks.
With my change the default is still "enabled" and you can disable it on demand.

I'm going to remove this from your log message: "It defaults to large file support if not given", when I read this I thought this was the problem.

Quoted 2 lines

To have still support for "disable on demand" makes sense for some small 32 bit embedded systems.

Sure, this knob is useful, not questioning this, and it needs to be fixed.

Thanks.

Juergen Borleis

author

2017-10-04 14:52 UTC #4 lore raw

Hi Pablo,

Quoted 19 lines · On Wednesday 04 October 2017 16:46:06 Pablo Neira Ayuso wrote:

Quoted 19 lines
Quoted 19 lines
Quoted 4 lines
The configure script handles the "--*-largefile" parameter badly. It defaults to large file support if not given and always disables largefile support if given (and it doesn't matter if 'enable' or 'disable' was used)
It seems the default behaviour for a while has been to enable largefile by default.
Then, someone came in to add this --disable-largefile configure time option, see:
commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
Author: Karl Hiramoto <[email protected]>
Date:   Mon May 10 17:50:41 2010 +0200
iptables: optionally disable largefile support
So I would just fix --enable-* --disable-*.

Quoted 8 lines

Quoted 4 lines
Quoted 1 line
Would you follow up on this? Let me know, thanks.
With my change the default is still "enabled" and you can disable it on demand.
I'm going to remove this from your log message: "It defaults to large file support if not given", when I read this I thought this was the problem.

Ahh, okay.

Juergen

Signature · 4 lines

Pengutronix e.K.                             | Juergen Borleis             |
Linux Solutions for Science and Industry     | Phone: +49-5121-206917-5128 |
Peiner Str. 6-8, 31137 Hildesheim, Germany   | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686             | http://www.pengutronix.de/  |

Pablo Neira Ayuso

maintainer

2017-10-04 15:10 UTC #5 lore raw

Quoted 24 lines · Juergen Borleis

Hi Pablo,
Quoted 21 lines · On Wednesday 04 October 2017 16:46:06 Pablo Neira Ayuso wrote:
Quoted 21 lines
Quoted 20 lines
Quoted 4 lines
The configure script handles the "--*-largefile" parameter badly. It defaults to large file support if not given and always disables largefile support if given (and it doesn't matter if 'enable' or 'disable' was used)
It seems the default behaviour for a while has been to enable largefile by default.
Then, someone came in to add this --disable-largefile configure time option, see:
commit 967cb7106f0f61cd7b8fbb10bc2451a3f7372a43
Author: Karl Hiramoto <[email protected]>
Date:   Mon May 10 17:50:41 2010 +0200
iptables: optionally disable largefile support
So I would just fix --enable-* --disable-*.
Would you follow up on this? Let me know, thanks.

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
With my change the default is still "enabled" and you can disable it on demand.
I'm going to remove this from your log message: "It defaults to large file support if not given", when I read this I thought this was the problem.
Ahh, okay.

Now applied, thanks for explaining.