Skip to contentSkip to conversation

drm/i915: Allow null render state batchbuffers bigger than one page

PATCH In review Oscar Mateo 6 participants 19 messages Apr 28, 2017 – Oct 12, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Allow null render state batchbuffers bigger than one page

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala <[email protected]>
Cc Ben Widawsky <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem_render_state.c | 40 +++++++++++++++-------------
 1 file changed, 21 insertions(+), 19 deletions(-)
drivers/gpu/drm/i915/i915_gem_render_state.c +21 -19
index 12d7036..07f9bd6 100644
@@ -62,12 +62,12 @@ struct intel_render_state {
  * this is sufficient as the null state generator makes the final batch
  * with two passes to build command and state separately. At this point
  * the size of both are known and it compacts them by relocating the state
- * right after the commands taking care of alignment so we should sufficient
- * space below them for adding new commands.
+ * right after the commands taking care of alignment so we should have
+ * sufficient space below them for adding new commands.
  */
-#define OUT_BATCH(batch, i, val)				\
+#define OUT_BATCH(batch, size, i, val)				\
 	do {							\
-		if ((i) >= PAGE_SIZE / sizeof(u32))		\
+		if ((i) >= size / sizeof(u32))			\
 			goto err;				\
 		(batch)[(i)++] = (val);				\
 	} while(0)
@@ -86,7 +86,11 @@ static int render_state_setup(struct intel_render_state *so,
 	if (ret)
 		return ret;
 
-	d = kmap_atomic(i915_gem_object_get_dirty_page(obj, 0));
+	d = i915_gem_object_pin_map(obj, I915_MAP_WB);
+	if (IS_ERR(d)) {
+		ret = PTR_ERR(d);
+		goto out;
+	}
 
 	while (i < rodata->batch_items) {
 		u32 s = rodata->batch[i];
@@ -118,7 +122,7 @@ static int render_state_setup(struct intel_render_state *so,
 	so->batch_size = rodata->batch_items * sizeof(u32);
 
 	while (i % CACHELINE_DWORDS)
-		OUT_BATCH(d, i, MI_NOOP);
+		OUT_BATCH(d, obj->base.size, i, MI_NOOP);
 
 	so->aux_offset = i * sizeof(u32);
 
@@ -141,15 +145,15 @@ static int render_state_setup(struct intel_render_state *so,
 		 */
 		u32 eu_pool_config = 0x00777000;
 
-		OUT_BATCH(d, i, GEN9_MEDIA_POOL_STATE);
-		OUT_BATCH(d, i, GEN9_MEDIA_POOL_ENABLE);
-		OUT_BATCH(d, i, eu_pool_config);
-		OUT_BATCH(d, i, 0);
-		OUT_BATCH(d, i, 0);
-		OUT_BATCH(d, i, 0);
+		OUT_BATCH(d, obj->base.size, i, GEN9_MEDIA_POOL_STATE);
+		OUT_BATCH(d, obj->base.size, i, GEN9_MEDIA_POOL_ENABLE);
+		OUT_BATCH(d, obj->base.size, i, eu_pool_config);
+		OUT_BATCH(d, obj->base.size, i, 0);
+		OUT_BATCH(d, obj->base.size, i, 0);
+		OUT_BATCH(d, obj->base.size, i, 0);
 	}
 
-	OUT_BATCH(d, i, MI_BATCH_BUFFER_END);
+	OUT_BATCH(d, obj->base.size, i, MI_BATCH_BUFFER_END);
 	so->aux_size = i * sizeof(u32) - so->aux_offset;
 	so->aux_offset += so->batch_offset;
 	/*
@@ -160,7 +164,7 @@ static int render_state_setup(struct intel_render_state *so,
 
 	if (needs_clflush)
 		drm_clflush_virt_range(d, i * sizeof(u32));
-	kunmap_atomic(d);
+	i915_gem_object_unpin_map(obj);
 
 	ret = i915_gem_object_set_to_gtt_domain(obj, false);
 out:
@@ -168,7 +172,7 @@ static int render_state_setup(struct intel_render_state *so,
 	return ret;
 
 err:
-	kunmap_atomic(d);
+	i915_gem_object_unpin_map(obj);
 	ret = -EINVAL;
 	goto out;
 }
@@ -189,14 +193,12 @@ int i915_gem_render_state_init(struct intel_engine_cs *engine)
 	if (!rodata)
 		return 0;
 
-	if (rodata->batch_items * 4 > PAGE_SIZE)
-		return -EINVAL;
-
 	so = kmalloc(sizeof(*so), GFP_KERNEL);
 	if (!so)
 		return -ENOMEM;
 
-	obj = i915_gem_object_create_internal(engine->i915, PAGE_SIZE);
+	obj = i915_gem_object_create_internal(engine->i915,
+			PAGE_ALIGN(rodata->batch_items * 4));
 	if (IS_ERR(obj)) {
 		ret = PTR_ERR(obj);
 		goto err_free;
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✓ Fi.CI.BAT: success for drm/i915: Allow null render state batchbuffers bigger than one page

== Series Details ==

== Series Details ==

Series: drm/i915: Allow null render state batchbuffers bigger than one page
URL : https://patchwork.freedesktop.org/series/23713/
State : success

== Summary ==

Series 23713v1 drm/i915: Allow null render state batchbuffers bigger than one page
https://patchwork.freedesktop.org/api/1.0/series/23713/revisions/1/mbox/

Test gem_exec_suspend:

        Subgroup basic-s4-devices:
                pass       -> DMESG-WARN (fi-snb-2600) fdo#100125
                pass       -> DMESG-WARN (fi-kbl-7560u) fdo#100125

fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125

fi-bdw-5557u     total:278  pass:267  dwarn:0   dfail:0   fail:0   skip:11  time:432s
fi-bdw-gvtdvm    total:278  pass:256  dwarn:8   dfail:0   fail:0   skip:14  time:425s
fi-bsw-n3050     total:278  pass:242  dwarn:0   dfail:0   fail:0   skip:36  time:581s
fi-bxt-j4205     total:278  pass:259  dwarn:0   dfail:0   fail:0   skip:19  time:513s
fi-bxt-t5700     total:278  pass:258  dwarn:0   dfail:0   fail:0   skip:20  time:534s
fi-byt-j1900     total:278  pass:254  dwarn:0   dfail:0   fail:0   skip:24  time:482s
fi-byt-n2820     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:482s
fi-hsw-4770      total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:411s
fi-hsw-4770r     total:278  pass:262  dwarn:0   dfail:0   fail:0   skip:16  time:404s
fi-ilk-650       total:278  pass:228  dwarn:0   dfail:0   fail:0   skip:50  time:419s
fi-ivb-3520m     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:491s
fi-ivb-3770      total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:468s
fi-kbl-7500u     total:278  pass:260  dwarn:0   dfail:0   fail:0   skip:18  time:457s
fi-kbl-7560u     total:278  pass:267  dwarn:1   dfail:0   fail:0   skip:10  time:568s
fi-skl-6260u     total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:456s
fi-skl-6700hq    total:278  pass:261  dwarn:0   dfail:0   fail:0   skip:17  time:577s
fi-skl-6700k     total:278  pass:256  dwarn:4   dfail:0   fail:0   skip:18  time:455s
fi-skl-6770hq    total:278  pass:268  dwarn:0   dfail:0   fail:0   skip:10  time:493s
fi-skl-gvtdvm    total:278  pass:265  dwarn:0   dfail:0   fail:0   skip:13  time:428s
fi-snb-2520m     total:278  pass:250  dwarn:0   dfail:0   fail:0   skip:28  time:538s
fi-snb-2600      total:278  pass:248  dwarn:1   dfail:0   fail:0   skip:29  time:412s

1d490e4b6d5324cfbf8dc800cf4a99471252802c drm-tip: 2017y-04m-28d-14h-14m-47s UTC integration manifest fafea7b drm/i915: Allow null render state batchbuffers bigger than one page

== Logs ==

For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_4582/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Oscar Mateo
Quoted 5 lines · Oscar Mateo

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala <[email protected]>
Cc Ben Widawsky <[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for itself for correctness anyway.

Patch looks ok, but still question the sanity.
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 11 lines · Chris Wilson
Quoted 5 lines · Oscar Mateo

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala <[email protected]>
Cc Ben Widawsky <[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for itself for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

-Mika

Quoted 4 lines

-Chris

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 11 lines · Mika Kuoppala
Quoted 9 lines · Chris Wilson
Quoted 5 lines · Oscar Mateo

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala <[email protected]>
Cc Ben Widawsky <[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for itself for correctness anyway.

Quoted 8 lines
Quoted 1 line

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

-Mika

Hi Mika,

I can double-check with the hardware architects, but word around here is that render state init has never stopped being a requirement. Where did you see in the BSpec that it is not required for CNL?

Thanks
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 19 lines · Oscar Mateo
Quoted 18 lines · Mika Kuoppala
Quoted 10 lines · Chris Wilson
Quoted 5 lines · Oscar Mateo

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala <[email protected]>
Cc Ben Widawsky <[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for itself for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

Quoted 8 lines
Quoted 1 line

-Mika

Hi Mika,

I can double-check with the hardware architects, but word around here is that render state init has never stopped being a requirement. Where did you see in the BSpec that it is not required for CNL?

It would be great if you could refresh the answer and perhaps even get some answers to the 'why' parts.

In the "Context Descriptor Format" section, it says:
"Render CS Only: Render state need not be initialized; the Render Context Restore Inhibit bit in the Context/Save image in memory should be set to prevent restoring garbage render context."

-Mika
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
Quoted 31 lines · Mika Kuoppala
Quoted 19 lines · Oscar Mateo
Quoted 18 lines · Mika Kuoppala
Quoted 10 lines · Chris Wilson
Quoted 5 lines · Oscar Mateo

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala <[email protected]>
Cc Ben Widawsky <[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for itself for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

Quoted 7 lines
Quoted 1 line

-Mika

Hi Mika,

I can double-check with the hardware architects, but word around here is that render state init has never stopped being a requirement. Where did you see in the BSpec that it is not required for CNL?

It would be great if you could refresh the answer and perhaps even get some answers to the 'why' parts.

Quoted 6 lines

In the "Context Descriptor Format" section, it says:
"Render CS Only: Render state need not be initialized; the Render Context Restore Inhibit bit in the Context/Save image in memory should be set to prevent restoring garbage render context."

-Mika

:_(

The same section also says:

“See the Logical Ring Context Format section for details.”

And then “Logical Ring Context Format” section goes on to say:

“It is tedious for software to populate the engine context as per the requirements, it is recommended to implicitly use engine to populate this portion of the context. […] Software must program all the state required to initialize the engine in the ring buffer which would initialize the hardware state.”

I’ll try to clarify it...

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw
Quoted 60 lines · Oscar Mateo

On 05/03/2017 08:52 AM, Mika Kuoppala wrote:

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for itself for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

-Mika

Hi Mika,

I can double-check with the hardware architects, but word around here is that render state init has never stopped being a requirement. Where did you see in the BSpec that it is not required for CNL?

It would be great if you could refresh the answer and perhaps even get some answers to the 'why' parts.

In the "Context Descriptor Format" section, it says:
"Render CS Only: Render state need not be initialized; the Render Context Restore Inhibit bit in the Context/Save image in memory should be set to prevent restoring garbage render context."

-Mika

:_(

The same section also says:

Â

â**See the Logical Ring Context Format section for details.â**

Â

And then â**Logical Ring Context Formatâ** section goes on to say:

Quoted 7 lines

Â

â**It is tedious for software to populate the engine context as per the requirements, it is recommended to implicitly use engine to populate this portion of the context. [â*¦] Software must program all the state required to initialize the engine in the ring buffer which would initialize the hardware state.â**

Yet what the kernel programs is completely garbage for the user, so the user still has to program the initial GPU state to their own specifications. Just say no to policy in the kernel. We need a stronger reason than this, and if that was the only reason the original render state was merged, I am very angry.
-Chris

Signature · 5 lines
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw
Quoted 22 lines · Chris Wilson
Quoted 21 lines · Oscar Mateo

On 05/03/2017 08:52 AM, Mika Kuoppala wrote:

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for itself for correctness anyway.

Quoted 7 lines
Quoted 7 lines

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

Quoted 40 lines
Quoted 32 lines

-Mika

Hi Mika,

I can double-check with the hardware architects, but word around here is that render state init has never stopped being a requirement. Where did you see in the BSpec that it is not required for CNL?

It would be great if you could refresh the answer and perhaps even get some answers to the 'why' parts.

In the "Context Descriptor Format" section, it says:
"Render CS Only: Render state need not be initialized; the Render Context Restore Inhibit bit in the Context/Save image in memory should be set to prevent restoring garbage render context."

-Mika

:_(

The same section also says:

Â

â**See the Logical Ring Context Format section for details.â**

Â

And then â**Logical Ring Context Formatâ** section goes on to say:

Quoted 7 lines

Â

â**It is tedious for software to populate the engine context as per the requirements, it is recommended to implicitly use engine to populate this portion of the context. [â*¦] Software must program all the state required to initialize the engine in the ring buffer which would initialize the hardware state.â**

Quoted 5 lines

Yet what the kernel programs is completely garbage for the user, so the user still has to program the initial GPU state to their own specifications. Just say no to policy in the kernel. We need a stronger reason than this, and if that was the only reason the original render state was merged, I am very angry.

so... based on what I saw we need this,
I agree the justification is not good because I could never actually understand or make any sense out of this golden context.... But we need a solution to this impasse, to be able to move forward...

Quoted 8 lines

-Chris

--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#9 lore raw
Quoted 25 lines · Rodrigo Vivi
Quoted 24 lines · Chris Wilson
Quoted 23 lines · Oscar Mateo
    On 05/03/2017 08:52 AM, Mika Kuoppala wrote:

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for itself for correctness anyway.

Patch looks ok, but still question the sanity.

Quoted 9 lines
Quoted 5 lines
Quoted 5 lines

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

The best I could get from architecture (+Raf) is that setting valid and coherent values for the whole render state is required as soon as the context is created, no matter who does it. If you see failures when the KMD does not do it, that means the UMD must be missing something, right?

Quoted 43 lines
Quoted 38 lines
Quoted 31 lines

-Mika

Hi Mika,

I can double-check with the hardware architects, but word around here is that render state init has never stopped being a requirement. Where did you see in the BSpec that it is not required for CNL?

It would be great if you could refresh the answer and perhaps even get some answers to the 'why' parts.

In the "Context Descriptor Format" section, it says:
"Render CS Only: Render state need not be initialized; the Render Context Restore Inhibit bit in the Context/Save image in memory should be set to prevent restoring garbage render context."

-Mika

:_(

The same section also says:

Â

â**See the Logical Ring Context Format section for details.â**

Â

And then â**Logical Ring Context Formatâ** section goes on to say:

Quoted 7 lines

Â

â**It is tedious for software to populate the engine context as per the requirements, it is recommended to implicitly use engine to populate this portion of the context. [â*¦] Software must program all the state required to initialize the engine in the ring buffer which would initialize the hardware state.â**

Quoted 5 lines

Yet what the kernel programs is completely garbage for the user, so the user still has to program the initial GPU state to their own specifications. Just say no to policy in the kernel. We need a stronger reason than this, and if that was the only reason the original render state was merged, I am very angry.

Quoted 17 lines

so... based on what I saw we need this,
I agree the justification is not good because I could never actually understand or make any sense out of this golden context.... But we need a solution to this impasse, to be able to move forward...

Quoted 8 lines

-Chris

--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

Quoting Oscar Mateo (2017-07-14 15:52:59)

Quoted 39 lines · Rodrigo Vivi
Quoted 25 lines · Chris Wilson
Quoted 24 lines · Oscar Mateo
Quoted 23 lines · Mika Kuoppala

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for itself for correctness anyway.

Patch looks ok, but still question the sanity.

Quoted 9 lines
Quoted 5 lines
Quoted 5 lines

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

Quoted 4 lines

The best I could get from architecture (+Raf) is that setting valid and coherent values for the whole render state is required as soon as the context is created, no matter who does it. If you see failures when the KMD does not do it, that means the UMD must be missing something, right?

That is my initial response as well. The kernel does load one context, just so that the hardware always has space to write to on power saving. The only batch executed for it is the golden render state. Easy enough to only initialise that kernel context to isolate whether it is self-inflicted or that userspace overlooked something in its state management. (I have the view that even if userspace doesn't think it needs to use a particular bit of state today, tomorrow it will so will need it anyway!)
-Chris

Quoted 1 line

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw
Quoted 42 lines · Chris Wilson

Quoting Oscar Mateo (2017-07-14 15:52:59)

Quoted 33 lines · Rodrigo Vivi
Quoted 30 lines · Chris Wilson
Quoted 29 lines · Oscar Mateo
Quoted 28 lines · Mika Kuoppala

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for itself for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

Quoted 8 lines
Quoted 4 lines

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

The best I could get from architecture (+Raf) is that setting valid and coherent values for the whole render state is required as soon as the context is created, no matter who does it. If you see failures when the KMD does not do it, that means the UMD must be missing something, right?

Quoted 9 lines

That is my initial response as well. The kernel does load one context, just so that the hardware always has space to write to on power saving. The only batch executed for it is the golden render state. Easy enough to only initialise that kernel context to isolate whether it is self-inflicted or that userspace overlooked something in its state management. (I have the view that even if userspace doesn't think it needs to use a particular bit of state today, tomorrow it will so will need it anyway!)
-Chris

Rodrigo, you have access to a CNL: can you make this test? The idea is to find out if the root cause for the failures you were seeing is the kernel default context or in the UMD-created contexts.

Thanks,
Oscar

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw
Quoted 66 lines · Oscar Mateo
Quoted 51 lines · Chris Wilson

Quoting Oscar Mateo (2017-07-14 15:52:59)

Quoted 40 lines · Rodrigo Vivi
Quoted 36 lines
Quoted 32 lines · Chris Wilson
Quoted 30 lines · Oscar Mateo
     On 05/03/2017 08:52 AM, Mika Kuoppala wrote:

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for
itself
for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

Quoted 8 lines
Quoted 4 lines

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

The best I could get from architecture (+Raf) is that setting valid and coherent values for the whole render state is required as soon as the context is created, no matter who does it. If you see failures when the KMD does not do it, that means the UMD must be missing something, right?

Quoted 9 lines

That is my initial response as well. The kernel does load one context, just so that the hardware always has space to write to on power saving. The only batch executed for it is the golden render state. Easy enough to only initialise that kernel context to isolate whether it is self-inflicted or that userspace overlooked something in its state management. (I have the view that even if userspace doesn't think it needs to use a particular bit of state today, tomorrow it will so will need it anyway!)
-Chris

Quoted 3 lines

Rodrigo, you have access to a CNL: can you make this test? The idea is to find out if the root cause for the failures you were seeing is the kernel default context or in the UMD-created contexts.

I'm sorry for the delay on this one.

On the parts I have now I couldn't reproduce the issues I saw during power-on where null context helped.

But anyways apparently we need this right?!

What about the 4k+ sanity that Chris raised? Anything we should address first?

Quoted 4 lines

Thanks,
Oscar

Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#13 lore raw
Quoted 61 lines · Rodrigo Vivi
Quoted 57 lines · Oscar Mateo
Quoted 44 lines · Chris Wilson

Quoting Oscar Mateo (2017-07-14 15:52:59)

Quoted 35 lines · Rodrigo Vivi
Quoted 32 lines
Quoted 30 lines · Chris Wilson
Quoted 29 lines · Oscar Mateo

On 05/03/2017 08:52 AM, Mika Kuoppala wrote:

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure for
itself
for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

Quoted 8 lines
Quoted 4 lines

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

The best I could get from architecture (+Raf) is that setting valid and coherent values for the whole render state is required as soon as the context is created, no matter who does it. If you see failures when the KMD does not do it, that means the UMD must be missing something, right?

Quoted 9 lines

That is my initial response as well. The kernel does load one context, just so that the hardware always has space to write to on power saving. The only batch executed for it is the golden render state. Easy enough to only initialise that kernel context to isolate whether it is self-inflicted or that userspace overlooked something in its state management. (I have the view that even if userspace doesn't think it needs to use a particular bit of state today, tomorrow it will so will need it anyway!)
-Chris

Quoted 3 lines

Rodrigo, you have access to a CNL: can you make this test? The idea is to find out if the root cause for the failures you were seeing is the kernel default context or in the UMD-created contexts.

Quoted 8 lines

I'm sorry for the delay on this one.

On the parts I have now I couldn't reproduce the issues I saw during power-on where null context helped.

But anyways apparently we need this right?!

What about the 4k+ sanity that Chris raised? Anything we should address first?

I don't think Chris had any problem with the batchbuffer being bigger than 4k per se. His concern was: "why do we need to send this batchbuffer from the KMD at all if the UMD has to send something very similar anyway?".
Even if this was true (I haven't found anybody to confirm or deny it) there is still the question of the kernel context (which would never get initialized to valid values by the UMD). The test was to only send the golden state for the kernel context (and nothing else) and see if your issues went away.

Since your issues went away on their own without any golden state whatsoever... does that mean Mesa fixed something they were missing during the PO?

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#14 lore raw
Quoted 91 lines · Oscar Mateo
Quoted 78 lines · Rodrigo Vivi
Quoted 69 lines · Oscar Mateo
Quoted 54 lines · Chris Wilson

Quoting Oscar Mateo (2017-07-14 15:52:59)

Quoted 46 lines · Rodrigo Vivi
Quoted 34 lines
Quoted 30 lines · Chris Wilson
Quoted 28 lines · Oscar Mateo

On 05/03/2017 08:52 AM, Mika Kuoppala wrote:

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure
for
itself
for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

Quoted 5 lines

The best I could get from architecture (+Raf) is that setting valid and coherent values for the whole render state is required as soon as the context is created, no matter who does it. If you see failures when the KMD does not do it, that means the UMD must be missing something, right?

Quoted 9 lines

That is my initial response as well. The kernel does load one context, just so that the hardware always has space to write to on power saving. The only batch executed for it is the golden render state. Easy enough to only initialise that kernel context to isolate whether it is self-inflicted or that userspace overlooked something in its state management. (I have the view that even if userspace doesn't think it needs to use a particular bit of state today, tomorrow it will so will need it anyway!)
-Chris

Quoted 3 lines

Rodrigo, you have access to a CNL: can you make this test? The idea is to find out if the root cause for the failures you were seeing is the kernel default context or in the UMD-created contexts.

I'm sorry for the delay on this one.

Quoted 8 lines

On the parts I have now I couldn't reproduce the issues I saw during power-on
where null context helped.

But anyways apparently we need this right?!

What about the 4k+ sanity that Chris raised? Anything we should address first?

Quoted 6 lines

I don't think Chris had any problem with the batchbuffer being bigger than 4k per se. His concern was: "why do we need to send this batchbuffer from the KMD at all if the UMD has to send something very similar anyway?". Even if this was true (I haven't found anybody to confirm or deny it) there is still the question of the kernel context (which would never get initialized to valid values by the UMD).

so, chris, rv-b? acked-by?

Quoted 7 lines

The test was to only send the
golden state for the kernel context (and nothing else) and see if your issues went away.

Since your issues went away on their own without any golden state whatsoever... does that mean Mesa fixed something they were missing during the PO?

not sure what it was anymore

Quoted 2 lines
Signature · 6 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
maintainer
#15 lore raw
Quoted 92 lines · Rodrigo Vivi
Quoted 91 lines · Oscar Mateo
Quoted 86 lines · Rodrigo Vivi
Quoted 69 lines · Oscar Mateo
Quoted 54 lines · Chris Wilson

Quoting Oscar Mateo (2017-07-14 15:52:59)

Quoted 46 lines · Rodrigo Vivi
Quoted 34 lines
Quoted 30 lines · Chris Wilson
Quoted 28 lines · Oscar Mateo

On 05/03/2017 08:52 AM, Mika Kuoppala wrote:

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure
for
itself
for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

Quoted 5 lines

The best I could get from architecture (+Raf) is that setting valid and coherent values for the whole render state is required as soon as the context is created, no matter who does it. If you see failures when the KMD does not do it, that means the UMD must be missing something, right?

Quoted 9 lines

That is my initial response as well. The kernel does load one context, just so that the hardware always has space to write to on power saving. The only batch executed for it is the golden render state. Easy enough to only initialise that kernel context to isolate whether it is self-inflicted or that userspace overlooked something in its state management. (I have the view that even if userspace doesn't think it needs to use a particular bit of state today, tomorrow it will so will need it anyway!)
-Chris

Quoted 3 lines

Rodrigo, you have access to a CNL: can you make this test? The idea is to find out if the root cause for the failures you were seeing is the kernel default context or in the UMD-created contexts.

I'm sorry for the delay on this one.

On the parts I have now I couldn't reproduce the issues I saw during power-on
where null context helped.

But anyways apparently we need this right?!

What about the 4k+ sanity that Chris raised? Anything we should address first?

Quoted 8 lines
Quoted 6 lines

I don't think Chris had any problem with the batchbuffer being bigger than 4k per se. His concern was: "why do we need to send this batchbuffer from the KMD at all if the UMD has to send something very similar anyway?". Even if this was true (I haven't found anybody to confirm or deny it) there is still the question of the kernel context (which would never get initialized to valid values by the UMD).

so, chris, rv-b? acked-by?

chris, mika, oscar...
what should we do with this?
just discard, ignore and move on without the null context for gen10+?

Quoted 5 lines
Quoted 5 lines

The test was to only send the
golden state for the kernel context (and nothing else) and see if your issues went away.

Quoted 14 lines
Quoted 3 lines

Since your issues went away on their own without any golden state whatsoever... does that mean Mesa fixed something they were missing during the PO?

not sure what it was anymore

Quoted 2 lines
Signature · 2 lines
Rodrigo Vivi
Blog: http://blog.vivi.eng.br

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#16 lore raw

Quoting Rodrigo Vivi (2017-10-05 05:34:02)

Quoted 100 lines · Rodrigo Vivi
Quoted 99 lines · Oscar Mateo
Quoted 97 lines · Rodrigo Vivi
Quoted 78 lines
Quoted 69 lines · Oscar Mateo
Quoted 54 lines · Chris Wilson

Quoting Oscar Mateo (2017-07-14 15:52:59)

Quoted 46 lines · Rodrigo Vivi
Quoted 34 lines
Quoted 30 lines · Chris Wilson
Quoted 28 lines · Oscar Mateo

On 05/03/2017 08:52 AM, Mika Kuoppala wrote:

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure
for
itself
for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

Quoted 5 lines

The best I could get from architecture (+Raf) is that setting valid and coherent values for the whole render state is required as soon as the context is created, no matter who does it. If you see failures when the KMD does not do it, that means the UMD must be missing something, right?

Quoted 9 lines

That is my initial response as well. The kernel does load one context, just so that the hardware always has space to write to on power saving. The only batch executed for it is the golden render state. Easy enough to only initialise that kernel context to isolate whether it is self-inflicted or that userspace overlooked something in its state management. (I have the view that even if userspace doesn't think it needs to use a particular bit of state today, tomorrow it will so will need it anyway!)
-Chris

Quoted 3 lines

Rodrigo, you have access to a CNL: can you make this test? The idea is to find out if the root cause for the failures you were seeing is the kernel default context or in the UMD-created contexts.

I'm sorry for the delay on this one.

Quoted 8 lines

On the parts I have now I couldn't reproduce the issues I saw during power-on
where null context helped.

But anyways apparently we need this right?!

What about the 4k+ sanity that Chris raised? Anything we should address first?

I don't think Chris had any problem with the batchbuffer being bigger than 4k per se. His concern was: "why do we need to send this batchbuffer from the KMD at all if the UMD has to send something very similar anyway?". Even if this was true (I haven't found anybody to confirm or deny it) there is still the question of the kernel context (which would never get initialized to valid values by the UMD).

Quoted 5 lines
Quoted 1 line

so, chris, rv-b? acked-by?

chris, mika, oscar...
what should we do with this?
just discard, ignore and move on without the null context for gen10+?

If there's no requirement for us to have it, then let's break the cargo cult. Certainly userspace does not expect 3DSTATE to have any default value, unlike the defaults specified for mmio state (which is currently causing a huge upset). It's only if the bspec has wording that makes certain valid 3DSTATE (or GPGPU or MEDIA) mandatory for powercontext etc do we have to worry.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#17 lore raw

Quoting Chris Wilson (2017-10-10 11:25:38)

Quoted 107 lines

Quoting Rodrigo Vivi (2017-10-05 05:34:02)

Quoted 100 lines · Rodrigo Vivi
Quoted 99 lines · Oscar Mateo
Quoted 97 lines · Rodrigo Vivi
Quoted 78 lines
Quoted 69 lines · Oscar Mateo
Quoted 54 lines · Chris Wilson

Quoting Oscar Mateo (2017-07-14 15:52:59)

Quoted 46 lines · Rodrigo Vivi
Quoted 34 lines
Quoted 30 lines · Chris Wilson
Quoted 28 lines · Oscar Mateo

On 05/03/2017 08:52 AM, Mika Kuoppala wrote:

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure
for
itself
for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

Quoted 5 lines

The best I could get from architecture (+Raf) is that setting valid and coherent values for the whole render state is required as soon as the context is created, no matter who does it. If you see failures when the KMD does not do it, that means the UMD must be missing something, right?

Quoted 9 lines

That is my initial response as well. The kernel does load one context, just so that the hardware always has space to write to on power saving. The only batch executed for it is the golden render state. Easy enough to only initialise that kernel context to isolate whether it is self-inflicted or that userspace overlooked something in its state management. (I have the view that even if userspace doesn't think it needs to use a particular bit of state today, tomorrow it will so will need it anyway!)
-Chris

Quoted 3 lines

Rodrigo, you have access to a CNL: can you make this test? The idea is to find out if the root cause for the failures you were seeing is the kernel default context or in the UMD-created contexts.

I'm sorry for the delay on this one.

Quoted 8 lines

On the parts I have now I couldn't reproduce the issues I saw during power-on
where null context helped.

But anyways apparently we need this right?!

What about the 4k+ sanity that Chris raised? Anything we should address first?

I don't think Chris had any problem with the batchbuffer being bigger than 4k per se. His concern was: "why do we need to send this batchbuffer from the KMD at all if the UMD has to send something very similar anyway?". Even if this was true (I haven't found anybody to confirm or deny it) there is still the question of the kernel context (which would never get initialized to valid values by the UMD).

Quoted 5 lines
Quoted 1 line

so, chris, rv-b? acked-by?

chris, mika, oscar...
what should we do with this?
just discard, ignore and move on without the null context for gen10+?

Quoted 6 lines

If there's no requirement for us to have it, then let's break the cargo cult. Certainly userspace does not expect 3DSTATE to have any default value, unlike the defaults specified for mmio state (which is currently causing a huge upset). It's only if the bspec has wording that makes certain valid 3DSTATE (or GPGPU or MEDIA) mandatory for powercontext etc do we have to worry.

The other angle is that the proto context is entirely defined by us. New userspace contexts should not see any state that is outside of the context construction (either directly specified inside the image or implicitly from priv registers). In essence for lrc, we already define the golden render state but call it a context image instead. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#18 lore raw
Quoted 115 lines · Chris Wilson

Quoting Chris Wilson (2017-10-10 11:25:38)

Quoted 107 lines

Quoting Rodrigo Vivi (2017-10-05 05:34:02)

Quoted 100 lines · Rodrigo Vivi
Quoted 99 lines · Oscar Mateo
Quoted 97 lines · Rodrigo Vivi
Quoted 78 lines
Quoted 69 lines · Oscar Mateo
Quoted 54 lines · Chris Wilson

Quoting Oscar Mateo (2017-07-14 15:52:59)

Quoted 46 lines · Rodrigo Vivi
Quoted 34 lines
Quoted 30 lines · Chris Wilson
Quoted 28 lines · Oscar Mateo

On 05/03/2017 08:52 AM, Mika Kuoppala wrote:

Oscar Mateo [1]<[email protected]> writes:

On 05/02/2017 09:17 AM, Mika Kuoppala wrote:

Chris Wilson [2]<[email protected]> writes:

On Fri, Apr 28, 2017 at 09:11:06AM +0000, Oscar Mateo wrote:

The new batchbuffer for CNL surpasses the 4096 byte mark.

Cc Mika Kuoppala [3]<[email protected]>
Cc Ben Widawsky [4]<[email protected]>

Evil, 4k+ of nothing-ness that userspace then has to configure
for
itself
for correctness anyway.

Patch looks ok, but still question the sanity.

Is there a requirement for CNL to init the renderstate?

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines

I would like to drop the render state init from CNL if we can't find evidence that it needs it. Bspec indicates that it doesnt.

I'd like to drop as well, and I was hearing people around telling we didn't need anymore,
however without this during power on I had bad failures...

Quoted 5 lines

The best I could get from architecture (+Raf) is that setting valid and coherent values for the whole render state is required as soon as the context is created, no matter who does it. If you see failures when the KMD does not do it, that means the UMD must be missing something, right?

Quoted 9 lines

That is my initial response as well. The kernel does load one context, just so that the hardware always has space to write to on power saving. The only batch executed for it is the golden render state. Easy enough to only initialise that kernel context to isolate whether it is self-inflicted or that userspace overlooked something in its state management. (I have the view that even if userspace doesn't think it needs to use a particular bit of state today, tomorrow it will so will need it anyway!)
-Chris

Quoted 3 lines

Rodrigo, you have access to a CNL: can you make this test? The idea is to find out if the root cause for the failures you were seeing is the kernel default context or in the UMD-created contexts.

I'm sorry for the delay on this one.

Quoted 8 lines

On the parts I have now I couldn't reproduce the issues I saw during power-on
where null context helped.

But anyways apparently we need this right?!

What about the 4k+ sanity that Chris raised? Anything we should address first?

I don't think Chris had any problem with the batchbuffer being bigger than 4k per se. His concern was: "why do we need to send this batchbuffer from the KMD at all if the UMD has to send something very similar anyway?". Even if this was true (I haven't found anybody to confirm or deny it) there is still the question of the kernel context (which would never get initialized to valid values by the UMD).

Quoted 5 lines
Quoted 1 line

so, chris, rv-b? acked-by?

chris, mika, oscar...
what should we do with this?
just discard, ignore and move on without the null context for gen10+?

Quoted 6 lines

If there's no requirement for us to have it, then let's break the cargo cult. Certainly userspace does not expect 3DSTATE to have any default value, unlike the defaults specified for mmio state (which is currently causing a huge upset). It's only if the bspec has wording that makes certain valid 3DSTATE (or GPGPU or MEDIA) mandatory for powercontext etc do we have to worry.

Quoted 6 lines

The other angle is that the proto context is entirely defined by us. New userspace contexts should not see any state that is outside of the context construction (either directly specified inside the image or implicitly from priv registers). In essence for lrc, we already define the golden render state but call it a context image instead. -Chris

So, are you saying there is absolutely no risk of one userspace component leaving garbage on any of these registers and other component assuming it is null or valid do some RMW and end up with wrong setup?

I believe in the past there were cases like this between Mesa and Libva.

And if issues like this starts to appear back than apparently the debug is harder because it would be random the garbage left behind.

I understand the cargo part, but with many different userspaces out there using the GPU, the cost of kernel assuring the null is really low compared with the stability it can bring without relying on userspace.

I understand your part of breaking the cargo. But my doubt is, if we stop this after many years clearing this up we expect userspaces go ahead and all of them modify all their code to not make any assumptions on CNL+ regarding those states?

Thanks,
Rodrigo.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx