Skip to contentSkip to conversation

arm64: elf.h: Correct comment about READ_IMPLIES_EXEC propagation

PATCH New Ben Hutchings 2 participants 2 messages Oct 6, 2017 – Oct 9, 2017

Subsystems (2)
arm64 exec and binfmt
lore
Share & tools
lore

Ben Hutchings

author
#0 lore raw

PATCH 1/1 arm64: elf.h: Correct comment about READ_IMPLIES_EXEC propagation

Process personality always propagates across a fork(), but can change at an execve().

Signed-off-by Ben Hutchings <[email protected]>
---
 arch/arm64/include/asm/elf.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm64/include/asm/elf.h +2 -2
index 33be513ef24c..fac1c4de7898 100644
@@ -188,8 +188,8 @@ typedef compat_elf_greg_t		compat_elf_gregset_t[COMPAT_ELF_NGREG];
 
 #define compat_start_thread		compat_start_thread
 /*
- * Unlike the native SET_PERSONALITY macro, the compat version inherits
- * READ_IMPLIES_EXEC across a fork() since this is the behaviour on
+ * Unlike the native SET_PERSONALITY macro, the compat version maintains
+ * READ_IMPLIES_EXEC across an execve() since this is the behaviour on
  * arch/arm/.
  */
 #define COMPAT_SET_PERSONALITY(ex)					\

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171006/041ef202/attachment.sig>

#1 lore raw

PATCH 1/1 arm64: elf.h: Correct comment about READ_IMPLIES_EXEC propagation

Quoted 7 lines · Ben Hutchings

Process personality always propagates across a fork(), but can change at an execve().

Signed-off-by Ben Hutchings <[email protected]>
---
 arch/arm64/include/asm/elf.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

You're right, the comment is sloppy. I'll pick this up for 4.15.

Will

Quoted 22 lines
arch/arm64/include/asm/elf.h +2 -2
index 33be513ef24c..fac1c4de7898 100644
@@ -188,8 +188,8 @@ typedef compat_elf_greg_t		compat_elf_gregset_t[COMPAT_ELF_NGREG];
 
 #define compat_start_thread		compat_start_thread
 /*
- * Unlike the native SET_PERSONALITY macro, the compat version inherits
- * READ_IMPLIES_EXEC across a fork() since this is the behaviour on
+ * Unlike the native SET_PERSONALITY macro, the compat version maintains
+ * READ_IMPLIES_EXEC across an execve() since this is the behaviour on
  * arch/arm/.
  */
 #define COMPAT_SET_PERSONALITY(ex)					\

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel