Skip to contentSkip to conversation

drm/i915: Use rcu instead of stop_machine

PATCH In review Daniel Vetter 6 participants 12 messages Oct 5, 2017 – Oct 6, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Use rcu instead of stop_machine

stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work around it.

This patch here is just a suggestion for how to fix it up, possible changes needed to make it actually work:

- Set the nop_submit_request first for _all_ engines, before proceeding.

- Make sure engine->cancel_requests copes with the possibility that not all tests have consistently used the new or old version. I dont think this is a problem, since the same can happen really with the stop_machine() locking - stop_machine also doesn't give you any kind of global ordering against other cpu threads, it just makes them stop.

This patch tries to address the locking snafu from

commit 20e4933c478a1ca694b38fa4ac44d99e659941f5

Author: Chris Wilson <[email protected]>
Date:   Tue Nov 22 14:41:21 2016 +0000

drm/i915: Stop the machine as we install the wedged submit_request handler

Chris said parts of the reasons for going with stop_machine() was that it's no overhead for the fast-path. But these callbacks use irqsave spinlocks and do a bunch of MMIO, and rcu_read_lock is _real_ fast.

Cc Chris Wilson <[email protected]>
Cc Mika Kuoppala <[email protected]>
---
 drivers/gpu/drm/i915/i915_gem.c                   | 18 +++++-------------
 drivers/gpu/drm/i915/i915_gem_request.c           |  2 ++
 drivers/gpu/drm/i915/selftests/i915_gem_request.c |  2 ++
 3 files changed, 9 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +5 -13
index ab8c6946fea4..0b260e576b4b 100644
@@ -3022,13 +3022,13 @@ static void nop_submit_request(struct drm_i915_gem_request *request)
 
 static void engine_set_wedged(struct intel_engine_cs *engine)
 {
+	engine->submit_request = nop_submit_request;
+
 	/* We need to be sure that no thread is running the old callback as
 	 * we install the nop handler (otherwise we would submit a request
-	 * to hardware that will never complete). In order to prevent this
-	 * race, we wait until the machine is idle before making the swap
-	 * (using stop_machine()).
+	 * to hardware that will never complete).
 	 */
-	engine->submit_request = nop_submit_request;
+	synchronize_rcu();
 
 	/* Mark all executing requests as skipped */
 	engine->cancel_requests(engine);
@@ -3041,9 +3041,8 @@ static void engine_set_wedged(struct intel_engine_cs *engine)
 				       intel_engine_last_submit(engine));
 }
 
-static int __i915_gem_set_wedged_BKL(void *data)
+void i915_gem_set_wedged(struct drm_i915_private *i915)
 {
-	struct drm_i915_private *i915 = data;
 	struct intel_engine_cs *engine;
 	enum intel_engine_id id;
 
@@ -3052,13 +3051,6 @@ static int __i915_gem_set_wedged_BKL(void *data)
 
 	set_bit(I915_WEDGED, &i915->gpu_error.flags);
 	wake_up_all(&i915->gpu_error.reset_queue);
-
-	return 0;
-}
-
-void i915_gem_set_wedged(struct drm_i915_private *dev_priv)
-{
-	stop_machine(__i915_gem_set_wedged_BKL, dev_priv, NULL);
 }
 
 bool i915_gem_unset_wedged(struct drm_i915_private *i915)
drivers/gpu/drm/i915/i915_gem_request.c +2 -0
index b100b38f1dd2..ef78a85cb845 100644
@@ -556,7 +556,9 @@ submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)
 	switch (state) {
 	case FENCE_COMPLETE:
 		trace_i915_gem_request_submit(request);
+		rcu_read_lock();
 		request->engine->submit_request(request);
+		rcu_read_unlock();
 		break;
 
 	case FENCE_FREE:
drivers/gpu/drm/i915/selftests/i915_gem_request.c +2 -0
index 78b9f811707f..a999161e8db1 100644
@@ -215,7 +215,9 @@ static int igt_request_rewind(void *arg)
 	}
 	i915_gem_request_get(vip);
 	i915_add_request(vip);
+	rcu_read_lock();
 	request->engine->submit_request(request);
+	rcu_read_unlock();
 
 	mutex_unlock(&i915->drm.struct_mutex);
 
Signature · 6 lines
2.14.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

Quoting Daniel Vetter (2017-10-05 15:09:48)

Quoted 10 lines

stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work around it.

This patch here is just a suggestion for how to fix it up, possible changes needed to make it actually work:

- Set the nop_submit_request first for _all_ engines, before proceeding.

Quoted 8 lines

- Make sure engine->cancel_requests copes with the possibility that not all tests have consistently used the new or old version. I dont think this is a problem, since the same can happen really with the stop_machine() locking - stop_machine also doesn't give you any kind of global ordering against other cpu threads, it just makes them stop.

This patch tries to address the locking snafu from

There's a locking snafu in the code?

Quoted 8 lines

commit 20e4933c478a1ca694b38fa4ac44d99e659941f5

Author: Chris Wilson <[email protected]>
Date:   Tue Nov 22 14:41:21 2016 +0000

drm/i915: Stop the machine as we install the wedged submit_request handler

Chris said parts of the reasons for going with stop_machine() was that it's no overhead for the fast-path.

More than that, you don't even have to think about it. It's a one off event that changes execution paths. I actually never thought about putting the lock mechanism around the caller (that does prevent the issue I was dreading of being inside the callback as it changed), it is still magic that has nothing to do with the code flow. What variable should we document as being rcu protected, (*engine->submit_request)()?

I'm definitely not sold on having set-wedge dictate terms to the rest of the code.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 31 lines · Chris Wilson

Quoting Daniel Vetter (2017-10-05 15:09:48)

Quoted 10 lines

stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work around it.

This patch here is just a suggestion for how to fix it up, possible changes needed to make it actually work:

- Set the nop_submit_request first for _all_ engines, before proceeding.

Quoted 8 lines

- Make sure engine->cancel_requests copes with the possibility that not all tests have consistently used the new or old version. I dont think this is a problem, since the same can happen really with the stop_machine() locking - stop_machine also doesn't give you any kind of global ordering against other cpu threads, it just makes them stop.

This patch tries to address the locking snafu from

There's a locking snafu in the code?

Quoted 8 lines

commit 20e4933c478a1ca694b38fa4ac44d99e659941f5

Author: Chris Wilson <[email protected]>
Date:   Tue Nov 22 14:41:21 2016 +0000

drm/i915: Stop the machine as we install the wedged submit_request handler

Chris said parts of the reasons for going with stop_machine() was that it's no overhead for the fast-path.

Quoted 6 lines

More than that, you don't even have to think about it. It's a one off event that changes execution paths. I actually never thought about putting the lock mechanism around the caller (that does prevent the issue I was dreading of being inside the callback as it changed), it is still magic that has nothing to do with the code flow. What variable should we document as being rcu protected, (*engine->submit_request)()?

Yeah, engine->submit_request would be the one, except it shouldn't use rcu_assign_pointer/rcu_dereference since we don't need those barriers, ever - the .text doesn't change after all. That's why I didn't splatter the sparse annotations all over it. In a way we don't need the data barriers of rcu, but really only the "everyone has passed the critical section now" part of it.

Quoted 2 lines

I'm definitely not sold on having set-wedge dictate terms to the rest of the code.

Well, it sounds like tglx would very much prefer we clean this locking inversion up on our side and not get them to break the cycle. Not what I wanted Thomas to look at, but since I botched it and attached the wrong splat we got the answer for this patch here, and it seems to be "don't do that".
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

Quoting Daniel Vetter (2017-10-05 17:12:35)

Quoted 46 lines · Chris Wilson
Quoted 31 lines

Quoting Daniel Vetter (2017-10-05 15:09:48)

Quoted 10 lines

stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work around it.

This patch here is just a suggestion for how to fix it up, possible changes needed to make it actually work:

- Set the nop_submit_request first for _all_ engines, before proceeding.

Quoted 8 lines

- Make sure engine->cancel_requests copes with the possibility that not all tests have consistently used the new or old version. I dont think this is a problem, since the same can happen really with the stop_machine() locking - stop_machine also doesn't give you any kind of global ordering against other cpu threads, it just makes them stop.

This patch tries to address the locking snafu from

There's a locking snafu in the code?

Quoted 8 lines

commit 20e4933c478a1ca694b38fa4ac44d99e659941f5

Author: Chris Wilson <[email protected]>
Date:   Tue Nov 22 14:41:21 2016 +0000

drm/i915: Stop the machine as we install the wedged submit_request handler

Chris said parts of the reasons for going with stop_machine() was that it's no overhead for the fast-path.

Quoted 6 lines

More than that, you don't even have to think about it. It's a one off event that changes execution paths. I actually never thought about putting the lock mechanism around the caller (that does prevent the issue I was dreading of being inside the callback as it changed), it is still magic that has nothing to do with the code flow. What variable should we document as being rcu protected, (*engine->submit_request)()?

Yeah, engine->submit_request would be the one, except it shouldn't use rcu_assign_pointer/rcu_dereference since we don't need those barriers, ever - the .text doesn't change after all. That's why I didn't splatter the sparse annotations all over it. In a way we don't need the data barriers of rcu, but really only the "everyone has passed the critical section now" part of it.

Quoted 8 lines
Quoted 2 lines

I'm definitely not sold on having set-wedge dictate terms to the rest of the code.

Well, it sounds like tglx would very much prefer we clean this locking inversion up on our side and not get them to break the cycle. Not what I wanted Thomas to look at, but since I botched it and attached the wrong splat we got the answer for this patch here, and it seems to be "don't do that".

The analogy is with kernel live-patching (which is what we are doing here). Should every module in the kernel manually markup itself to support the esoteric feature, or should the feature support the wider kernel?
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw
Quoted 56 lines · Chris Wilson

Quoting Daniel Vetter (2017-10-05 17:12:35)

Quoted 46 lines · Chris Wilson
Quoted 31 lines

Quoting Daniel Vetter (2017-10-05 15:09:48)

Quoted 10 lines

stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work around it.

This patch here is just a suggestion for how to fix it up, possible changes needed to make it actually work:

- Set the nop_submit_request first for _all_ engines, before proceeding.

Quoted 8 lines

- Make sure engine->cancel_requests copes with the possibility that not all tests have consistently used the new or old version. I dont think this is a problem, since the same can happen really with the stop_machine() locking - stop_machine also doesn't give you any kind of global ordering against other cpu threads, it just makes them stop.

This patch tries to address the locking snafu from

There's a locking snafu in the code?

Quoted 8 lines

commit 20e4933c478a1ca694b38fa4ac44d99e659941f5

Author: Chris Wilson <[email protected]>
Date:   Tue Nov 22 14:41:21 2016 +0000

drm/i915: Stop the machine as we install the wedged submit_request handler

Chris said parts of the reasons for going with stop_machine() was that it's no overhead for the fast-path.

Quoted 6 lines

More than that, you don't even have to think about it. It's a one off event that changes execution paths. I actually never thought about putting the lock mechanism around the caller (that does prevent the issue I was dreading of being inside the callback as it changed), it is still magic that has nothing to do with the code flow. What variable should we document as being rcu protected, (*engine->submit_request)()?

Yeah, engine->submit_request would be the one, except it shouldn't use rcu_assign_pointer/rcu_dereference since we don't need those barriers, ever - the .text doesn't change after all. That's why I didn't splatter the sparse annotations all over it. In a way we don't need the data barriers of rcu, but really only the "everyone has passed the critical section now" part of it.

Quoted 8 lines
Quoted 2 lines

I'm definitely not sold on having set-wedge dictate terms to the rest of the code.

Well, it sounds like tglx would very much prefer we clean this locking inversion up on our side and not get them to break the cycle. Not what I wanted Thomas to look at, but since I botched it and attached the wrong splat we got the answer for this patch here, and it seems to be "don't do that".

Quoted 4 lines

The analogy is with kernel live-patching (which is what we are doing here). Should every module in the kernel manually markup itself to support the esoteric feature, or should the feature support the wider kernel?

This is completely different from kernel live patching, where the actual instructions get changed while we execute them. You'd need to annotate every single IP load, which is impossible. This here seems to be much more a bog standard critical section, restrict to a very small piece of code (the hw submit functions essentially), and if we can't get that to work then our locking is seriously in bad shape. stop_machine really isn't a valid locking mechanism, except in very extreme cases where there's really no other solution.

If you disagree, then pls convince Thomas Gleixner that he needs to fix this on his end.

The other bit is that lockdep is warn_once, so every week we have this in our CI is a week with reduced test coverage. Even if Thomas fixes this in the cpu hotplug code I expect it'll take longer than to get some interim solution in here in i915, since it doesn't sound trivial at all to fix this on the cpu hotplug side either.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw
Quoted 4 lines · Daniel Vetter
Quoted 3 lines · Chris Wilson
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

This patch tries to address the locking snafu from

There's a locking snafu in the code?

The lock problem exists definitely. We did not introduce new dependencies through the hotplug locking rework. They've been there forever.

What's new is that lockdep became smarter and we exposed the hotplug lock to lockdep fully. So yes, we need to address them no matter what.

While we might have a solution for that devfs issue, there are other ways to expose this kind of problem when you have code pathes which come from user space and end up taking the hotplug lock.

Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 2 lines

Chris said parts of the reasons for going with stop_machine() was that it's no overhead for the fast-path.

More than that, you don't even have to think about it. It's a one off event that changes execution paths. I actually never thought about putting the lock mechanism around the caller (that does prevent the issue I was dreading of being inside the callback as it changed), it is still magic that has nothing to do with the code flow. What variable should we document as being rcu protected, (*engine->submit_request)()?

stop_machine() is one of the biggest hammers we have in the kernel. We try to avoid it where ever we can. It's the least resort for problems which cannot be solved otherwise.

Quoted 11 lines
Quoted 10 lines
Quoted 5 lines

Well, it sounds like tglx would very much prefer we clean this locking inversion up on our side and not get them to break the cycle. Not what I wanted Thomas to look at, but since I botched it and attached the wrong splat we got the answer for this patch here, and it seems to be "don't do that".

The analogy is with kernel live-patching (which is what we are doing here). Should every module in the kernel manually markup itself to support the esoteric feature, or should the feature support the wider kernel?

Quoted 8 lines

This is completely different from kernel live patching, where the actual instructions get changed while we execute them. You'd need to annotate every single IP load, which is impossible. This here seems to be much more a bog standard critical section, restrict to a very small piece of code (the hw submit functions essentially), and if we can't get that to work then our locking is seriously in bad shape. stop_machine really isn't a valid locking mechanism, except in very extreme cases where there's really no other solution.

Correct. This has absolutely nothing to do with life patching. It's a bug standard serialization issue which does not require the big hammer of stop_machine().

Thanks,

tglx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
In reply to Daniel Vetter
Quoted 43 lines · Daniel Vetter

stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work around it.

This patch here is just a suggestion for how to fix it up, possible changes needed to make it actually work:

- Set the nop_submit_request first for _all_ engines, before proceeding.

- Make sure engine->cancel_requests copes with the possibility that not all tests have consistently used the new or old version. I dont think this is a problem, since the same can happen really with the stop_machine() locking - stop_machine also doesn't give you any kind of global ordering against other cpu threads, it just makes them stop.

This patch tries to address the locking snafu from

commit 20e4933c478a1ca694b38fa4ac44d99e659941f5

Author: Chris Wilson <[email protected]>
Date:   Tue Nov 22 14:41:21 2016 +0000

drm/i915: Stop the machine as we install the wedged submit_request handler

Chris said parts of the reasons for going with stop_machine() was that it's no overhead for the fast-path. But these callbacks use irqsave spinlocks and do a bunch of MMIO, and rcu_read_lock is _real_ fast.

Cc Chris Wilson <[email protected]>
Cc Mika Kuoppala <[email protected]>
---
  drivers/gpu/drm/i915/i915_gem.c                   | 18 +++++-------------
  drivers/gpu/drm/i915/i915_gem_request.c           |  2 ++
  drivers/gpu/drm/i915/selftests/i915_gem_request.c |  2 ++
  3 files changed, 9 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +0 -0
index ab8c6946fea4..0b260e576b4b 100644

drivers/gpu/drm/i915/i915_gem.c static void nop_submit_request(struct drm_i915_gem_request *request) · line 3025

Quoted 4 lines
drivers/gpu/drm/i915/i915_gem.c +1 -0
@@ -3022,13 +3022,13 @@ static void nop_submit_request(struct drm_i915_gem_request *request)
 
  static void engine_set_wedged(struct intel_engine_cs *engine)
  {
+	engine->submit_request = nop_submit_request;

Should this be rcu_assign_pointer?

drivers/gpu/drm/i915/i915_gem.c static void nop_submit_request(struct drm_i915_gem_request *request) · line 3031

Quoted 10 lines
drivers/gpu/drm/i915/i915_gem.c +3 -4
+
  	/* We need to be sure that no thread is running the old callback as
  	 * we install the nop handler (otherwise we would submit a request
-	 * to hardware that will never complete). In order to prevent this
-	 * race, we wait until the machine is idle before making the swap
-	 * (using stop_machine()).
+	 * to hardware that will never complete).
  	 */
-	engine->submit_request = nop_submit_request;
+	synchronize_rcu();

Consumers of this are running in irq disabled or softirq. Does this mean we would need synchronize_rcu_bh? Would either guarantee all tasklets and irq handlers have exited?

Quoted 32 lines
drivers/gpu/drm/i915/i915_gem.c +1 -9
  	/* Mark all executing requests as skipped */
  	engine->cancel_requests(engine);
@@ -3041,9 +3041,8 @@ static void engine_set_wedged(struct intel_engine_cs *engine)
  				       intel_engine_last_submit(engine));
  }
 
-static int __i915_gem_set_wedged_BKL(void *data)
+void i915_gem_set_wedged(struct drm_i915_private *i915)
  {
-	struct drm_i915_private *i915 = data;
  	struct intel_engine_cs *engine;
  	enum intel_engine_id id;
 
@@ -3052,13 +3051,6 @@ static int __i915_gem_set_wedged_BKL(void *data)
 
  	set_bit(I915_WEDGED, &i915->gpu_error.flags);
  	wake_up_all(&i915->gpu_error.reset_queue);
-
-	return 0;
-}
-
-void i915_gem_set_wedged(struct drm_i915_private *dev_priv)
-{
-	stop_machine(__i915_gem_set_wedged_BKL, dev_priv, NULL);
  }
 
  bool i915_gem_unset_wedged(struct drm_i915_private *i915)
drivers/gpu/drm/i915/i915_gem_request.c +0 -0
index b100b38f1dd2..ef78a85cb845 100644

drivers/gpu/drm/i915/i915_gem_request.c submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state) · line 561

Quoted 6 lines
drivers/gpu/drm/i915/i915_gem_request.c +2 -0
@@ -556,7 +556,9 @@ submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)
  	switch (state) {
  	case FENCE_COMPLETE:
  		trace_i915_gem_request_submit(request);
+		rcu_read_lock();
  		request->engine->submit_request(request);
+		rcu_read_unlock();

And _bh for these? Although this already runs with preemption off, but I guess it is good for documentation.

Regards,

Tvrtko

Quoted 9 lines
drivers/gpu/drm/i915/i915_gem_request.c +0 -0
  		break;
 
  	case FENCE_FREE:
drivers/gpu/drm/i915/selftests/i915_gem_request.c +0 -0
index 78b9f811707f..a999161e8db1 100644

drivers/gpu/drm/i915/selftests/i915_gem_request.c static int igt_request_rewind(void *arg) · line 223

Quoted 9 lines
drivers/gpu/drm/i915/selftests/i915_gem_request.c +2 -0
@@ -215,7 +215,9 @@ static int igt_request_rewind(void *arg)
  	}
  	i915_gem_request_get(vip);
  	i915_add_request(vip);
+	rcu_read_lock();
  	request->engine->submit_request(request);
+	rcu_read_unlock();
 
  	mutex_unlock(&i915->drm.struct_mutex);
 

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw
Quoted 40 lines · Tvrtko Ursulin
Quoted 38 lines · Daniel Vetter

stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work around it.

This patch here is just a suggestion for how to fix it up, possible changes needed to make it actually work:

- Set the nop_submit_request first for _all_ engines, before proceeding.

- Make sure engine->cancel_requests copes with the possibility that not all tests have consistently used the new or old version. I dont think this is a problem, since the same can happen really with the stop_machine() locking - stop_machine also doesn't give you any kind of global ordering against other cpu threads, it just makes them stop.

This patch tries to address the locking snafu from

commit 20e4933c478a1ca694b38fa4ac44d99e659941f5

Author: Chris Wilson <[email protected]>
Date:   Tue Nov 22 14:41:21 2016 +0000

drm/i915: Stop the machine as we install the wedged submit_request handler

Chris said parts of the reasons for going with stop_machine() was that it's no overhead for the fast-path. But these callbacks use irqsave spinlocks and do a bunch of MMIO, and rcu_read_lock is _real_ fast.

Cc Chris Wilson <[email protected]>
Cc Mika Kuoppala <[email protected]>
---
  drivers/gpu/drm/i915/i915_gem.c                   | 18 +++++-------------
  drivers/gpu/drm/i915/i915_gem_request.c           |  2 ++
  drivers/gpu/drm/i915/selftests/i915_gem_request.c |  2 ++
  3 files changed, 9 insertions(+), 13 deletions(-)
Quoted 10 lines

drivers/gpu/drm/i915/i915_gem.c static void nop_submit_request(struct drm_i915_gem_request *request) · line 3024

Quoted 8 lines
drivers/gpu/drm/i915/i915_gem.c +1 -0
index ab8c6946fea4..0b260e576b4b 100644
@@ -3022,13 +3022,13 @@ static void nop_submit_request(struct drm_i915_gem_request *request)
  static void engine_set_wedged(struct intel_engine_cs *engine)
  {
+	engine->submit_request = nop_submit_request;

Should this be rcu_assign_pointer?

Those provide additional barriers, needed when you change/allocate the stuff you're pointing to. We point to immutable functions, so shouldn't be necessary (and would be confusing imo).

Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/i915/i915_gem.c +1 -3
+
  	/* We need to be sure that no thread is running the old callback as
  	 * we install the nop handler (otherwise we would submit a request
-	 * to hardware that will never complete). In order to prevent this
-	 * race, we wait until the machine is idle before making the swap
-	 * (using stop_machine()).
Quoted 8 lines

drivers/gpu/drm/i915/i915_gem.c static void nop_submit_request(struct drm_i915_gem_request *request) · line 3031

Quoted 4 lines
drivers/gpu/drm/i915/i915_gem.c +2 -1
+	 * to hardware that will never complete).
  	 */
-	engine->submit_request = nop_submit_request;
+	synchronize_rcu();

Consumers of this are running in irq disabled or softirq. Does this mean we would need synchronize_rcu_bh? Would either guarantee all tasklets and irq handlers have exited?

Oh ... tbh I didn't even digg that deep (much less ran this stuff). This really is an RFC so people with real clue could say whether it has a chance of working or not.

Looking at rcu docs we don't want _bh variants, since rcu_read_lock should be safe in even hardirq context. _bh and _sched otoh require that all critical sections are either in bottom halfs or hardirq context, since they treat scheduling of those as a grace period.

Cheers, Daniel

Quoted 57 lines
Quoted 28 lines
drivers/gpu/drm/i915/i915_gem.c +1 -9
  	/* Mark all executing requests as skipped */
  	engine->cancel_requests(engine);
@@ -3041,9 +3041,8 @@ static void engine_set_wedged(struct intel_engine_cs *engine)
  				       intel_engine_last_submit(engine));
  }
-static int __i915_gem_set_wedged_BKL(void *data)
+void i915_gem_set_wedged(struct drm_i915_private *i915)
  {
-	struct drm_i915_private *i915 = data;
  	struct intel_engine_cs *engine;
  	enum intel_engine_id id;
@@ -3052,13 +3051,6 @@ static int __i915_gem_set_wedged_BKL(void *data)
  	set_bit(I915_WEDGED, &i915->gpu_error.flags);
  	wake_up_all(&i915->gpu_error.reset_queue);
-
-	return 0;
-}
-
-void i915_gem_set_wedged(struct drm_i915_private *dev_priv)
-{
-	stop_machine(__i915_gem_set_wedged_BKL, dev_priv, NULL);
  }
  bool i915_gem_unset_wedged(struct drm_i915_private *i915)
drivers/gpu/drm/i915/i915_gem_request.c +0 -0
index b100b38f1dd2..ef78a85cb845 100644

drivers/gpu/drm/i915/i915_gem_request.c submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state) · line 561

Quoted 6 lines
drivers/gpu/drm/i915/i915_gem_request.c +2 -0
@@ -556,7 +556,9 @@ submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)
  	switch (state) {
  	case FENCE_COMPLETE:
  		trace_i915_gem_request_submit(request);
+		rcu_read_lock();
  		request->engine->submit_request(request);
+		rcu_read_unlock();

And _bh for these? Although this already runs with preemption off, but I guess it is good for documentation.

Regards,

Tvrtko

Quoted 15 lines
drivers/gpu/drm/i915/i915_gem_request.c +0 -0
  		break;
  	case FENCE_FREE:
drivers/gpu/drm/i915/selftests/i915_gem_request.c +2 -0
index 78b9f811707f..a999161e8db1 100644
@@ -215,7 +215,9 @@ static int igt_request_rewind(void *arg)
  	}
  	i915_gem_request_get(vip);
  	i915_add_request(vip);
+	rcu_read_lock();
  	request->engine->submit_request(request);
+	rcu_read_unlock();
  	mutex_unlock(&i915->drm.struct_mutex);
 
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#8 lore raw
Quoted 52 lines · Daniel Vetter
Quoted 40 lines · Tvrtko Ursulin
Quoted 38 lines · Daniel Vetter

stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work around it.

This patch here is just a suggestion for how to fix it up, possible changes needed to make it actually work:

- Set the nop_submit_request first for _all_ engines, before proceeding.

- Make sure engine->cancel_requests copes with the possibility that not all tests have consistently used the new or old version. I dont think this is a problem, since the same can happen really with the stop_machine() locking - stop_machine also doesn't give you any kind of global ordering against other cpu threads, it just makes them stop.

This patch tries to address the locking snafu from

commit 20e4933c478a1ca694b38fa4ac44d99e659941f5

Author: Chris Wilson <[email protected]>
Date:   Tue Nov 22 14:41:21 2016 +0000

drm/i915: Stop the machine as we install the wedged submit_request handler

Chris said parts of the reasons for going with stop_machine() was that it's no overhead for the fast-path. But these callbacks use irqsave spinlocks and do a bunch of MMIO, and rcu_read_lock is _real_ fast.

Cc Chris Wilson <[email protected]>
Cc Mika Kuoppala <[email protected]>
---
   drivers/gpu/drm/i915/i915_gem.c                   | 18 +++++-------------
   drivers/gpu/drm/i915/i915_gem_request.c           |  2 ++
   drivers/gpu/drm/i915/selftests/i915_gem_request.c |  2 ++
   3 files changed, 9 insertions(+), 13 deletions(-)
Quoted 10 lines

drivers/gpu/drm/i915/i915_gem.c static void nop_submit_request(struct drm_i915_gem_request *request) · line 3024

Quoted 8 lines
drivers/gpu/drm/i915/i915_gem.c +1 -0
index ab8c6946fea4..0b260e576b4b 100644
@@ -3022,13 +3022,13 @@ static void nop_submit_request(struct drm_i915_gem_request *request)
   static void engine_set_wedged(struct intel_engine_cs *engine)
   {
+	engine->submit_request = nop_submit_request;

Should this be rcu_assign_pointer?

Quoted 3 lines

Those provide additional barriers, needed when you change/allocate the stuff you're pointing to. We point to immutable functions, so shouldn't be necessary (and would be confusing imo).

Ah ok. Any barriers then? Or synchronize_rcu implies them all?

Quoted 15 lines
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/i915/i915_gem.c +1 -3
+
   	/* We need to be sure that no thread is running the old callback as
   	 * we install the nop handler (otherwise we would submit a request
-	 * to hardware that will never complete). In order to prevent this
-	 * race, we wait until the machine is idle before making the swap
-	 * (using stop_machine()).
Quoted 8 lines

drivers/gpu/drm/i915/i915_gem.c static void nop_submit_request(struct drm_i915_gem_request *request) · line 3031

Quoted 4 lines
drivers/gpu/drm/i915/i915_gem.c +2 -1
+	 * to hardware that will never complete).
   	 */
-	engine->submit_request = nop_submit_request;
+	synchronize_rcu();

Consumers of this are running in irq disabled or softirq. Does this mean we would need synchronize_rcu_bh? Would either guarantee all tasklets and irq handlers have exited?

Quoted 8 lines

Oh ... tbh I didn't even digg that deep (much less ran this stuff). This really is an RFC so people with real clue could say whether it has a chance of working or not.

Looking at rcu docs we don't want _bh variants, since rcu_read_lock should be safe in even hardirq context. _bh and _sched otoh require that all critical sections are either in bottom halfs or hardirq context, since they treat scheduling of those as a grace period.

rcu_read_unlock might schedule (via preempt_enable) so I don't think we can use them from the fence callbacks.

And _bh is indeed only for softirq while we need hard and soft. So I am not sure which one we could use.

It sounds to me any would be wrong and if we wanted to drop stop_machine we would simply have to use nothing. But then we couldn't be certain there are no more new requests queued after wedged has been set.

Maybe I am missing something, not sure.
Regards,

Tvrtko

Quoted 44 lines

Cheers, Daniel

Quoted 42 lines
Quoted 28 lines
drivers/gpu/drm/i915/i915_gem.c +1 -9
   	/* Mark all executing requests as skipped */
   	engine->cancel_requests(engine);
@@ -3041,9 +3041,8 @@ static void engine_set_wedged(struct intel_engine_cs *engine)
   				       intel_engine_last_submit(engine));
   }
-static int __i915_gem_set_wedged_BKL(void *data)
+void i915_gem_set_wedged(struct drm_i915_private *i915)
   {
-	struct drm_i915_private *i915 = data;
   	struct intel_engine_cs *engine;
   	enum intel_engine_id id;
@@ -3052,13 +3051,6 @@ static int __i915_gem_set_wedged_BKL(void *data)
   	set_bit(I915_WEDGED, &i915->gpu_error.flags);
   	wake_up_all(&i915->gpu_error.reset_queue);
-
-	return 0;
-}
-
-void i915_gem_set_wedged(struct drm_i915_private *dev_priv)
-{
-	stop_machine(__i915_gem_set_wedged_BKL, dev_priv, NULL);
   }
   bool i915_gem_unset_wedged(struct drm_i915_private *i915)
drivers/gpu/drm/i915/i915_gem_request.c +0 -0
index b100b38f1dd2..ef78a85cb845 100644

drivers/gpu/drm/i915/i915_gem_request.c submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state) · line 561

Quoted 6 lines
drivers/gpu/drm/i915/i915_gem_request.c +2 -0
@@ -556,7 +556,9 @@ submit_notify(struct i915_sw_fence *fence, enum i915_sw_fence_notify state)
   	switch (state) {
   	case FENCE_COMPLETE:
   		trace_i915_gem_request_submit(request);
+		rcu_read_lock();
   		request->engine->submit_request(request);
+		rcu_read_unlock();

And _bh for these? Although this already runs with preemption off, but I guess it is good for documentation.

Regards,

Tvrtko

Quoted 16 lines
Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/i915/i915_gem_request.c +0 -0
   		break;
   	case FENCE_FREE:
drivers/gpu/drm/i915/selftests/i915_gem_request.c +0 -0
index 78b9f811707f..a999161e8db1 100644
@@ -215,7 +215,9 @@ static int igt_request_rewind(void *arg)
Quoted 8 lines

drivers/gpu/drm/i915/selftests/i915_gem_request.c static int igt_request_rewind(void *arg) · line 223

Quoted 8 lines
drivers/gpu/drm/i915/selftests/i915_gem_request.c +2 -0
   	}
   	i915_gem_request_get(vip);
   	i915_add_request(vip);
+	rcu_read_lock();
   	request->engine->submit_request(request);
+	rcu_read_unlock();
   	mutex_unlock(&i915->drm.struct_mutex);
 

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw
Quoted 63 lines · Tvrtko Ursulin
Quoted 61 lines · Daniel Vetter
Quoted 57 lines · Tvrtko Ursulin
Quoted 47 lines · Daniel Vetter

stop_machine is not really a locking primitive we should use, except when the hw folks tell us the hw is broken and that's the only way to work around it.

This patch here is just a suggestion for how to fix it up, possible changes needed to make it actually work:

- Set the nop_submit_request first for _all_ engines, before proceeding.

- Make sure engine->cancel_requests copes with the possibility that not all tests have consistently used the new or old version. I dont think this is a problem, since the same can happen really with the stop_machine() locking - stop_machine also doesn't give you any kind of global ordering against other cpu threads, it just makes them stop.

This patch tries to address the locking snafu from

commit 20e4933c478a1ca694b38fa4ac44d99e659941f5

Author: Chris Wilson <[email protected]>
Date:   Tue Nov 22 14:41:21 2016 +0000

drm/i915: Stop the machine as we install the wedged submit_request
handler

Chris said parts of the reasons for going with stop_machine() was that it's no overhead for the fast-path. But these callbacks use irqsave spinlocks and do a bunch of MMIO, and rcu_read_lock is _real_ fast.

Cc Chris Wilson <[email protected]>
Cc Mika Kuoppala <[email protected]>
---
   drivers/gpu/drm/i915/i915_gem.c                   | 18
+++++-------------
   drivers/gpu/drm/i915/i915_gem_request.c           |  2 ++
   drivers/gpu/drm/i915/selftests/i915_gem_request.c |  2 ++
   3 files changed, 9 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +0 -0
index ab8c6946fea4..0b260e576b4b 100644

drivers/gpu/drm/i915/i915_gem.c static void nop_submit_request(struct · line 3025

Quoted 4 lines
drivers/gpu/drm/i915/i915_gem.c +1 -0
@@ -3022,13 +3022,13 @@ static void nop_submit_request(struct
 drm_i915_gem_request *request)
   static void engine_set_wedged(struct intel_engine_cs *engine)
   {
+       engine->submit_request = nop_submit_request;

Should this be rcu_assign_pointer?

Quoted 6 lines
Quoted 3 lines

Those provide additional barriers, needed when you change/allocate the stuff you're pointing to. We point to immutable functions, so shouldn't be necessary (and would be confusing imo).

Ah ok. Any barriers then? Or synchronize_rcu implies them all?

Yup, at least for simple load/store.

rcu_derefence/rcu_assign_pointer need additional barriers because compilers (and some cpus like alpha) might first load the pointer, then load something through that pointer, then re-load the pointer, and that could mean you see the memory pointed at in a state before rcu_assign_pointer has been called.

On x86 it's just READ_ONCE/WRITE_ONCE, but alpha needs actual hw barriers on top for this.

Quoted 27 lines
Quoted 27 lines
Quoted 16 lines
Quoted 9 lines
drivers/gpu/drm/i915/i915_gem.c +1 -0
+
        /* We need to be sure that no thread is running the old callback

as
* we install the nop handler (otherwise we would submit a
request
- * to hardware that will never complete). In order to prevent
this
- * race, we wait until the machine is idle before making the
swap

drivers/gpu/drm/i915/i915_gem.c static void nop_submit_request(struct drm_i915_gem_request *request) · line 3031

Quoted 5 lines
drivers/gpu/drm/i915/i915_gem.c +2 -2
-        * (using stop_machine()).
+        * to hardware that will never complete).
         */
-       engine->submit_request = nop_submit_request;
+       synchronize_rcu();
Quoted 5 lines

Consumers of this are running in irq disabled or softirq. Does this mean we
would need synchronize_rcu_bh? Would either guarantee all tasklets and irq
handlers have exited?

Oh ... tbh I didn't even digg that deep (much less ran this stuff). This really is an RFC so people with real clue could say whether it has a chance of working or not.

Quoted 8 lines
Quoted 4 lines

Looking at rcu docs we don't want _bh variants, since rcu_read_lock should be safe in even hardirq context. _bh and _sched otoh require that all critical sections are either in bottom halfs or hardirq context, since they treat scheduling of those as a grace period.

rcu_read_unlock might schedule (via preempt_enable) so I don't think we can use them from the fence callbacks.

Only when it's the outermost preeempt_enable, and hard/softirq are special kinds of preempt_disable/enable. See the implementation.

Quoted 2 lines

And _bh is indeed only for softirq while we need hard and soft. So I am not sure which one we could use.

normal/_bh/_sched isn't about where you have your read side critical section, but what other stuff can run in the read side critical section, and hence what counts as a quiescent event:

normal -> no preempt -> task switch is a rcu quiescent state _bh -> no (other) softirq -> sofirq completion is a quiescent state (plus anything where softirq aren't disabled, which can be used to expedite the grace period)
_sched: like _bh, but for hardirq.

And if you need scheduling within your critical section, then use srcu. So different rcu variants trade off overhead and speed of the grace period against what you can get preempted with in the read side critical sections. They don't make restrictions on where your read side critical section can be run. E.g. you could do an srcu read side critical section in a hardirq handler - of course sleeping isn't allowed anymore, but that's because you run in the hardirq handler, not because you're in the read side srcu section.

Quoted 3 lines

It sounds to me any would be wrong and if we wanted to drop stop_machine we would simply have to use nothing. But then we couldn't be certain there are no more new requests queued after wedged has been set.

Just dropping it entirely is definitely not good enough, we've watched that approach go boom already. We do need some ordering to make sure we don't start cleaning up while someone else is still executing code from the old callbacks.

Quoted 1 line

Maybe I am missing something, not sure.

rcu is hard :-)
-Daniel

Quoted 72 lines

Regards,

Tvrtko

Quoted 66 lines

Cheers, Daniel

Quoted 63 lines
Quoted 31 lines
        /* Mark all executing requests as skipped */
        engine->cancel_requests(engine);
drivers/gpu/drm/i915/i915_gem.c +1 -9
@@ -3041,9 +3041,8 @@ static void engine_set_wedged(struct
 intel_engine_cs *engine)
 
 intel_engine_last_submit(engine));
   }
-static int __i915_gem_set_wedged_BKL(void *data)
+void i915_gem_set_wedged(struct drm_i915_private *i915)
   {
-       struct drm_i915_private *i915 = data;
        struct intel_engine_cs *engine;
        enum intel_engine_id id;
@@ -3052,13 +3051,6 @@ static int __i915_gem_set_wedged_BKL(void *data)
        set_bit(I915_WEDGED, &i915->gpu_error.flags);
        wake_up_all(&i915->gpu_error.reset_queue);
-
-       return 0;
-}
-
-void i915_gem_set_wedged(struct drm_i915_private *dev_priv)
-{
-       stop_machine(__i915_gem_set_wedged_BKL, dev_priv, NULL);
   }
   bool i915_gem_unset_wedged(struct drm_i915_private *i915)
drivers/gpu/drm/i915/i915_gem_request.c +0 -0
index b100b38f1dd2..ef78a85cb845 100644

drivers/gpu/drm/i915/i915_gem_request.c submit_notify(struct i915_sw_fence *fence, enum · line 562

Quoted 7 lines
drivers/gpu/drm/i915/i915_gem_request.c +2 -0
@@ -556,7 +556,9 @@ submit_notify(struct i915_sw_fence *fence, enum
 i915_sw_fence_notify state)
        switch (state) {
        case FENCE_COMPLETE:
                trace_i915_gem_request_submit(request);
+               rcu_read_lock();
                request->engine->submit_request(request);
+               rcu_read_unlock();

And _bh for these? Although this already runs with preemption off, but I guess it is good for documentation.

Regards,

Tvrtko

Quoted 16 lines
drivers/gpu/drm/i915/i915_gem_request.c +0 -0
                break;
        case FENCE_FREE:
drivers/gpu/drm/i915/selftests/i915_gem_request.c +2 -0
index 78b9f811707f..a999161e8db1 100644
@@ -215,7 +215,9 @@ static int igt_request_rewind(void *arg)
        }
        i915_gem_request_get(vip);
        i915_add_request(vip);
+       rcu_read_lock();
        request->engine->submit_request(request);
+       rcu_read_unlock();
        mutex_unlock(&i915->drm.struct_mutex);
 
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#10 lore raw

✓ Fi.CI.BAT: success for drm/i915: Use rcu instead of stop_machine

In reply to Daniel Vetter
== Series Details ==

== Series Details ==

Series: drm/i915: Use rcu instead of stop_machine
URL : https://patchwork.freedesktop.org/series/31433/
State : success

== Summary ==

Series 31433v1 drm/i915: Use rcu instead of stop_machine
https://patchwork.freedesktop.org/api/1.0/series/31433/revisions/1/mbox/

Test kms_flip:

        Subgroup basic-flip-vs-dpms:
                dmesg-warn -> PASS       (fi-skl-6700hq)
fi-bdw-5557u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:454s
fi-bdw-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:469s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:392s
fi-bsw-n3050     total:289  pass:243  dwarn:0   dfail:0   fail:0   skip:46  time:559s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:288s
fi-bxt-dsi       total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:523s
fi-bxt-j4205     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:527s
fi-byt-j1900     total:289  pass:253  dwarn:1   dfail:0   fail:0   skip:35  time:537s
fi-byt-n2820     total:289  pass:249  dwarn:1   dfail:0   fail:0   skip:39  time:534s
fi-cfl-s         total:289  pass:256  dwarn:1   dfail:0   fail:0   skip:32  time:560s
fi-cnl-y         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:624s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:441s
fi-glk-1         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:598s
fi-hsw-4770      total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:438s
fi-hsw-4770r     total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:419s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:462s
fi-ivb-3520m     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:510s
fi-ivb-3770      total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:479s
fi-kbl-7500u     total:289  pass:264  dwarn:1   dfail:0   fail:0   skip:24  time:517s
fi-kbl-7560u     total:289  pass:270  dwarn:0   dfail:0   fail:0   skip:19  time:592s
fi-kbl-7567u     total:289  pass:265  dwarn:4   dfail:0   fail:0   skip:20  time:499s
fi-kbl-r         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:594s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:654s
fi-skl-6260u     total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:478s
fi-skl-6700hq    total:289  pass:263  dwarn:0   dfail:0   fail:0   skip:26  time:661s
fi-skl-6700k     total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:534s
fi-skl-6770hq    total:289  pass:269  dwarn:0   dfail:0   fail:0   skip:20  time:517s
fi-skl-gvtdvm    total:289  pass:266  dwarn:0   dfail:0   fail:0   skip:23  time:476s
fi-snb-2520m     total:289  pass:250  dwarn:0   dfail:0   fail:0   skip:39  time:585s
fi-snb-2600      total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:431s

e364976751b3f78eb32ea957eb40deb0682393e5 drm-tip: 2017y-10m-06d-06h-41m-16s UTC integration manifest d571d3c172b7 drm/i915: Use rcu instead of stop_machine

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5913/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

✗ Fi.CI.IGT: failure for drm/i915: Use rcu instead of stop_machine

In reply to Daniel Vetter
== Series Details ==

== Series Details ==

Series: drm/i915: Use rcu instead of stop_machine
URL : https://patchwork.freedesktop.org/series/31433/
State : failure

== Summary ==

Test kms_cursor_crc:

        Subgroup cursor-size-change:
                dmesg-fail -> PASS       (shard-hsw) fdo#102886 +5
Test perf:
        Subgroup polling:
                pass       -> FAIL       (shard-hsw)

fdo#102886 https://bugs.freedesktop.org/show_bug.cgi?id=102886

shard-hsw total:2446 pass:1332 dwarn:1 dfail:0 fail:10 skip:1103 time:10192s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5913/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx