Skip to contentSkip to conversation

isapc: Remove unnecessary migration compatibility code

PATCH In review Eduardo Habkost 2 participants 3 messages Oct 6, 2017 – Oct 10, 2017

lore
Share & tools
lore

Eduardo Habkost

author
#0 lore raw

PATCH 1/1 isapc: Remove unnecessary migration compatibility code

We don't touch isapc when we change guest ABI and add new entries to PC_COMPAT_* or new PCMachineClass compat flags. This means isapc never guaranteed guest ABI and cross-QEMU-version live migration compatibility. There's no point in keeping code for kvm-pv-eoi and APIC ID compatibility in pc_init_isa().

Signed-off-by Eduardo Habkost <[email protected]>
---
 hw/i386/pc_piix.c | 2 --
 1 file changed, 2 deletions(-)
hw/i386/pc_piix.c +0 -2
index 9ff79b1fd9..31646e63c4 100644
@@ -378,8 +378,6 @@ static void pc_compat_0_13(MachineState *machine)
 
 static void pc_init_isa(MachineState *machine)
 {
-    x86_cpu_change_kvm_default("kvm-pv-eoi", NULL);
-    enable_compat_apic_id_mode();
     pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, TYPE_I440FX_PCI_DEVICE);
 }
Signature · 1 line
2.13.6
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · On Fri, 6 Oct 2017 10:25:02 -0300 Eduardo Habkost <[email protected]> wrote:

We don't touch isapc when we change guest ABI and add new entries to PC_COMPAT_* or new PCMachineClass compat flags. This means isapc never guaranteed guest ABI and cross-QEMU-version live migration compatibility. There's no point in keeping code for kvm-pv-eoi and APIC ID compatibility in pc_init_isa().

Signed-off-by Eduardo Habkost <[email protected]>
Reviewed-by Igor Mammedov <[email protected]>
Quoted 17 lines
---
 hw/i386/pc_piix.c | 2 --
 1 file changed, 2 deletions(-)
hw/i386/pc_piix.c +0 -2
index 9ff79b1fd9..31646e63c4 100644
@@ -378,8 +378,6 @@ static void pc_compat_0_13(MachineState *machine)
 
 static void pc_init_isa(MachineState *machine)
 {
-    x86_cpu_change_kvm_default("kvm-pv-eoi", NULL);
-    enable_compat_apic_id_mode();
     pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, TYPE_I440FX_PCI_DEVICE);
 }
author
#2 lore raw
Quoted 11 lines · Igor Mammedov
Quoted 7 lines · On Fri, 6 Oct 2017 10:25:02 -0300 Eduardo Habkost <[email protected]> wrote:

We don't touch isapc when we change guest ABI and add new entries to PC_COMPAT_* or new PCMachineClass compat flags. This means isapc never guaranteed guest ABI and cross-QEMU-version live migration compatibility. There's no point in keeping code for kvm-pv-eoi and APIC ID compatibility in pc_init_isa().

Signed-off-by Eduardo Habkost <[email protected]>
Reviewed-by Igor Mammedov <[email protected]>

Thanks!

Michael, do you prefer those pc*.c patches that touch only CPU-related code to go always through your tree, or can I merge them through x86-next without your Acked-by if it's appropriate?

Quoted 19 lines
Quoted 18 lines
---
 hw/i386/pc_piix.c | 2 --
 1 file changed, 2 deletions(-)
hw/i386/pc_piix.c +0 -2
index 9ff79b1fd9..31646e63c4 100644
@@ -378,8 +378,6 @@ static void pc_compat_0_13(MachineState *machine)
 
 static void pc_init_isa(MachineState *machine)
 {
-    x86_cpu_change_kvm_default("kvm-pv-eoi", NULL);
-    enable_compat_apic_id_mode();
     pc_init1(machine, TYPE_I440FX_PCI_HOST_BRIDGE, TYPE_I440FX_PCI_DEVICE);
 }
Signature · 1 line
Eduardo