Skip to contentSkip to conversation

omap: Omit fastboot.userdata_size related errors

PATCH New Sam Protsenko 2 participants 2 messages Sep 21, 2017 – Oct 7, 2017

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Sam Protsenko

author
#0 lore raw

PATCH 1/1 omap: Omit fastboot.userdata_size related errors

When using regular $partitions variable (for Linux boot), we can see some unwanted messages:

Quoted 4 lines

ERROR: cannot find partition: 'userdata'

at arch/arm/mach-omap2/utils.c:96/omap_mmc_get_part_size()
Warning: fastboot.userdata_size: unable to calc

Let's remove those, as missing 'userdata' partition is correct behavior for Linux partition, and we don't want to see some Android-related messages in this case.

Signed-off-by Sam Protsenko <[email protected]>
---
 arch/arm/mach-omap2/utils.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)
arch/arm/mach-omap2/utils.c +4 -9
index 0b0bf1837c..3892853c7e 100644
@@ -92,10 +92,8 @@ static u32 omap_mmc_get_part_size(const char *part)
 	}
 
 	res = part_get_info_by_name(dev_desc, part, &info);
-	if (res < 0) {
-		error("cannot find partition: '%s'\n", part);
+	if (res < 0)
 		return 0;
-	}
 
 	/* Calculate size in bytes */
 	sz = (info.size * (u64)info.blksz);

@@ -111,13 +109,10 @@ static void omap_set_fastboot_userdata_size(void)
 	u32 sz_kb;
 
 	sz_kb = omap_mmc_get_part_size("userdata");
-	if (sz_kb == 0) {
-		buf[0] = '\0';
-		printf("Warning: fastboot.userdata_size: unable to calc\n");
-	} else {
-		sprintf(buf, "%u", sz_kb);
-	}
+	if (sz_kb == 0)
+		return; /* probably it's not Android partition table */
 
+	sprintf(buf, "%u", sz_kb);
 	env_set("fastboot.userdata_size", buf);
 }
 #else
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 omap: Omit fastboot.userdata_size related errors

Quoted 5 lines · Sam Protsenko

When using regular $partitions variable (for Linux boot), we can see some unwanted messages:

Quoted 1 line

ERROR: cannot find partition: 'userdata'

Quoted 8 lines
Quoted 2 lines

at arch/arm/mach-omap2/utils.c:96/omap_mmc_get_part_size()
Warning: fastboot.userdata_size: unable to calc

Let's remove those, as missing 'userdata' partition is correct behavior for Linux partition, and we don't want to see some Android-related messages in this case.

Signed-off-by Sam Protsenko <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171007/4018e3d3/attachment.sig>