armv8: configs: ls1012a: correct the generic timer frequency issue

PATCH New andy.tang at nxp.com 3 participants 4 messages Oct 9, 2017 – Oct 10, 2017

lore

Share & tools

lore

andy.tang at nxp.com

author

2017-10-09 06:30 UTC #0 lore raw

PATCH 1/1 armv8: configs: ls1012a: correct the generic timer frequency issue

From: Yuantian Tang <[email protected]>

Generic Timer frequency should be 25Mhz. Current setting is CONFIG_SYS_CLK_FREQ/4 which is about 31Mhz, which is not correct. So correct it.

Signed-off-by Tang Yuantian <[email protected]>

---
 include/configs/ls1012a_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

include/configs/ls1012a_common.h +1 -1

index 096799eb64..a4e78f335f 100644
@@ -32,7 +32,7 @@
 #define CONFIG_SYS_DDR_BLOCK2_BASE     0x880000000ULL
 
 /* Generic Timer Definitions */
-#define COUNTER_FREQUENCY		CONFIG_SYS_CLK_FREQ/4	/* 25MHz */
+#define COUNTER_FREQUENCY		25000000	/* 25MHz */
 
 /* CSU */
 #define CONFIG_LAYERSCAPE_NS_ACCESS

Signature · 1 line

2.14.1

LS1012A use fixed 25MHz clock, doesn't it? If so, that's the reason a fixed value should be used, not because CONFIG_SYS_CLK_FREQ/4 isn't correct. It is correct for many other platform. Please update the commit message.

York

Andy Tang

author

2017-10-10 01:06 UTC #2 lore raw

PATCH 1/1 armv8: configs: ls1012a: correct the generic timer frequency issue

Hi York,

Ls1012a uses the fixed 25Mhz clock, I will update the commit message and resend the patch.

Thanks,
Andy

Quoted 43 lines

-----Original Message-----
From: York Sun
Sent: Tuesday, October 10, 2017 12:00 AM
To: Andy Tang <[email protected]>
Cc: sjg at chromium.org; u-boot at lists.denx.de
Subject: Re: [PATCH] armv8: configs: ls1012a: correct the generic timer frequency issue
Quoted 17 lines · andy.tang at nxp.com
From: Yuantian Tang <[email protected]>
Generic Timer frequency should be 25Mhz. Current setting is CONFIG_SYS_CLK_FREQ/4 which is about 31Mhz, which is not correct. So correct it.
Signed-off-by Tang Yuantian <[email protected]>
---
 include/configs/ls1012a_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/ls1012a_common.h +0 -0
index 096799eb64..a4e78f335f 100644
include/configs/ls1012a_common.h line 35
Quoted 4 lines
include/configs/ls1012a_common.h +0 -1
@@ -32,7 +32,7 @@
 #define CONFIG_SYS_DDR_BLOCK2_BASE     0x880000000ULL
 
 /* Generic Timer Definitions */
-#define COUNTER_FREQUENCY		CONFIG_SYS_CLK_FREQ/4
	/* 25MHz */
include/configs/ls1012a_common.h line 36
Quoted 2 lines
include/configs/ls1012a_common.h +1 -0
+#define COUNTER_FREQUENCY		25000000	/* 25MHz */
 
Yuantian,
LS1012A use fixed 25MHz clock, doesn't it? If so, that's the reason a fixed value should be used, not because CONFIG_SYS_CLK_FREQ/4 isn't correct. It is correct for many other platform. Please update the commit message.
York

Prabhakar Kushwaha

2017-10-10 04:42 UTC #3 lore raw

PATCH 1/1 armv8: configs: ls1012a: correct the generic timer frequency issue

Hi York,

Quoted 8 lines

-----Original Message-----
From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Andy Tang
Sent: Tuesday, October 10, 2017 6:36 AM
To: York Sun <[email protected]>
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] armv8: configs: ls1012a: correct the generic timer frequency issue

Quoted 49 lines

Hi York,
Ls1012a uses the fixed 25Mhz clock, I will update the commit message and resend the patch.
Thanks,
Andy
Quoted 41 lines
-----Original Message-----
From: York Sun
Sent: Tuesday, October 10, 2017 12:00 AM
To: Andy Tang <[email protected]>
Cc: sjg at chromium.org; u-boot at lists.denx.de
Subject: Re: [PATCH] armv8: configs: ls1012a: correct the generic timer frequency issue
Quoted 17 lines · andy.tang at nxp.com
From: Yuantian Tang <[email protected]>
Generic Timer frequency should be 25Mhz. Current setting is CONFIG_SYS_CLK_FREQ/4 which is about 31Mhz, which is not correct. So correct it.
Signed-off-by Tang Yuantian <[email protected]>
---
 include/configs/ls1012a_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/ls1012a_common.h +0 -0
index 096799eb64..a4e78f335f 100644
include/configs/ls1012a_common.h line 35
Quoted 4 lines
include/configs/ls1012a_common.h +0 -1
@@ -32,7 +32,7 @@
 #define CONFIG_SYS_DDR_BLOCK2_BASE     0x880000000ULL
 
 /* Generic Timer Definitions */
-#define COUNTER_FREQUENCY		CONFIG_SYS_CLK_FREQ/4
	/* 25MHz */
include/configs/ls1012a_common.h line 36
Quoted 2 lines
include/configs/ls1012a_common.h +1 -0
+#define COUNTER_FREQUENCY		25000000	/* 25MHz */
 
Yuantian,
LS1012A use fixed 25MHz clock, doesn't it? If so, that's the reason a fixed value should be used, not because CONFIG_SYS_CLK_FREQ/4 isn't correct. It is correct for many other platform. Please update the commit message.

LS1012A has fixed external clock 25MHz which generates following 2 internal clocks
- Core clock (100MHz)
- Platform clock (133MHz)

System counter run with Core clock i.e. 100MHz.

So patch description should mention reference of Core Clock instead of external 25MHz fix clock.

--pk